From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: sbaugh@catern.com Newsgroups: gmane.emacs.bugs Subject: bug#64619: [PATCH] Add toggle-window-dedicated command Date: Sat, 19 Aug 2023 20:06:16 +0000 (UTC) Message-ID: <87350ere4n.fsf@catern.com> References: <87h6ovgnpn.fsf@catern.com> <387ee04aa9601b936ac5@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6215"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Spencer Baugh , Philip Kaludercic , 64619@debbugs.gnu.org, martin rudalics , Eli Zaretskii , Drew Adams To: Gregory Heytings Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 19 22:07:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qXSEB-0001KU-JB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Aug 2023 22:07:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qXSDu-0001UN-7y; Sat, 19 Aug 2023 16:07:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qXSDs-0001U1-QO for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 16:07:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qXSDs-0003f3-I5 for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 16:07:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qXSDt-00012r-Mk for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2023 16:07:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: sbaugh@catern.com Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2023 20:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64619-submit@debbugs.gnu.org id=B64619.16924755863976 (code B ref 64619); Sat, 19 Aug 2023 20:07:01 +0000 Original-Received: (at 64619) by debbugs.gnu.org; 19 Aug 2023 20:06:26 +0000 Original-Received: from localhost ([127.0.0.1]:52353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXSDJ-000124-Te for submit@debbugs.gnu.org; Sat, 19 Aug 2023 16:06:26 -0400 Original-Received: from s.wrqvtzvf.outbound-mail.sendgrid.net ([149.72.126.143]:39268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qXSDH-00011q-IN for 64619@debbugs.gnu.org; Sat, 19 Aug 2023 16:06:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=3hNCndPIiaDQcfS0FhWHQdte1k5HfzrXAI/xUPWJKHw=; b=Dcwk2CzM8mqLj5kUUzqPNLJb8Pt+jdIPEoKdKGsnIkuJG0L4V8Ub7QBph1nN3S9CKh2z uYhuUWeb//qFm+fegIu5E9DgImtOl0jHlDKhxndU0QSmyil3kFrPA2m2NMH9dhawgnnFEp ONfdv74qC9QWKWzCCS14Cs5qRYCMt4nUM5gqdPAV+4Hcd5/aRxR9zQ1HtU3JFY7RInE80s gMVnnxzPVfxjlHMHM3pUK+FZvvcmN9NtU1eP+8ka1misgoWdYTW1CdfE2Een6HG2669wJg OrlnweNyODS1yOvNK14yvGjDzwj29ACSe2N3Vv/Adb8P9bZ8cwS77X2++waS6O2A== Original-Received: by filterdrecv-d7bbbc8bf-nxr9l with SMTP id filterdrecv-d7bbbc8bf-nxr9l-1-64E120B8-A 2023-08-19 20:06:16.578461895 +0000 UTC m=+8713598.664195316 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-32 (SG) with ESMTP id rVeQPGoDS7W0V0v16xr8SQ Sat, 19 Aug 2023 20:06:16.421 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=::1; helo=localhost; envelope-from=sbaugh@catern.com; receiver=heytings.org Original-Received: from localhost (localhost [IPv6:::1]) by earth.catern.com (Postfix) with ESMTPSA id 0AE2862566; Sat, 19 Aug 2023 16:06:16 -0400 (EDT) In-Reply-To: <387ee04aa9601b936ac5@heytings.org> (Gregory Heytings's message of "Sat, 19 Aug 2023 16:43:15 +0000") X-SG-EID: ZgbRq7gjGrt0q/Pjvxk7wM0yQFRdOkTJAtEbkjCkHbJEB53UFDEXCJZNkpipgCFFYnIA1Rug3AHvbOqvLE0JiKo1qIONWY0T2z7dUdiLmdv1LgBOVLP/hKYvZpV2AQ4DdBSsJ5WepEI3b/ADLx/YcWWn/mnIvfEx7NadmUs0tWjkb8srw29Yfb5NpyODIl/cjbLsy1OPqHYq/3ohozh/oQ== X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267914 Archived-At: Gregory Heytings writes: >>> OK, this patch adds support for making the buffer strongly >>> dedicated with a prefix argument, and also adds an indicator to the >>> mode line of whether the current window is dedicated (which seems >>> useful even if we don't apply the toggle part of this patch). >> >> Any thoughts on this patch? >> > > Two thoughs: > > 1. I would simplify the body of toggle-window-dedicated, using > > (set-window-dedicated-p window (not (window-dedicated-p))) > > This makes the window "strongly" dedicated, which is more in line with > what "Window will now display only its current buffer" promises > (e.g. C-x b will refuse to switch to another buffer). Ah, see earlier discussion. We at least want to be able to choose between strong and non-strong dedication. And having used this command I think non-strong dedication is a much better default, since it allows users to explicitly run C-x b to change buffers without having to switch off dedication. > 2. I would not bind it to the "d" key but to the "!" key: ISTM that > toggling window dedication is not such a common action that it needs a > letter key binding. It's not common at the moment, but I expect some users will use this command quite frequently. Also the C-x w prefix is pretty empty at the moment, so it's not as if it's competing with anything.