From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#66993: [PATCH] project.el: avoid asking user about project-list-file lock Date: Sun, 19 Nov 2023 14:54:27 +0000 (UTC) Message-ID: <8734x1n691.fsf@catern.com> References: <83sf5g1lko.fsf@gnu.org> <9d460f36-6035-da54-3abc-12171ac8977f@gutov.dev> <83h6lw19zw.fsf@gnu.org> <894f674f-76ea-90af-3acc-73ca6e7caf35@gutov.dev> <834jhv1lfw.fsf@gnu.org> <83ttpvyxn0.fsf@gnu.org> <42fe7d0e-024c-3e0d-3bc5-b0e6ec50f260@gutov.dev> <83r0kzyo93.fsf@gnu.org> <4b4a190a-ec88-6f50-1f94-900b3afdfc41@gutov.dev> <87sf53m59w.fsf@catern.com> <83a5rbm3j9.fsf@gnu.org> <87cyw6mzdf.fsf@catern.com> <83ttpil1lx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6098"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66993@debbugs.gnu.org, sbaugh@janestreet.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 19 15:55:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4jCg-0001Kz-LI for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 19 Nov 2023 15:55:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4jCQ-0002Ub-GX; Sun, 19 Nov 2023 09:55:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4jCP-0002US-Gu for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 09:55:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4jCP-00020H-8K for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 09:55:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4jCQ-0000BP-GO for bug-gnu-emacs@gnu.org; Sun, 19 Nov 2023 09:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 19 Nov 2023 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66993 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66993-submit@debbugs.gnu.org id=B66993.1700405681658 (code B ref 66993); Sun, 19 Nov 2023 14:55:02 +0000 Original-Received: (at 66993) by debbugs.gnu.org; 19 Nov 2023 14:54:41 +0000 Original-Received: from localhost ([127.0.0.1]:50249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4jC4-0000AY-FT for submit@debbugs.gnu.org; Sun, 19 Nov 2023 09:54:40 -0500 Original-Received: from s.wrqvtbkv.outbound-mail.sendgrid.net ([149.72.123.24]:56344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4jBy-0000AG-N2 for 66993@debbugs.gnu.org; Sun, 19 Nov 2023 09:54:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=catern.com; h=from:subject:in-reply-to:references:mime-version:to:cc:content-type: content-transfer-encoding:cc:content-type:from:subject:to; s=s1; bh=ULsMCkujmWi6y/WfL57IXOZRPK2vLaks+bp3WBHLSsQ=; b=ZTlC5ELRsO9/7o0lsGSK1s8qUEzuHBIGpA/b8BhhZdlOxLKiPP0tKrc2tS1Oh+ms/GPZ ZR8Awx4AjjQkoNK2T1cBbxtkyjKgiFKhzDcEPUq7DVXMNGkf/Am403QyZBuR4VbEfCiJ32 yto4DYFG/0j6llSNIQFgKtKK+P0OBolgfTrXJd0OjERc0QskBCyFeqdrc/G6RI53yLAd9u AW2avNayl29nTFFugJTZrhbpqfj0qXq7v+OBqiVFlPjgL/wqnZOeJtvvwqJXOC4NSTL9AJ Li5aBRGEacv66wbAShAL5Ohi5rD4BdGmtteeZtYFejkphYsZg7bdOQHMR1I7GKVg== Original-Received: by filterdrecv-d585b8d85-kx4qj with SMTP id filterdrecv-d585b8d85-kx4qj-1-655A21A3-8 2023-11-19 14:54:27.310950541 +0000 UTC m=+2837654.355768954 Original-Received: from earth.catern.com (unknown) by geopod-ismtpd-6 (SG) with ESMTP id gA0WEvcvSKmM3fbN1VXM0w Sun, 19 Nov 2023 14:54:27.081 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=74.101.51.129; helo=localhost; envelope-from=sbaugh@catern.com; receiver=gnu.org Original-Received: from localhost (unknown [74.101.51.129]) by earth.catern.com (Postfix) with ESMTPSA id 1146A62E3C; Sun, 19 Nov 2023 14:54:18 +0000 (UTC) In-Reply-To: <83ttpil1lx.fsf@gnu.org> X-SG-EID: GW3oCMoYnalRiojMOuLzE6x2H5kORXvlCdz1UwQVRMVT4fbh9ODEfCogOe74cOrI4e0V+MFZgakz9Re5a6/Cgg0QZ8UizsfdGOkYV8VgClZMg7gzHR9i2VLIgpcgvoLdrumheiOUfoN91L3XSBMyD8keMfgdNYv0tiLqKuuyQTZZynob43eOV6HO8oJChTNJBsKAhECPDQjsg+fcE4iRVRpIJGeoExdR9obisFEiW+hAjIN3KYlus3mh5yPTsqza X-Entity-ID: d/0VcHixlS0t7iB1YKCv4Q== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274620 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Date: Sat, 18 Nov 2023 23:10:43 +0000 (UTC) >> Cc: dmitry@gutov.dev, sbaugh@janestreet.com, 66993@debbugs.gnu.org >> >> Eli Zaretskii writes: >> >> But actually, maybe it's time that we just enable savehist by default. >> > >> > Even if we decide to do that (and I'm not at all sure we should), how >> > would that solve the difficulty pointed out by Dmitry? Even if >> > savehist is ON by default, the user could turn it OFF, right? >> >> That's fine, we'd still be preserving backwards-compatibility: >> project--list would still be saved by default. The user could turn it >> off, if they want, but that's not a problem - they can turn it off if >> they want. > > IMNSHO, it is a very bad idea to have one feature turn on and off as a > side effect of another, unrelated feature. We should not have such > inelegant dependencies. savehist is a general-purpose feature which > saves the history of important user actions, whereas the history of > projects is a completely different feature from a much more narrow > area of user activities. They should not depend on one another, not > directly anyway. project-prompt-project-dir minibuffer history is is in fact the same feature as (for example) read-file-name minibuffer history, we just didn't realize it before and so we unnecessarily implemented separate logic for persisting it. If savehist had been on by default when project.el was added, there would have been no need for the separate logic. So it makes sense for them to be unified. (They can still be turned off independently with savehist configuration, of course, if the user wants to)