From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69606: [PATCH] Ensure default-directory exists when generating diff Date: Sat, 09 Mar 2024 17:45:56 +0100 Message-ID: <8734szz73v.fsf@gmx.de> References: <87v85yo0h7.fsf@posteo.net> <87bk7q2vkx.fsf@gmx.de> <87sf115fn2.fsf@posteo.net> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26352"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 69606@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 09 17:46:45 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rizqP-0006gc-9S for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Mar 2024 17:46:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rizqB-00044l-Ry; Sat, 09 Mar 2024 11:46:31 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rizq9-00044M-S9 for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 11:46:29 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rizq9-0003fq-Kj for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 11:46:29 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rizqf-0003Wc-Rv for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 11:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Mar 2024 16:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69606 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69606-submit@debbugs.gnu.org id=B69606.171000280013522 (code B ref 69606); Sat, 09 Mar 2024 16:47:01 +0000 Original-Received: (at 69606) by debbugs.gnu.org; 9 Mar 2024 16:46:40 +0000 Original-Received: from localhost ([127.0.0.1]:34700 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rizqJ-0003W2-Ki for submit@debbugs.gnu.org; Sat, 09 Mar 2024 11:46:39 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:38469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rizqG-0003Vf-Q2 for 69606@debbugs.gnu.org; Sat, 09 Mar 2024 11:46:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1710002757; x=1710607557; i=michael.albinus@gmx.de; bh=tkQb+HCXPXi3oh/Vmwr73luKiHTIdiCIE8dPoQfujaw=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References: Date; b=E1E2uVAblfgql9Ocz8gizECLYsEnO0c+e3H32eoQpbLwWQoxN351uUSYHi72d+SC Q7Q6J4RN+6pDdo6rT6gy3uD08oKjIgDQkXk1V3lh7vPY2cqTY80i9D9z/OwURQoUB eG2MOCD6uKvAgson39DkKD323QELLCfeHNW+psUHKx1r2zWQ1rub95i3PK4gWQjUm yMDuEW0kw9zCTZuBnFrrOWh1/8aKSi7kiMm8TSNII3lx8POzcqt5f2c2r0/thvYc5 yKh9pDe+J2Xd0z0VxGAV98XvOUnfG7qo5D7f55S0lGomopcnVxucchvswieV6j4xC PAxB0+3Nz/NYg+bqGg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.39.16]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M9nxn-1rmYjo1Xlt-005mYd; Sat, 09 Mar 2024 17:45:57 +0100 In-Reply-To: <87sf115fn2.fsf@posteo.net> (Philip Kaludercic's message of "Fri, 08 Mar 2024 07:47:29 +0000") X-Provags-ID: V03:K1:UwUF1KxMH9GNmQY2Lg9P2lP+mjWXVllr6M/FqEFxFeSvGNJddbf 0ciE6M5GRShS0MORwOPiGm0HoRuY4naaWucIoHEyE4VOPgRMOqXQChlrd5do7HSvn2QCSwg rFWYHRnSNqNwviQ04z8xGrD668lMsGUGFmyqzrk7yWXlD548SSq9VkLUgCXi0IewLel6v8w 9NWN4Zm/kQiCnUoz9ywTg== UI-OutboundReport: notjunk:1;M01:P0:ryLRTJuttls=;IhpNrN2s0akAIv0tVWozEJ+e96x XECgmRmq1MF8NaDWFRRWfnD40jS2kDtZfrDrM0wqn7WfqoS7jnHvv5dJXO475jEEvff7ojQxA RHYcp1R90Ob46KTKfFA6KAi8tGuPkr0OPJrqfsXRKuzDPo3vQkxPbZRmwKdl4vV1GefamiFMi gZPym1L1VQ2rXEryTILHYAklGn3jcXqdd0C+XlVmNhbxwhxJ4GyqHMjtPkRD4GDqjt8b7rBo9 U8BE6IS/ZgiQ49EkNyYAo0Yt6BbK2kaSrmHCQxiZK3ubQM7nveRv0+LrIFVnAIHBJ2sRU1cMG pPzG2xURHW+1yyAlh3q/2k0tMvOKmEffPvqqshCTW8Z8WvH7GdjZJGkAdluE/Usb2Yime/lUM ewvSK6Jrrwyo7+cEJhg8qyLsdaVSKDWeHGiPNm5gPQ4CgP+Xz8UViKORM0fvj2KHUgjC0efF3 brB8gi+XPshrkJ/e7k7uDBWpyq8NeihoMWaCnB8kHlgtzkkZcUqdNYFtlQoZEj9YCfppcvHo7 anebt1EkxWgAN0vpXD7VmvwyhQkeTJgJORma6ei879X73tAwXWDPHFJSLeKxwh0lPbHGxgq8C o70nFWtGneQpGs5beMCRbRhCiCtFrsYKPPPvUSWTBZ9SoE/E8klR4panXnW3Cmq9SyRGPweJE F/dcpsGdpDCo394oFYqmM0Voe3zxLUWfRPFlPAWw5LBdyIgfjweRfJVzp7B+zJXkIP/EIjIEb ENz6ZjmhlLKUl9wSKtU6OFjKrib/Jw9/aJ3krq9rhuypQZAeLiE2NUfIAXT5iUMPgcrvq9o2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281348 Archived-At: Philip Kaludercic writes: Hi Philip, > The reason I was thinking about a more general solution, is that > something like > > (let ((default-directory "/this/does/not/exists")) > (make-process :command '("true"))) > > will always fail, even though "true" doesn't use the current working > directory. I think it would be useful to have some :fallback option for > these situations, to ensure that if `default-directory' doesn't exist, > any other directory should be used instead. This is a more general request than just make it work for "diff". Well, there is a reason that `default-directory' isn't set to something else behind your back, if it doesn't exist. Processes can use relative file names as arguments, and it is always better to fail with an error message instead of doing something unexpected you even don't know about. Best regards, Michael.