unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: bjorn.bidar@thaodan.de, juri@linkov.net, 70385@debbugs.gnu.org,
	vekazanov@gmail.com
Subject: bug#70385: Crash in note_fringe_highlight
Date: Mon, 15 Apr 2024 19:57:44 +0800	[thread overview]
Message-ID: <8734rm25zb.fsf@yahoo.com> (raw)
In-Reply-To: <86r0f6lv76.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 15 Apr 2024 14:30:21 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

> Any reason you didn't include w->window_end_valid in the condition,
> like we do for mouse-highlight?

This wasn't necessary to fix the crash for me.

> I'd like in general to have the same conditions, to avoid having
> people wonder what they miss when they read this code.

Your wish is my command... :-)

I suspect it might fix the Bjorn's crash also.  Bjorn, please try:

diff --git a/src/xdisp.c b/src/xdisp.c
index d984c12d1aa..51f6b1efd69 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -35771,9 +35771,10 @@ note_fringe_highlight (struct frame *f, Lisp_Object window, int x, int y,
 
   /* Don't access the TEXT_AREA of a row that does not display text, or
      when the window is outdated.  (bug#70385) */
-  if (window_outdated (w)
-      || !MATRIX_ROW_DISPLAYS_TEXT_P (MATRIX_ROW (w->current_matrix,
-						  vpos)))
+  if ((window_outdated (w)
+       || !MATRIX_ROW_DISPLAYS_TEXT_P (MATRIX_ROW (w->current_matrix,
+						   vpos)))
+      && w->window_end_valid)
     return;
 
   /* Get to the first glyph of a text row based on the vertical position





  reply	other threads:[~2024-04-15 11:57 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-14 16:10 bug#70385: Crash in note_fringe_highlight Juri Linkov
2024-04-14 16:40 ` Eli Zaretskii
2024-04-14 16:41   ` Vladimir Kazanov
2024-04-15 16:39   ` Juri Linkov
2024-04-18 11:08     ` Eli Zaretskii
2024-04-18 17:10       ` Juri Linkov
2024-04-18 17:55         ` Eli Zaretskii
2024-04-14 16:40 ` Vladimir Kazanov
2024-04-14 20:13   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <87zftv7leb.fsf@>
2024-04-14 20:22     ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-14 20:22     ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]   ` <87edb73d9u.fsf@>
2024-04-15  1:32     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15  6:29       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15  6:29       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15  6:31       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]       ` <87bk6b16ii.fsf@>
2024-04-15  6:49         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 11:06           ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]           ` <661d0a70.0c0a0220.5de8.ce32SMTPIN_ADDED_BROKEN@mx.google.com>
2024-04-15 11:09             ` Vladimir Kazanov
     [not found]           ` <875xwiubq5.fsf@>
2024-04-15 11:26             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 12:55               ` Eli Zaretskii
2024-04-18 11:06             ` Eli Zaretskii
2024-04-18 14:34               ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]               ` <87edb2buyu.fsf@>
2024-04-18 14:48                 ` Eli Zaretskii
2024-04-15 11:30       ` Eli Zaretskii
2024-04-15 11:57         ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-04-15 13:03           ` Eli Zaretskii
2024-04-15 13:58             ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 14:39               ` Eli Zaretskii
2024-04-15 17:04               ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15 17:04               ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]               ` <87ttk2sgl9.fsf@>
2024-04-15 18:23                 ` Eli Zaretskii
2024-04-15 19:20                   ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
     [not found]                   ` <87mspuph44.fsf@>
2024-04-16  6:52                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-16 10:56                       ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-15  6:49   ` Juri Linkov
2024-04-15  8:22     ` Vladimir Kazanov
2024-04-15 11:55       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734rm25zb.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=70385@debbugs.gnu.org \
    --cc=bjorn.bidar@thaodan.de \
    --cc=eliz@gnu.org \
    --cc=juri@linkov.net \
    --cc=luangruo@yahoo.com \
    --cc=vekazanov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).