From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jacob Leeming Newsgroups: gmane.emacs.bugs Subject: bug#70345: [PATCH] 29.1.50; csharp-ts-mode indentation of if statements with single-statement body Date: Fri, 26 Apr 2024 14:53:36 +0100 Message-ID: <8734r8xman.fsf@gmail.com> References: <87o7afod31.fsf@gmail.com> <87mspusb5k.fsf@thornhill.no> <87wmopaii8.fsf@gmail.com> <867cgl1la9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4610"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 70345@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 26 15:55:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s0M2r-0000u9-G7 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Apr 2024 15:55:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s0M2U-0006Az-IH; Fri, 26 Apr 2024 09:54:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s0M2S-0006AT-Nk for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 09:54:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s0M2S-00039l-CY for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 09:54:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s0M2j-00067j-W7 for bug-gnu-emacs@gnu.org; Fri, 26 Apr 2024 09:55:14 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jacob Leeming Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Apr 2024 13:55:13 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70345 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70345-submit@debbugs.gnu.org id=B70345.171413965922967 (code B ref 70345); Fri, 26 Apr 2024 13:55:13 +0000 Original-Received: (at 70345) by debbugs.gnu.org; 26 Apr 2024 13:54:19 +0000 Original-Received: from localhost ([127.0.0.1]:34408 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0M1h-0005wd-KV for submit@debbugs.gnu.org; Fri, 26 Apr 2024 09:54:16 -0400 Original-Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]:55380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s0M1a-0005uV-5L for 70345@debbugs.gnu.org; Fri, 26 Apr 2024 09:54:06 -0400 Original-Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-a55b3d57277so272907966b.2 for <70345@debbugs.gnu.org>; Fri, 26 Apr 2024 06:53:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714139618; x=1714744418; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=dXFOGPNgVv9V4pgx9SeMhZOq89sAsW9V1qpanw+FzAY=; b=kwDijHb/tQXvb1jemgUt/E4gIUTm144uE6aurqUBDt1JTFEFarlvvabyjYv/OfpDOk r0HV/VYPmw3S2g9kXGghU7wqR+0EZ+3S1XAfVxuIei/iKvwyLb9ZIipcxhM4DgKHzgXo bHy2bbsLWeTzRs6eo0tR845enCtRFQNn1ammwZAfUE26vAty000TO9/QzCmwqPKcV9Ki qLivqxy6Gp763HzlemqQno9b8OxxU3JwR5D3APXlU8JyIB+qwMJkppeSGc9s6RoDyA38 5x6JQyNlcOmHxjVKR1Pf00GTdlBdiCnA6DmypYAIMdBzaMUZVFIFnFAlpNFAoXO2+2X4 8itw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714139618; x=1714744418; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dXFOGPNgVv9V4pgx9SeMhZOq89sAsW9V1qpanw+FzAY=; b=muYeIO/t5aeppzmzau+eruiSJg3DMZwVyJXnpKwJCFczBhhicPQn1GFZIRQtesC5BW 2Ko7xUYzajtWIHwpx5rDCR5SnWhmuUiojbAK8LCh7Yvi3m2mWuQXvDLpReVqgmVeW4aw AhQwJZKmtNy2c2x9vrCP9K7BVb8ogoz277pfcRexejfych87aXDAfYDEGym8xnZb2GWC r+YfPDaWCU7hUFCx9DXIOdP+JG26a/aDYtcl5D4tBr0eTMmqSg1PpEWMVPx9UomczplH E5FDCKhHXDuGT2ZiTDTcmRj3EhfsHWbczUEdK+SJVD+SgADUiP9OkN5xpgEPhh8A5D8N V72A== X-Gm-Message-State: AOJu0Yx5NaXy5mpNT8bo8ibmJah8VBpckQmyPOkh/mOioPfGT47FbO3S HFDUGgs7h7N3THHYH7gClLjo4MwgcCmz0g6nYMjocDdREhCMtNccP4q5pw== X-Google-Smtp-Source: AGHT+IFFViuXJDaL+nd6gogkdngfyHApFOOfknCqvq01mGvebfDyhkaLLnm2fL+VxT8T3Lcr+xMoeA== X-Received: by 2002:a17:906:a152:b0:a51:c88e:e95a with SMTP id bu18-20020a170906a15200b00a51c88ee95amr2036945ejb.23.1714139617606; Fri, 26 Apr 2024 06:53:37 -0700 (PDT) Original-Received: from jacobDebianWorkLaptop ([154.51.68.114]) by smtp.gmail.com with ESMTPSA id i9-20020a170906090900b00a55b05c4598sm6618074ejd.133.2024.04.26.06.53.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 06:53:37 -0700 (PDT) In-Reply-To: <867cgl1la9.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Apr 2024 19:04:14 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283991 Archived-At: Eli Zaretskii writes: >> Cc: 70345@debbugs.gnu.org, Jacob Leeming >> From: Jacob Leeming >> Date: Mon, 22 Apr 2024 09:50:23 +0100 >> >> > Looks good to me. Are you willing to pack this up with a nice test >> > confirming the behavior? >> > >> > All the best, >> > Theo >> >> Thanks all, >> >> Discovered we had a similar issue for else blocks. Wrote a test that >> covers both cases. >> >> See the attached diff which contains my changes to the indent rules and >> the test. > > Thanks, I installed this on the emacs-29 branch. (The test you added > should have been added to csharp-mode-tests.el, since our test files > follow the names of the implementation files, and csharp-ts-mode is > implemented in csharp-mode.el. I fixed that.) > > With this changeset you have exhausted the amount of changes that we > can accept from you without copyright assignment. Would you like to > start the paperwork of assigning the copyright at this time, so that > we could accept your contributions in the future without limitations? > If yes, I will send you the form to fill and the instructions to send > the form. > > I'm closing this bug. Thanks Eli, Please send the paperwork! I'll get it filled in and sent off when possible. If I have future questions about the paperwork, is it best to use the emacs devel mailing list? Cheers, Jacob