From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#71049: async-shell-command ends with "Process *Async Shell Command* finished" when remote "direct-async-process" Date: Fri, 31 May 2024 09:27:36 +0200 Message-ID: <8734py785z.fsf@gmx.de> References: <3a497741-2ad0-4919-b7c9-cdb36b0eb455@gutov.dev> <221919a1-950e-4ef3-975d-f86078d8e105@gutov.dev> <87wmnidv3u.fsf@gmx.de> <25dad14a-397c-4052-908c-121e40bbef51@gutov.dev> <877cfhubyd.fsf@gmx.de> <608acf89-a1f9-4151-9f53-99962af87688@gutov.dev> <87jzjhvnbw.fsf@gmx.de> <50900208-34b8-4b7c-90fc-8796da6bccd6@gutov.dev> <87cyp9vlb1.fsf@gmx.de> <87fru4u06a.fsf@gmx.de> <7989cd21-7808-4416-ab0a-92e5da869a36@gutov.dev> <861q5ku956.fsf@gnu.org> <86wmncss4i.fsf@gnu.org> <0ebb5a51-8634-4f65-a384-79f82592e339@gutov.dev> <87h6egecqn.fsf@gmx.de> <727a50c7-0e50-429e-9f9a-78b5b29ff405@gutov.dev> <875xuwea52.fsf@gmx.de> <87jzjbr8ek.fsf@gmx.de> <9685d486-46fe-4947-8bb2-fb436f09048b@gutov.dev> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22431"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 71049@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 31 09:28:00 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sCwgC-0005fi-IH for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 31 May 2024 09:28:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCwg7-00031b-6N; Fri, 31 May 2024 03:27:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCwg3-0002y6-Qj for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 03:27:51 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sCwg3-0003Rq-Ct for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 03:27:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sCwgE-0000Xj-97 for bug-gnu-emacs@gnu.org; Fri, 31 May 2024 03:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 May 2024 07:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71049 X-GNU-PR-Package: emacs Original-Received: via spool by 71049-submit@debbugs.gnu.org id=B71049.17171404812080 (code B ref 71049); Fri, 31 May 2024 07:28:02 +0000 Original-Received: (at 71049) by debbugs.gnu.org; 31 May 2024 07:28:01 +0000 Original-Received: from localhost ([127.0.0.1]:53080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCwgC-0000XT-IE for submit@debbugs.gnu.org; Fri, 31 May 2024 03:28:00 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:36859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sCwg9-0000X2-Ac for 71049@debbugs.gnu.org; Fri, 31 May 2024 03:27:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1717140457; x=1717745257; i=michael.albinus@gmx.de; bh=jPn3OdyQ8ITnExUE5PrltXiaFgn/YYRxx0VBR4CZO9E=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=fcI63DUcn4YUvEO6196ialBbo8KMiAVC/4VBCl1atos+lcygpTsMJKQXtSOnbv6U tdRDBB/2gffM72qtUNNCiGeOcdVlHHygL3XWhAQLZq+IVd0saxbfLoVR01fyXcXaS jK7x2AGgnMGsC8avCqA/5Mwy65O31R45eKytJGM5jcTaeSWkk48pNz/lM//WI3FGc c2EH4/YEeFHs/q9Yl24ZBBrCtHguZBYt/rIfHcwQFhjPrUTZUOkhyP2MVXpyf8g1Y r/FuSnbDyXj0hZFXrKImF0oRYmGMp3t/KmJZc28TycAvxuDqfVMaxVGNxo1hvhCrC whj5ZikFcp/9P2jAuw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.151]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MDQiS-1sNMWl1GrO-00AVuh; Fri, 31 May 2024 09:27:37 +0200 In-Reply-To: <9685d486-46fe-4947-8bb2-fb436f09048b@gutov.dev> (Dmitry Gutov's message of "Fri, 31 May 2024 03:24:49 +0300") X-Provags-ID: V03:K1:qvWp1ShxpIePu3j0VpjuGx6u2FvkVtFo4rSlzfMPD5tkvHwvcd3 5Sg0Ir63ecdKgZmGeNWPsqbpZeWv2uP3PPqwD/vVjZcr+TrvhssJ63NK2XTojZGcKl7fzoc iizt1RYJBqzCXChd8ZBCNDmRDcb7Q79jhNzjvaMG6ZLaGxTOXci6zCK+OOYLpwb5smRG4dy CebvHfzEeBa8xDnZ9nTPw== UI-OutboundReport: notjunk:1;M01:P0:MrzPsFoCiZg=;uDjNCFE7t3LQ+3AdaE+m6j+7HRI ls0jrYGCDuptabauOgz4pkigLMqS8MKVs8qB7sXoNxUzqDFlRZt+JmWIzo1vNhwXqsmvSnNxW 8OrOsD0HMYz3heZlv9x1k4W4z9RjC/9KIR9K/prDKfVJ0PahfK4wI+5Qp2sokAfxpO0ZbKQBh WwcGAzmPrYw2wKlT5GDgvMOau2l2mQ/b/nx/yjrVybePZPd1G5Y7rplE1j//vyWWoLJjYePbJ 0Hz1xFawhtfQpO4uk9EnI15qVTbQw3Vo9q03mfakkf0yjB1r3sDFDObzAmDSmIMBoDUlcsZN8 N+WGIttpmD4CKiEu9gkbivA51J1fiF20kZyjCTPKXBveVqB6OwyCGE+bVPGVp2pUdLDFBm6hC /f7jn/enh+vS6hZUyefhISt9/Fk78UQGPX9s1dWTDpznb8FbHzy+DRlH7ovm8DGOzAcohmKfV L7e4HSCpZqiegywHrgaeTRvxzSJzcGC8ATKPGrr1q5useZ/46dpg0B4QoLeAm8WGhUzLvOzfp k9bbpqGMsbhuTLXw3IIVvqxoxWPdhMK7RBAAUHQTiV71z6paKAvA9FKCtXH9a0n69k37u6lXP jRf6T/SRFFIuwCiqinohBIrGmOul19Fd1bLVKd2Mx/jUF+/GqPK0jxt5i4GTlQMlvAE2MFEDQ UWozj20YysAoCRjwwxTfacY1O8qsfC+57zD7v+EDWiefqWnWc4RoxjdHS5OEuOjqlSQZ89p3c Y4OJN8TuiSgjwea4f3Mm1ANnUSHMqKSB2D/Yv0vfxLTU0H0VAjuIJ66dG/rrW8JjytH/Qw5y X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286263 Archived-At: Dmitry Gutov writes: > Hi Michael, Hi Dmitry, > 1) [first patch] We can add a new major mode, for 'M-&' to use instead > of the full-blown 'shell-mode' - it could be very simple: just apply > font-lock keywords and maybe set list-buffers-directory. > > Problems? I suppose someone might be using shell-mode-hook to do > something in the async-shell-command output buffer, and it won't fire > anymore. Seemingly very minor concern. This is not only for 'M-&', but for any place asynchronous 'shell-command' is called. You miss a lot of settings 'shell-mode' applies. No idea whether people need this in async 'shell-command'. > diff --git a/lisp/net/tramp.el b/lisp/net/tramp.el > index 9385b023392..f0c64a7a90f 100644 > --- a/lisp/net/tramp.el > +++ b/lisp/net/tramp.el > @@ -5247,8 +5247,8 @@ tramp-handle-shell-command > ;; Display output. > (with-current-buffer output-buffer > (setq mode-line-process '(":%s")) > - (unless (eq major-mode 'shell-mode) > - (shell-mode)) > + (unless (eq major-mode 'shell-command-mode) > + (shell-command-mode)) > (set-process-filter p #'comint-output-filter) > (set-process-sentinel p #'shell-command-sentinel) > (when error-file You want to make this backward compatible, down to Emacs 27. > diff --git a/lisp/shell.el b/lisp/shell.el > index e6b315ee5c0..7fa84a37e83 100644 > --- a/lisp/shell.el > +++ b/lisp/shell.el > @@ -838,6 +838,13 @@ shell-write-history-on-exit > (with-current-buffer buf > (insert (format "\nProcess %s %s\n" process event)))))) > > +(define-derived-mode shell-command-mode comint-mode "Shell" > + "Major mode for the output of `async-shell-command'." "... of asynchronous `shell-command'." Best regards, Michael.