From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#71374: [PATCH] Simplify 'help-enable-variable-value-editing' using Date: Thu, 06 Jun 2024 06:22:53 +0000 Message-ID: <8734pqbneq.fsf@posteo.net> References: <87ikync1zh.fsf@posteo.net> <86frtrk2ec.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2384"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 71374@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 06 08:24:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sF6Xk-0000LW-2X for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Jun 2024 08:24:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sF6XO-0000i3-SJ; Thu, 06 Jun 2024 02:23:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sF6XM-0000g5-RQ for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 02:23:48 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sF6XM-00015n-Bn for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 02:23:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sF6Xa-00013O-3u for bug-gnu-emacs@gnu.org; Thu, 06 Jun 2024 02:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Jun 2024 06:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71374 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71374-submit@debbugs.gnu.org id=B71374.17176549983958 (code B ref 71374); Thu, 06 Jun 2024 06:24:02 +0000 Original-Received: (at 71374) by debbugs.gnu.org; 6 Jun 2024 06:23:18 +0000 Original-Received: from localhost ([127.0.0.1]:41674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF6Wr-00011l-VU for submit@debbugs.gnu.org; Thu, 06 Jun 2024 02:23:18 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:60191) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sF6Wp-00011D-FV for 71374@debbugs.gnu.org; Thu, 06 Jun 2024 02:23:16 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 9A628240027 for <71374@debbugs.gnu.org>; Thu, 6 Jun 2024 08:22:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1717654974; bh=7DTtVQVYQbv3KLk4NRiNW73WXRwCdEqki61lGBPa+sw=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=UXb0+MDsOzCOj7aFcFQUtc2KRT96uDsJnvA3mVuCqzpQE/x43SmXIu4MHcpvQMep5 YQdJtvp36PStxTj/Sfl22XsU5lRkjv0OLsHLssYq+fd3/JCN3G0Wen+TQA/TkMjS68 853ooSbafeAcolUwGNSHnDug2wvrbJ0+1NGAmWFAjR2asPKehetyYlwHh2qsLkTBQ1 SSsB8fzMCdYKcKAp9I6jOyGaGKipayPY0Gb8gHYuf6YufpnS0T/oKURMtyTq9ugVvn DX/uKLD3R/K1ja8zk78WETfaSxnsoPauS6Us1pNYivsKiRSTjQ7SR4i3+qadXPjJ/0 veDVenXb7AdvQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VvvQQ0DYyz9rxM; Thu, 6 Jun 2024 08:22:54 +0200 (CEST) In-Reply-To: <86frtrk2ec.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Jun 2024 15:19:39 +0300") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286658 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Date: Wed, 05 Jun 2024 06:55:46 +0000 >> >> The main issue with this patch is that it drops the syntax highlighting >> in the *string edit* buffer, but we could fix that in a second patch by >> adding support to specify a major mode to inherit from when editing a >> string. > > Thanks. This is basically a cleanup, yes? IOW, there's nothing wrong > with the current implementation, right? If so, I'd prefer to wait > with this until after the emacs-30 branch is cut. Right, it just seemed like the kind of thing where it would be natural to demonstrate string-edit. -- Philip Kaludercic on peregrine