unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Brennan Vincent" <brennan@umanwizard.com>
To: "João Távora" <joaotavora@gmail.com>,
	"Eli Zaretskii" <eliz@gnu.org>, "Dmitry Gutov" <dgutov@yandex.ru>
Cc: 73279@debbugs.gnu.org
Subject: bug#73279: [PATCH] Eglot: use immediate-mode eglot--request for :completionItem/resolve
Date: Mon, 16 Sep 2024 11:17:05 -0400	[thread overview]
Message-ID: <8734lz7hn2.fsf@taipei.mail-host-address-is-not-set> (raw)
In-Reply-To: <CALDnm52iNCPyKbPUDs5bPLtnwgaYTvEwKwDtKFANmy1mTrc4BA@mail.gmail.com>

Hi João,

Just in case you're not familiar with Rust, here are the detailed repro
instructions:

1. Install rust, cargo, and rust-analyzer: https://rustup.rs
2. Create a new project: cargo new my-project
3. Paste the repro recipe from my patch commit message into
my-project/src/main.rs

As for the regression: yes, it's a regression from 29.4, and in fact I
have bisected to the commit that regressed it:
a8c1559a663d9bc21776e33303251e244f86f0d7

So this is broken for me in both 30 and 31.

João Távora <joaotavora@gmail.com> writes:

> On Mon, Sep 16, 2024 at 12:28 PM Eli Zaretskii <eliz@gnu.org> wrote:
>>
>> > From: Brennan Vincent <brennan@umanwizard.com>
>> > Date: Sun, 15 Sep 2024 15:22:05 -0400
>
>> João, any comments?
>
> Yes, I have yet to try the reproduction recipe of this alleged problem
> but one thing stands out.  Brennan, you wrote "as  it did in Emacs 29.4".
> So this is a recent regression of sorts, is that what you're saying?  I don't
> think that code has changed much over the past years.
>
> I also don't recognize the timing you're describing, but I'll comment
> on that after I've done my investigation.  Usually there's a low
> chance a patch will easily go through in this very sensitive area
> of the code.   But a low change is nonetheless non-0 :-)  Maybe
> Dmitry can also have a look, as he's been tinkering with Eglot
> completion lately.
>
> João Távora






  reply	other threads:[~2024-09-16 15:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-15 19:22 bug#73279: [PATCH] Eglot: use immediate-mode eglot--request for :completionItem/resolve Brennan Vincent
2024-09-16 11:28 ` Eli Zaretskii
2024-09-16 13:43   ` João Távora
2024-09-16 15:17     ` Brennan Vincent [this message]
2024-09-16 15:40       ` João Távora
2024-09-16 15:50         ` João Távora
2024-09-16 16:21           ` João Távora
2024-09-16 17:06             ` Brennan Vincent
2024-09-25 15:14               ` Brennan Vincent
2024-09-26 10:27                 ` João Távora
2024-09-26 10:58                   ` Eli Zaretskii
2024-10-06 12:13                     ` Brennan Vincent
2024-10-09 11:50                       ` João Távora
2024-10-09 12:12                         ` Brennan Vincent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8734lz7hn2.fsf@taipei.mail-host-address-is-not-set \
    --to=brennan@umanwizard.com \
    --cc=73279@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=eliz@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).