From: martin rudalics <rudalics@gmx.at>
To: Alan Mackenzie <acm@muc.de>
Cc: 47207@debbugs.gnu.org
Subject: bug#47207: 28.0.50; decode_next_window_args crash
Date: Thu, 15 Apr 2021 16:45:20 +0200 [thread overview]
Message-ID: <872ab30c-3492-b523-eb4a-2f33a6c5da56@gmx.at> (raw)
In-Reply-To: <YHg6k94MDcoXB5z8@ACM>
> That's quite an involved thread. I've read through it, but can't
> remember seeing a firm decision on how to fix the problem, or even if it
> was fixed then.
It wasn't fixed then.
> The current problem in minibuf.c seems to be that we assume
> f->minibuffer_window to be non-nil in several (~6) places, rather than
> checking it.
We assume that it is a live window.
> In most of these places, if we detect NILP (f->m_w), we can simply skip
> the action we were intending to take. This is certainly the case in the
> bit that gave you the trouble in read_minibuf_unwind, where we're
> stepping through all frames looking for the expired minibuffer.
The most secure way is to skip the action whenever f->minibuffer_window
fails the WINDOW_LIVE_P check.
> It might well be that we never call do_switch_frame to a tool-tip frame,
> for example. Do you know if this is the case? This could save some
> checking code.
I wrote some code that avoids that a tooltip window ever gets selected
and do_switch_frame returns silently when asked to switch to a tooltip
frame. But I wouldn't rely on that - the display engine might still try
to select a tooltip window for some reason.
> So, where do we go from here? I'm quite willing to make these changes
> to minibuf.c. Would that be OK with everybody else?
It would be OK with me (and should fix Bug#47774 too). And please look
into Bug#47781 next.
martin
next prev parent reply other threads:[~2021-04-15 14:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 8:45 bug#47207: 28.0.50; decode_next_window_args crash martin rudalics
2021-03-17 13:29 ` Eli Zaretskii
2021-03-17 15:36 ` martin rudalics
2021-03-17 15:48 ` Eli Zaretskii
2021-03-17 17:06 ` martin rudalics
2021-03-17 17:47 ` Eli Zaretskii
2021-03-17 18:01 ` martin rudalics
2021-03-17 18:15 ` Eli Zaretskii
2021-03-18 8:43 ` martin rudalics
2021-03-18 9:38 ` Eli Zaretskii
2021-03-18 15:51 ` martin rudalics
2021-03-18 16:49 ` Eli Zaretskii
2021-04-13 15:54 ` martin rudalics
2021-04-13 17:06 ` Alan Mackenzie
2021-04-13 17:12 ` martin rudalics
2021-04-15 13:07 ` Alan Mackenzie
2021-04-15 14:45 ` martin rudalics [this message]
2021-04-16 0:15 ` Gregory Heytings
2021-04-16 11:28 ` Alan Mackenzie
2021-04-16 14:42 ` martin rudalics
2021-04-18 8:01 ` martin rudalics
2021-04-13 17:37 ` Gregory Heytings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=872ab30c-3492-b523-eb4a-2f33a6c5da56@gmx.at \
--to=rudalics@gmx.at \
--cc=47207@debbugs.gnu.org \
--cc=acm@muc.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).