unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: 7307@debbugs.gnu.org
Subject: bug#7307: 24.0.50; Mode line had more than just dashes removed
Date: Sat, 30 Oct 2010 01:05:32 +0200	[thread overview]
Message-ID: <871v78mwg3.fsf@escher.home> (raw)

This change:

2010-10-18  Julien Danjou  <julien@danjou.info>

	* bindings.el: Remove end dashes in default mode-line-format.

not only removed the dashes at the end of the mode line, but also the
help string in a tool tip together with the altered mouse pointer, which
serves as a visual cue that the mode line is draggable (with vertically
split windows).  I think these help indicators should be restored.
Unfortunately, there is no mode line construct that inserts spaces to
the end of the window like "%-" inserts dashed.  So I tried make-string
and it seems to DTRT.  The only problem is specifying the length of the
string: (window-width) as the maximum possible length fails here,
because the mode line is constructed before the window-system frame, and
has a value of just 10.  So I just picked 200 as a plausible maximum.
Maybe there's a better way, but this seems to work ok.

*** /home/steve/bzr/emacs/trunk/lisp/bindings.el	2010-10-24 13:56:16.000000000 +0200
--- /home/steve/bzr/emacs/quickfixes/lisp/bindings.el	2010-10-30 00:39:06.000000000 +0200
***************
*** 336,342 ****
  	 'mode-line-modes
  	 `(which-func-mode ("" which-func-format ,spaces))
  	 `(global-mode-string ("" global-mode-string ,spaces))
! 	 `(:eval (unless (display-graphic-p)
  		   ,(propertize "-%-" 'help-echo help-echo)))))
         (standard-mode-line-modes
  	(list
--- 336,343 ----
  	 'mode-line-modes
  	 `(which-func-mode ("" which-func-format ,spaces))
  	 `(global-mode-string ("" global-mode-string ,spaces))
! 	 `(:eval (if (display-graphic-p)
! 		     ,(propertize (make-string 200 32) 'help-echo help-echo)
  		   ,(propertize "-%-" 'help-echo help-echo)))))
         (standard-mode-line-modes
  	(list






             reply	other threads:[~2010-10-29 23:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-29 23:05 Stephen Berman [this message]
2010-10-30  6:51 ` bug#7307: 24.0.50; Mode line had more than just dashes removed Eli Zaretskii
2010-10-30 13:27   ` Stephen Berman
2010-10-30 13:49     ` Eli Zaretskii
2010-10-30 15:23       ` Stephen Berman
2010-10-31  3:54     ` Stefan Monnier
2010-11-01 18:11       ` Stephen Berman
2010-11-01 19:32         ` Eli Zaretskii
2010-11-01 23:35           ` Stephen Berman
2010-11-02  5:35             ` Eli Zaretskii
2010-11-02  6:31               ` Eli Zaretskii
2010-11-02 14:32         ` Stefan Monnier
2010-11-05 16:18           ` Stephen Berman
2010-11-05 18:45             ` Andreas Schwab
2010-11-05 23:08               ` Stephen Berman
2010-11-08 18:28             ` Stefan Monnier
2010-11-21  0:37               ` Stephen Berman
2010-10-31  0:49 ` James Cloos
2010-11-01 18:11   ` Stephen Berman
2012-06-03  9:05 ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871v78mwg3.fsf@escher.home \
    --to=stephen.berman@gmx.net \
    --cc=7307@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).