From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#10489: 24.0.92; dired-do-copy may create infinite directory hierarchy Date: Mon, 27 Feb 2012 12:34:40 +0100 Message-ID: <871upgo6gf.fsf@gmail.com> References: <87mx9su32g.fsf@web.de> <834nugtwqf.fsf@gnu.org> <87r4xkwhky.fsf@gmail.com> <83vcmws3bs.fsf@gnu.org> <87ehtkwaiz.fsf@gmail.com> <87wr7cgsm3.fsf@gmx.de> <8762eww77b.fsf@gmail.com> <83pqd4roav.fsf@gnu.org> <87haygx97t.fsf@gmx.de> <87aa47rj6z.fsf@gmail.com> <878vjrxpej.fsf@gmx.de> <87pqd3i8ky.fsf@gmail.com> <87ipiuvsbw.fsf@gmx.de> <87k439gyu5.fsf@gmail.com> <87fwdwhizm.fsf@gmail.com> <87bookhfcn.fsf@gmail.com> <87aa44o7qo.fsf@gmail.com> <87linopm4e.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1330342526 20711 80.91.229.3 (27 Feb 2012 11:35:26 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Feb 2012 11:35:26 +0000 (UTC) Cc: 10489@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 27 12:35:25 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S1yrU-000354-FA for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Feb 2012 12:35:24 +0100 Original-Received: from localhost ([::1]:35026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1yrT-0003nM-Fl for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Feb 2012 06:35:23 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:45358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1yrQ-0003mo-O7 for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2012 06:35:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S1yrH-0001Mx-UE for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2012 06:35:20 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S1yrH-0001Mt-Ps for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2012 06:35:11 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S1yu1-0001UE-PY for bug-gnu-emacs@gnu.org; Mon, 27 Feb 2012 06:38:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Feb 2012 11:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10489 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10489-submit@debbugs.gnu.org id=B10489.13303426575683 (code B ref 10489); Mon, 27 Feb 2012 11:38:01 +0000 Original-Received: (at 10489) by debbugs.gnu.org; 27 Feb 2012 11:37:37 +0000 Original-Received: from localhost ([127.0.0.1]:59129 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1ytd-0001TZ-Ct for submit@debbugs.gnu.org; Mon, 27 Feb 2012 06:37:37 -0500 Original-Received: from mail-ww0-f46.google.com ([74.125.82.46]:59433) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S1yta-0001TS-T6 for 10489@debbugs.gnu.org; Mon, 27 Feb 2012 06:37:36 -0500 Original-Received: by wgbdq11 with SMTP id dq11so709420wgb.15 for <10489@debbugs.gnu.org>; Mon, 27 Feb 2012 03:34:43 -0800 (PST) Received-SPF: pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.180.92.73 as permitted sender) client-ip=10.180.92.73; Authentication-Results: mr.google.com; spf=pass (google.com: domain of thierry.volpiatto@gmail.com designates 10.180.92.73 as permitted sender) smtp.mail=thierry.volpiatto@gmail.com; dkim=pass header.i=thierry.volpiatto@gmail.com Original-Received: from mr.google.com ([10.180.92.73]) by 10.180.92.73 with SMTP id ck9mr27183918wib.2.1330342483741 (num_hops = 1); Mon, 27 Feb 2012 03:34:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=jQRzS/2+9KPwre15CmuAYJD3DveSWnX9Wa8uirt4rpU=; b=iUnbkM+hka2Jg1ZMiEqfADVW6Sq9qbF0B7XTWMErfWrtFgT3LO5CXih2k/tgxCTpzD H+bfzwoKY5nX3L8OP8Leq4d11HCrj56Kx7K3sGZ3BFjmQWEBhMVmDUa3YZD2O+gwIdye NNXI8joIluCCI+liLItF6rvKyLByER0EOH7Ng= Original-Received: by 10.180.92.73 with SMTP id ck9mr21570261wib.2.1330342483703; Mon, 27 Feb 2012 03:34:43 -0800 (PST) Original-Received: from thierry-MM061 (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id p10sm21706633wic.0.2012.02.27.03.34.41 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 27 Feb 2012 03:34:42 -0800 (PST) In-Reply-To: <87linopm4e.fsf@gmx.de> (Michael Albinus's message of "Mon, 27 Feb 2012 12:10:57 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57293 Archived-At: Michael Albinus writes: > Thierry Volpiatto writes: > >>> I see why we might want to signal an error to the user when she does >>> (copy-directory "~/test" "~/test/test1"), but I don't see why that >>> implies that we need files-equal-p to handle non-existent files. >> Because if we don't do that, we have to create new directory Test1 and >> then test if Test1 is a subdir of Test. >> This just to avoid that. > > This has to be handled in copy-directory. It is actually handled in copy-directory. > files-equal-p can (will!) be used also somewhere else. It's why I propose a new optional arg for it. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997