From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#12396: 24.2.50; [PATCH] extend usability of gnus-read-ephemeral-emacs-bug-group Date: Tue, 11 Sep 2012 22:01:34 +0300 Organization: JURTA Message-ID: <871ui8a0v1.fsf@mail.jurta.org> References: <87d31vtccn.fsf@rosalinde.fritz.box> <87txv7yqwa.fsf@gnus.org> <878vcjt1se.fsf@rosalinde.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1347390639 28168 80.91.229.3 (11 Sep 2012 19:10:39 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 11 Sep 2012 19:10:39 +0000 (UTC) Cc: Lars Ingebrigtsen , 12396@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Sep 11 21:10:42 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TBVr3-00035n-Q7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2012 21:10:37 +0200 Original-Received: from localhost ([::1]:35496 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBVr0-0008Ks-5W for geb-bug-gnu-emacs@m.gmane.org; Tue, 11 Sep 2012 15:10:34 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:47669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBVqs-0008Ey-JU for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 15:10:32 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TBVqn-0003Kc-59 for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 15:10:26 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45594) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TBVqn-0003KV-1b for bug-gnu-emacs@gnu.org; Tue, 11 Sep 2012 15:10:21 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TBVrR-0007ZI-Ui; Tue, 11 Sep 2012 15:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Tue, 11 Sep 2012 19:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12396 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 12396-submit@debbugs.gnu.org id=B12396.134739062329038 (code B ref 12396); Tue, 11 Sep 2012 19:11:01 +0000 Original-Received: (at 12396) by debbugs.gnu.org; 11 Sep 2012 19:10:23 +0000 Original-Received: from localhost ([127.0.0.1]:55137 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBVqo-0007YI-1u for submit@debbugs.gnu.org; Tue, 11 Sep 2012 15:10:22 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:58319 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TBVql-0007Y8-4q for 12396@debbugs.gnu.org; Tue, 11 Sep 2012 15:10:20 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 09BEC451CC73; Tue, 11 Sep 2012 12:09:34 -0700 (PDT) In-Reply-To: <878vcjt1se.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Sun, 09 Sep 2012 21:49:05 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:64159 Archived-At: >> It makes sense, but it's kinda not the way these function in Emacs >> usually work. `M-x find-file-at-point', `M-x man', etc, all react to >> the thing under point. And that's a very self-evident user interface. >> Put point at the thing you're interested in, and then issue a command. > > I was annoyed enough times by having to navigate to the bug number to > avoid typing it in that I decided to code up a way to avoid having to do > that; having it in Emacs might spare others such annoyance. :-) I agree with Lars that getting a default value from distant parts of the buffer is non-standard behavior for thing-at-point. It might cause more annoyance when it will do not what the user expects. For instance, if it will get a bug number far away from point, then the user might expect that it will also get a bug number on the next line at the same column position, etc. IOW, I don't oppose such a change only if its logic would be simple and intuitive to users. Also moving argument reading out of the `interactive' specification in `gnus-read-ephemeral-emacs-bug-group' is a change for the worse. However, I think that the second part of your proposal is very useful. Do you think `bug-reference-push-button-action' can be a function? So users could set it to `browse-url' or `gnus-read-ephemeral-emacs-bug-group' (these values still need const tags like in your patch) or any other function. Also I wonder why you don't call `gnus-read-ephemeral-emacs-bug-group' with a bug number argument so users don't need to confirm it with RET. BTW, bug-reference.el could be improved to support also links to revision numbers like "revno:109985" that opens an URL like http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/109985