* bug#12740: 24.2.50; ERC fix broke modules after require
@ 2012-10-26 14:58 Antoine Levitt
2012-10-26 15:21 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Antoine Levitt @ 2012-10-26 14:58 UTC (permalink / raw)
To: 12740, monnier
Hi,
The following code stopped working (ie truncate stopped being activated)
after a series of commits by Stefan Monnier
emacs -Q
(require 'erc)
(setq erc-modules '(truncate))
(erc-update-modules)
(erc :server "irc.freenode.net")
This worked fine before
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Mon Oct 15 12:49:57 2012 -0400
* lisp/erc/erc.el (erc-log): Make it into a defsubst.
(erc-with-server-buffer, define-erc-module, erc-with-buffer)
(erc-with-all-buffers-of-server): Use `declare'.
* lisp/erc/erc-backend.el (erc-log): Adjust autoload accordingly.
After this, erc was broken until
Author: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Thu Oct 18 11:51:28 2012 -0400
* lisp/erc/erc-backend.el: Require `erc' instead of autoloading its macros.
And after this commit, the sample code above stopped working.
Antoine
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#12740: 24.2.50; ERC fix broke modules after require
2012-10-26 14:58 bug#12740: 24.2.50; ERC fix broke modules after require Antoine Levitt
@ 2012-10-26 15:21 ` Stefan Monnier
2012-10-26 15:52 ` Antoine Levitt
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2012-10-26 15:21 UTC (permalink / raw)
To: Antoine Levitt; +Cc: 12740
> emacs -Q
> (require 'erc)
> (setq erc-modules '(truncate))
> (erc-update-modules)
> (erc :server "irc.freenode.net")
> This worked fine before
I don't know what "worked" means precisely, but I tried your above
recipe and "it worked" in the sense that it did something which didn't
look like an error.
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#12740: 24.2.50; ERC fix broke modules after require
2012-10-26 15:21 ` Stefan Monnier
@ 2012-10-26 15:52 ` Antoine Levitt
2012-10-26 18:30 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Antoine Levitt @ 2012-10-26 15:52 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 12740
[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]
10/26/2012 17:21, Stefan Monnier
>> emacs -Q
>> (require 'erc)
>> (setq erc-modules '(truncate))
>> (erc-update-modules)
>> (erc :server "irc.freenode.net")
>> This worked fine before
>
> I don't know what "worked" means precisely, but I tried your above
> recipe and "it worked" in the sense that it did something which didn't
> look like an error.
Sorry if this bug report is confused. I've tried to reduce the original
bug (which has weird effects on my configuration) to a simple test
case. The bug, which I had not described and you could not guess, was
that lines were filled. My bad. Please discard my original bug report
and consider the following:
(require 'erc)
(setq erc-modules '())
(erc-update-modules)
used to disable buffer filling (try it on a large window). It did so
before your commits, not after.
You might argue that this is the intended behaviour, because
erc-update-modules says that it only enables modules, not disable them
(in which case, to disable modules, is one supposed to set erc-modules
before requiring erc ? I liked the old way better).
I also attach a more involved example of a bug that appeared with your
commits, and has nothing to do with erc-modules (I think). I was hoping
the fix for the simpler issue would also fix the more involved one,
which is why I didn't report it in the first place, but here it is
anywyay. The code is supposed to colour the nicks of people (here, all
in yellow). The bug results from an interaction with
erc-hide-timestamps, which didn't occur before your commits.
Sorry again.
[-- Attachment #2: test.el --]
[-- Type: application/emacs-lisp, Size: 2772 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#12740: 24.2.50; ERC fix broke modules after require
2012-10-26 15:52 ` Antoine Levitt
@ 2012-10-26 18:30 ` Stefan Monnier
2012-10-26 18:47 ` Antoine Levitt
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2012-10-26 18:30 UTC (permalink / raw)
To: Antoine Levitt; +Cc: 12740
A shot in the dark: does the patch below fix your problems?
Stefan
=== modified file 'lisp/erc/erc-backend.el'
--- lisp/erc/erc-backend.el 2012-10-18 15:51:28 +0000
+++ lisp/erc/erc-backend.el 2012-10-26 18:28:14 +0000
@@ -102,8 +102,7 @@
;; There's a fairly strong mutual dependency between erc.el and erc-backend.el.
;; Luckily, erc.el does not need erc-backend.el for macroexpansion whereas the
;; reverse is true:
-(provide 'erc-backend)
-(require 'erc)
+(eval-when-compile (provide 'erc-backend) (require 'erc))
;;;; Variables and options
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#12740: 24.2.50; ERC fix broke modules after require
2012-10-26 18:30 ` Stefan Monnier
@ 2012-10-26 18:47 ` Antoine Levitt
2012-10-28 15:35 ` Stefan Monnier
0 siblings, 1 reply; 7+ messages in thread
From: Antoine Levitt @ 2012-10-26 18:47 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 12740
10/26/2012 20:30, Stefan Monnier
> A shot in the dark: does the patch below fix your problems?
It does.
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#12740: 24.2.50; ERC fix broke modules after require
2012-10-26 18:47 ` Antoine Levitt
@ 2012-10-28 15:35 ` Stefan Monnier
2012-10-28 15:41 ` Antoine Levitt
0 siblings, 1 reply; 7+ messages in thread
From: Stefan Monnier @ 2012-10-28 15:35 UTC (permalink / raw)
To: Antoine Levitt; +Cc: 12740
>> A shot in the dark: does the patch below fix your problems?
> It does.
Thanks, installed,
Stefan
^ permalink raw reply [flat|nested] 7+ messages in thread
* bug#12740: 24.2.50; ERC fix broke modules after require
2012-10-28 15:35 ` Stefan Monnier
@ 2012-10-28 15:41 ` Antoine Levitt
0 siblings, 0 replies; 7+ messages in thread
From: Antoine Levitt @ 2012-10-28 15:41 UTC (permalink / raw)
To: Stefan Monnier; +Cc: 12740
[-- Attachment #1: Type: text/plain, Size: 215 bytes --]
Nice, thanks!
On Oct 28, 2012 4:35 PM, "Stefan Monnier" <monnier@iro.umontreal.ca> wrote:
> >> A shot in the dark: does the patch below fix your problems?
> > It does.
>
> Thanks, installed,
>
>
> Stefan
>
[-- Attachment #2: Type: text/html, Size: 487 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2012-10-28 15:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-26 14:58 bug#12740: 24.2.50; ERC fix broke modules after require Antoine Levitt
2012-10-26 15:21 ` Stefan Monnier
2012-10-26 15:52 ` Antoine Levitt
2012-10-26 18:30 ` Stefan Monnier
2012-10-26 18:47 ` Antoine Levitt
2012-10-28 15:35 ` Stefan Monnier
2012-10-28 15:41 ` Antoine Levitt
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).