unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Bastien <bzg@altern.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: ivan.kalyaev@gmail.com, 16403@debbugs.gnu.org
Subject: bug#16403: 24.3.50; Rectangular selection visually disturbing
Date: Fri, 10 Jan 2014 21:20:14 +0100	[thread overview]
Message-ID: <871u0feght.fsf@bzg.ath.cx> (raw)
In-Reply-To: <83eh4fbnil.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 Jan 2014 22:16:50 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Bastien <bzg@altern.org>
>> Date: Fri, 10 Jan 2014 20:58:33 +0100
>> Cc: Ivan Kalyaev <ivan.kalyaev@gmail.com>, 16403@debbugs.gnu.org
>> 
>> -              (when (= leftcol rightcol)
>> +              (when (and (= leftcol rightcol) (window-system))
>
> Please don't use window-system as a predicate.  Use display-graphic-p
> instead (in this case; there are other display-*-p predicates that
> target other situations).

Thanks for the advice.

I'll will wait for other maintainers to give feedback and apply
this on monday if it's good.

-- 
 Bastien





  reply	other threads:[~2014-01-10 20:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-09 10:15 bug#16403: 24.3.50; Rectangular selection visually disturbing Ivan Kalyaev
2014-01-09 21:10 ` Daniel Colascione
2014-01-10 11:28   ` Ivan Kalyaev
2014-01-10 19:58   ` Bastien
2014-01-10 20:16     ` Eli Zaretskii
2014-01-10 20:20       ` Bastien [this message]
2014-01-10 23:57         ` Stefan Monnier
2014-01-11 10:02           ` Bastien
2014-01-12 20:03             ` Stefan Monnier
2014-01-12 22:26               ` Bastien
2014-01-13  4:00                 ` Stefan Monnier
2014-01-13 10:57                 ` Bastien
2016-08-09  1:45                   ` npostavs
2016-09-02  3:09                     ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871u0feght.fsf@bzg.ath.cx \
    --to=bzg@altern.org \
    --cc=16403@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=ivan.kalyaev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).