From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#18357: 24.3.93; Calendar not fully displayed Date: Sat, 30 Aug 2014 21:35:19 +0200 Message-ID: <871trxrcso.fsf@rosalinde.fritz.box> References: <874mwv40ja.fsf@rosalinde.fritz.box> <83vbpaguyl.fsf@gnu.org> <87a96mqkl3.fsf@rosalinde.fritz.box> <5401C6E7.9070000@gmx.at> <5401C837.9090704@gmx.at> <83sikegla7.fsf@gnu.org> <5401D6F6.6010109@gmx.at> <83r3zygjbd.fsf@gnu.org> <5401FE87.8090207@gmx.at> <83k35qgc2d.fsf@gnu.org> <540206CA.40204@gmx.at> <83iol9hnhq.fsf@gnu.org> <54021337.9020800@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1409427384 8817 80.91.229.3 (30 Aug 2014 19:36:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Aug 2014 19:36:24 +0000 (UTC) Cc: 18357@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 30 21:36:17 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XNoRc-0007ve-Uj for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 21:36:17 +0200 Original-Received: from localhost ([::1]:47553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNoRc-000102-Hq for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Aug 2014 15:36:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNoRU-0000zf-6D for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 15:36:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XNoRO-0005jo-6T for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 15:36:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XNoRO-0005jk-2Z for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 15:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XNoRN-000380-MV for bug-gnu-emacs@gnu.org; Sat, 30 Aug 2014 15:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Aug 2014 19:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18357-submit@debbugs.gnu.org id=B18357.140942733311986 (code B ref 18357); Sat, 30 Aug 2014 19:36:01 +0000 Original-Received: (at 18357) by debbugs.gnu.org; 30 Aug 2014 19:35:33 +0000 Original-Received: from localhost ([127.0.0.1]:54625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNoQu-00037F-Ij for submit@debbugs.gnu.org; Sat, 30 Aug 2014 15:35:32 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:64279) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XNoQq-000370-HX for 18357@debbugs.gnu.org; Sat, 30 Aug 2014 15:35:29 -0400 Original-Received: from rosalinde.fritz.box ([89.245.122.11]) by mail.gmx.com (mrgmx003) with ESMTPSA (Nemesis) id 0MexaL-1XmNYP1hqT-00OW4g; Sat, 30 Aug 2014 21:35:20 +0200 In-Reply-To: <54021337.9020800@gmx.at> (martin rudalics's message of "Sat, 30 Aug 2014 20:08:55 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.93 (gnu/linux) X-Provags-ID: V03:K0:AcEyuSDRbVbdbcOpzN0/KVkFSbZdO9kZu3EuUCggpHfSJ8hrs2y GyQiFUgDYENOMVTtCkmsawT+00/m+4sq25bT+cAQb3LAzHuql6400Kphwv2rTDld9+5zgqI zzXnlhFrT78gvSRxh2z5ggjM1oI1fdURm42zalfluYiAg0kTt4Ars4H27EUtDHdhPTaX7Pw f7sSRRHga7qUticFhZCJg== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92880 Archived-At: On Sat, 30 Aug 2014 20:08:55 +0200 martin rudalics wrote: >> Are you sure fit-window-to-buffer was called? My reading of >> calendar.el is that it isn't in this scenario. > > It is. Martin is correct: when calendar-generate-window is called from calendar-basic-setup, the selected window is the one containing the *Calendar* buffer (this is because calendar-basic-setup previously called `(pop-to-buffer calendar-buffer)'). >>> For Stephen's the estimate is for a non-selected window and `calendar' >>> selects the window _after_ `fit-window-to-buffer' was executed. >> >> See above: are you sure? > > Yes. Stephen please verify. If I follow you (but I'm not sure I do), I think you are mistaken here: when I step through the code, fit-window-to-buffer is called (in calendar-generate-window, as noted above) with *Calendar* buffer window already being the selected window. In any case, the estimate for the mode line height should be the same in my case as in yours, see below. >>> If you have a better explanation, I'll be all ears. >> >> I don't see what I need to explain. From my POV, what we see here is >> all normal, as I already explained in my original response to Stephen. > > The problem is that `fit-window-to-buffer' shouldn't leave a line > partially visible. At least not in the case at hand where there's > plenty of space. > >> Then you agree with me: there's no problem here, just normal reaction >> to the fact that point entered a partially visible line. > > See above. Stephen, does it fit if you make the font of a non-active > mode line just as high as that of an active one? In my recipe, both active and inactive mode lines have the same height: face mode-line-inactive inherits the overline attribute from face mode-line. One interesting observation (which I do not understand), is that when I execute the recipe and step through calendar-generate-window with Edebug, after the call to fit-window-to-buffer, the height of the Calendar window is 9, and the Calendar is fully displayed. But when I execute the recipe alone, the height is 8 and the display is partial. Steve Berman