From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20541: ERC password fetching using Secret Service API is broken Date: Mon, 01 Jun 2015 11:20:58 +0200 Message-ID: <871thvzsw5.fsf@gmx.de> References: <87d228lduj.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1433150553 20557 80.91.229.3 (1 Jun 2015 09:22:33 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 1 Jun 2015 09:22:33 +0000 (UTC) Cc: Ted Zlatanov , 20541@debbugs.gnu.org To: Krzysztof Jurewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 01 11:22:19 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YzLvH-0002VQ-IE for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Jun 2015 11:22:19 +0200 Original-Received: from localhost ([::1]:50982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzLvA-0006Cm-Mv for geb-bug-gnu-emacs@m.gmane.org; Mon, 01 Jun 2015 05:22:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46850) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzLv7-0006Cd-NU for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2015 05:22:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YzLv0-0000Ku-El for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2015 05:22:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YzLv0-0000Kq-BI for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2015 05:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YzLv0-0000Vt-0l for bug-gnu-emacs@gnu.org; Mon, 01 Jun 2015 05:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 Jun 2015 09:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20541-submit@debbugs.gnu.org id=B20541.14331504711909 (code B ref 20541); Mon, 01 Jun 2015 09:22:01 +0000 Original-Received: (at 20541) by debbugs.gnu.org; 1 Jun 2015 09:21:11 +0000 Original-Received: from localhost ([127.0.0.1]:35341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YzLu9-0000Uh-Gd for submit@debbugs.gnu.org; Mon, 01 Jun 2015 05:21:10 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:60977) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YzLu7-0000U3-6B for 20541@debbugs.gnu.org; Mon, 01 Jun 2015 05:21:08 -0400 Original-Received: from detlef.gmx.de ([79.195.2.31]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MAgvb-1Yp9Hc3Uqp-00Bujp; Mon, 01 Jun 2015 11:20:59 +0200 In-Reply-To: <87d228lduj.fsf@gmail.com> (Krzysztof Jurewicz's message of "Sun, 10 May 2015 16:13:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:bu3iEsC1WnZcxHkcrvlg+sQ9MDSSvykGjwipQ4QFPHgvIPzSIP2 GD5OBsV3/ydCkhMuGW1hHIYu7/01IQH9NiYXwaWaBKxIUYzX9hTyKj/Ya1J0pLQLNGB0dbx p/q+qolNk53q8HmyoW0eDpz5GGRkyT4S6XYanXzsFRuR4gcmcOPKPE6sBLwomBfWOFE+7/L FIBnQhaFBF5/qxBUz5h6A== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZL3eXUwish4=:oq1Gwc17lZxYPRaWUbuFsS qr7k6eJNSF2X/594yXgCA20iGhjO5Os1hiBqS2hMsUQIxjJGqR83Yr6sxAvcr7O42tdPVMkHE r5G0+W9Xh8wSqKDHLWm++0t6WlL0/3PlGuKZDviyaF5bCwcq4zEzTHjDIF/xLxposOoYhfDgU kuBiMoCiBuehWjDDiK6x1hT6uD04ksVg9d9AtkYT8bV50cblOQieWzheoL5QpQ0hVrGMUfTWA R4Lm2bizQxfcM9eg2sC56EbaKgmT4JVRgnwT2v7rXFFdBYTYF44i0H+NRSx75nwc/tYfujGSL IPz3ESEmCJwYAeB1ZEyyKlGnKYkfojra7jCkDIwA1KlhFjuEipTMZw3w2uh5GEKZ1l5LRXwpD 9wmOe9foWt4udV/nVbvp1X2GODTQh/Z7jr8MlytP9ZQxG+DyAAibE5ADOTKdm6eb21+ATEVna a1ZqLHq1RHrRHPfwkfT2CSyTz6AfVt5eCkSUSrHT9484e8pIwhUVJiYdY/9pBLbhFnV+pr3Ze aieR2w7bLiITyPRvA3/5vtJHdzw8WOTCH6pUqHiYkbiPtw2fSglQRLppa2lsw9O5PKVEwE18C 9I1BpjMp+8gx78TXDRA0EH7iysZxVcuWATBCk/F7b3JzlKGh3IsRXSh4jrP8cWZj2u6mLG6UJ p2/tY4SOhCI73bl5zt2lzFcJf3rJMovPT3/7xHNnTfNg0Lc0o81BCgpqTFtqObCpR50w= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:103420 Archived-At: Krzysztof Jurewicz writes: > One possible patch is attached below. This is the simplest solution; I > have not thought much about whether it may be more desirable to convert > numbers to strings inside the secrets.el package. Well, secrets.el expects only strings as attributes. No conversion foreseen. I don't know what auth-source.el does. If auth-source-search also allows only strings (and symbol names) as attributes, then your patch is right. Otherwise, if a :port attribute could also be an integer, it shall be transformed to a string. Ted? > From 25f798b3b86a34bd6b262c59c3733d72eec50c13 Mon Sep 17 00:00:00 2001 > From: Krzysztof Jurewicz > Date: Thu, 7 May 2015 13:01:24 +0200 > Subject: [PATCH] * lisp/erc/erc.el (erc-open): Fix password fetching > > ERC used to pass the port number as a number, however when using > Secret Service API, only strings can be used. > > Copyright-paperwork-exempt: yes > --- > lisp/erc/erc.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el > index cf422f1..a8f1478 100644 > --- a/lisp/erc/erc.el > +++ b/lisp/erc/erc.el > @@ -2010,7 +2010,8 @@ Returns the buffer for the given server or channel." > (auth-source-search :host server > :max 1 > :user nick > - :port port > + ;; secrets.el wouldn=E2= =80=99t accept a number > + :port (if (numberp port) = (number-to-string port) port) > :require '(:secret))) > :secret))) > (if (functionp secret) > -- > 2.4.0 Best regards, Michael.