From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.bugs Subject: bug#20541: ERC password fetching using Secret Service API is broken Date: Mon, 29 Jun 2015 22:28:45 -0400 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <871tguj5eq.fsf@lifelogs.com> References: <87d228lduj.fsf@gmail.com> <871thvzsw5.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1435631368 4412 80.91.229.3 (30 Jun 2015 02:29:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 30 Jun 2015 02:29:28 +0000 (UTC) Cc: Krzysztof Jurewicz , 20541@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jun 30 04:29:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z9lIN-0006CG-Bd for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Jun 2015 04:29:11 +0200 Original-Received: from localhost ([::1]:44667 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9lIM-0003be-Kb for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Jun 2015 22:29:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9lIJ-0003bJ-5A for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 22:29:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z9lIF-0006GX-Te for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 22:29:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60281) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z9lIF-0006Fh-Jf for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 22:29:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Z9lIE-0001kf-W3 for bug-gnu-emacs@gnu.org; Mon, 29 Jun 2015 22:29:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 Jun 2015 02:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20541-submit@debbugs.gnu.org id=B20541.14356313366721 (code B ref 20541); Tue, 30 Jun 2015 02:29:02 +0000 Original-Received: (at 20541) by debbugs.gnu.org; 30 Jun 2015 02:28:56 +0000 Original-Received: from localhost ([127.0.0.1]:33494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9lI7-0001kK-R6 for submit@debbugs.gnu.org; Mon, 29 Jun 2015 22:28:56 -0400 Original-Received: from mail-qg0-f45.google.com ([209.85.192.45]:34156) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Z9lI4-0001k2-SV for 20541@debbugs.gnu.org; Mon, 29 Jun 2015 22:28:53 -0400 Original-Received: by qgii30 with SMTP id i30so13143510qgi.1 for <20541@debbugs.gnu.org>; Mon, 29 Jun 2015 19:28:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=iPX987ZNZOrVY0fHHxpjSZSU0mVabZlJTTUhO5kCUmA=; b=bz2MSLZBOZdhUDz1dFZgUwgJ8PHaauQDjP4bR0eFKsJ4kxSAFpd082vgoSBhKVImzD FHXJUL6cVyq2CUWC++UtmAY2G+dunjLamNqZWwp0kvcngdg4fFBQvYhpGrHI05Xf5IAQ FrqxCo+bVoOrdocYXrcsxSui8ibX+aAl+CZDc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=iPX987ZNZOrVY0fHHxpjSZSU0mVabZlJTTUhO5kCUmA=; b=VgiQVhwl/wUFzt65/wsEADih7R7o9Ewy9Dn0NIisWe7/3SpLcCmS90mrxtY1pAKtWD dWGryRdylrqVxine4r/LzvTbuLFnLuflKHwHUOab8rOuAHakWqvP3zgBwngxQ7y6CR+y hJ0C0HkO+bSZrfUbKgF5LLwol/Ef7zsPw2QpWBUyCQuBuHZU9lWDT3+yPG9X31DMfYB6 3SAJXQUpqZuC9zbzE79qDsXXgqkBPJQWwrREnmD3V17vqAxhrNoiVHt8Rt9cHfiW8pNt btEVwYE8DMGngIo/LGUZjiwY7Ox+FF9Aq3WK0SLcHptcWMW7Gp3vt6JDJdUkwVt2Cw9B o5Tg== X-Gm-Message-State: ALoCoQmyOBNf2zmJXNiw0UrAr9OT/u3hH5PzKvj7swu3fLp6zyO20SZhuqGVCmbYjbWgroUDnbP7 X-Received: by 10.55.17.26 with SMTP id b26mr37136219qkh.93.1435631327470; Mon, 29 Jun 2015 19:28:47 -0700 (PDT) Original-Received: from flea (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id m65sm12350019qhb.27.2015.06.29.19.28.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Jun 2015 19:28:46 -0700 (PDT) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <871thvzsw5.fsf@gmx.de> (Michael Albinus's message of "Mon, 01 Jun 2015 11:20:58 +0200") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104521 Archived-At: On Mon, 01 Jun 2015 11:20:58 +0200 Michael Albinus wrote: MA> Krzysztof Jurewicz writes: >> One possible patch is attached below. This is the simplest solution; I >> have not thought much about whether it may be more desirable to convert >> numbers to strings inside the secrets.el package. MA> Well, secrets.el expects only strings as attributes. No conversion MA> foreseen. I don't know what auth-source.el does. If auth-source-search MA> also allows only strings (and symbol names) as attributes, then your MA> patch is right. Otherwise, if a :port attribute could also be an MA> integer, it shall be transformed to a string. Sorry for the late reply. The docs of `auth-source-search' say: A string value is always matched literally. A symbol is matched as its string value, literally. All the SPEC values can be single values (symbol or string) or lists thereof (in which case any of the search terms matches). ...so numbers are not allowed. By design, that means that "80" and "http" can be used for :port, for instance. IIRC there was no gain from making any of the search criteria take numbers in the case of auth-source.el specifically. So I think the patch is OK :) Ted