bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function

bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function

[Robert Cochran]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

Hello bug-gnu-emacs,

As discussed in Bug#23957, the FIXME above fboundp suggesting to alias
it to symbol-function is considered too great a risk to backwards
compatibility. This patch removes the FIXME, so that other developers do
not waste their time on it.

Thanks,
~Robert Cochran


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch to remove fboundp alias FIXME --]
[-- Type: text/x-patch, Size: 943 bytes --]

From cd13d3b0f1fc5ff0fcf2b581c8cffb18f5e05e05 Mon Sep 17 00:00:00 2001
From: Robert Cochran <robert-git@cochranmail.com>
Date: Thu, 14 Jul 2016 15:37:24 -0700
Subject: [PATCH] Remove FIXME to alias fboundp to symbol-function

As discussed in Bug#23957, the general consensus is that the FIXME was
ill-advised. Remove it, so that no one else wastes time on it.

* src/data.c (fboundp): Remove FIXME suggesting to alias it to
  symbol-function.
---
 src/data.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/data.c b/src/data.c
index 71da916..d8be1dc 100644
--- a/src/data.c
+++ b/src/data.c
@@ -629,7 +629,6 @@ global value outside of any lexical scope.  */)
   return (EQ (valcontents, Qunbound) ? Qnil : Qt);
 }
 
-/* FIXME: Make it an alias for function-symbol!  */
 DEFUN ("fboundp", Ffboundp, Sfboundp, 1, 1, 0,
        doc: /* Return t if SYMBOL's function definition is not void.  */)
   (register Lisp_Object symbol)
-- 
2.7.4

bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function

[Eli Zaretskii]

> From: Robert Cochran <robert-emacs@cochranmail.com>
> Date: Thu, 14 Jul 2016 15:49:37 -0700
> 
> As discussed in Bug#23957, the FIXME above fboundp suggesting to alias
> it to symbol-function is considered too great a risk to backwards
> compatibility. This patch removes the FIXME, so that other developers do
> not waste their time on it.

How about adding a comment there that summarizes the discussion in
that bug?  Perhaps someone will come up with a clever idea to overcome
the difficulties.

Thanks.

bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function

[Robert Cochran]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> How about adding a comment there that summarizes the discussion in
> that bug?  Perhaps someone will come up with a clever idea to overcome
> the difficulties.

That's a good point. I have attached a new patch that summarizes the
discussion.

Thanks,
~Robert Cochran


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Patch that details discussion of the fboundp FIXME --]
[-- Type: text/x-patch, Size: 1374 bytes --]

From 60921ce566429711c7366ab6663fa37ee97b9190 Mon Sep 17 00:00:00 2001
From: Robert Cochran <robert-git@cochranmail.com>
Date: Fri, 15 Jul 2016 12:45:56 -0700
Subject: [PATCH] Expand FIXME near definition of fboundp

This expansion of the FIXME is so that future developers are aware of
the potential problems of aliasing fboundp to symbol-function without
taking backwards compatibility into account.

* src/data.c (fboundp): Note potential backwards compatibility issues in
  FIXME.
---
 src/data.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/data.c b/src/data.c
index 71da916..9846006 100644
--- a/src/data.c
+++ b/src/data.c
@@ -629,7 +629,12 @@ global value outside of any lexical scope.  */)
   return (EQ (valcontents, Qunbound) ? Qnil : Qt);
 }
 
-/* FIXME: Make it an alias for function-symbol!  */
+/* FIXME: It has been previously suggested to make this function an
+   alias for symbol-function, but upon discussion at Debbug#23957,
+   there is a risk breaking backward compatiblity, as some users of
+   fboundp may expect `t' in particular, rather than any true
+   value. An alias is still welcome so long as the compatibility
+   issues are addressed.  */
 DEFUN ("fboundp", Ffboundp, Sfboundp, 1, 1, 0,
        doc: /* Return t if SYMBOL's function definition is not void.  */)
   (register Lisp_Object symbol)
-- 
2.7.4

bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function

[Eli Zaretskii]

> From: Robert Cochran <robert-emacs@cochranmail.com>
> Cc: Robert Cochran <robert-emacs@cochranmail.com>,  23988@debbugs.gnu.org
> Date: Fri, 15 Jul 2016 12:50:02 -0700
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > How about adding a comment there that summarizes the discussion in
> > that bug?  Perhaps someone will come up with a clever idea to overcome
> > the difficulties.
> 
> That's a good point. I have attached a new patch that summarizes the
> discussion.

LGTM, thanks.  Can someone please push this to the emacs-25 branch?

bug#23988: [PATCH] Remove FIXME to alias fboundp to symbol-function

[npostavs]

tags 23988 fixed
close 23988 25.1
quit

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Cochran <robert-emacs@cochranmail.com>
>> Cc: Robert Cochran <robert-emacs@cochranmail.com>,  23988@debbugs.gnu.org
>> Date: Fri, 15 Jul 2016 12:50:02 -0700
>> 
>> That's a good point. I have attached a new patch that summarizes the
>> discussion.
>
> LGTM, thanks.  Can someone please push this to the emacs-25 branch?

Pushed as 9356fe2 (fixed a missing double space).  I marked as
"Copyright-paperwork-exempt: yes", since in the Bug #23957 Robert said

> I understand that the FSF requires a copyright assignment for
> non-trivial patches made to Emacs [...]
> I am perfectly happy to do so, but require guidance on how
> to accomplish it. On that topic, how can I go about this process so that
> I automatically perform the appropriate assignments for each
> contribution?

You can fill out the form here with program name "Emacs", and send email
to the address it mentions:
http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=doc/Copyright/request-assign.program;hb=HEAD

You'll receive further instructions (signing a document and such).