unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: npostavs@users.sourceforge.net
To: Drew Adams <drew.adams@oracle.com>
Cc: 25302@debbugs.gnu.org
Subject: bug#25302: 25.1; `isearch-allow-prefix' does not allow `C-u C-u'
Date: Sat, 31 Dec 2016 00:37:13 -0500	[thread overview]
Message-ID: <871swo8xrq.fsf@users.sourceforge.net> (raw)
In-Reply-To: <3092dec9-4cf4-47e7-b05a-27a953c0a544@default> (Drew Adams's message of "Fri, 30 Dec 2016 14:57:53 -0800 (PST)")

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

Drew Adams <drew.adams@oracle.com> writes:

> But a guess about the regression for `isearch-allow-scroll' is that
> it also needs to be added here:
>
>  ;; Universal argument commands
>  (put 'universal-argument 'isearch-scroll t)
>  (put 'negative-argument 'isearch-scroll t)
>  (put 'digit-argument 'isearch-scroll t)
>
> IOW, add (put 'universal-argument-more 'isearch-scroll t)

Agreed.


[-- Attachment #2: patch v2 --]
[-- Type: text/plain, Size: 1342 bytes --]

From b92e54be715fd7880a4f3c260dfc360eff3f1e57 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sat, 31 Dec 2016 00:31:49 -0500
Subject: [PATCH v2] Fix isearch handling of C-u C-u...

* lisp/isearch.el: Add `isearch-scroll' property to
universal-argument-more so that `isearch-allow-scroll' will apply to it
as well.
(isearch-pre-command-hook): Let `isearch-allow-prefix' apply to
`universal-argument-more' as well (Bug#25302).
---
 lisp/isearch.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/isearch.el b/lisp/isearch.el
index 9846f0b..af82229 100644
--- a/lisp/isearch.el
+++ b/lisp/isearch.el
@@ -2297,6 +2297,7 @@ isearch-fallback
 
 ;; Universal argument commands
 (put 'universal-argument 'isearch-scroll t)
+(put 'universal-argument-more 'isearch-scroll t)
 (put 'negative-argument 'isearch-scroll t)
 (put 'digit-argument 'isearch-scroll t)
 
@@ -2389,7 +2390,7 @@ isearch-pre-command-hook
       (setq this-command 'isearch-edit-string))
      ;; Handle a scrolling function or prefix argument.
      ((or (and isearch-allow-prefix
-	       (memq this-command '(universal-argument
+               (memq this-command '(universal-argument universal-argument-more
 				    digit-argument negative-argument)))
 	  (and isearch-allow-scroll
 	       (symbolp this-command)
-- 
2.9.3


  reply	other threads:[~2016-12-31  5:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-30 22:08 bug#25302: 25.1; `isearch-allow-prefix' does not allow `C-u C-u' Drew Adams
2016-12-30 22:27 ` npostavs
2016-12-30 22:46   ` Drew Adams
2016-12-30 22:57     ` Drew Adams
2016-12-31  5:37       ` npostavs [this message]
2017-01-06  1:27         ` npostavs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871swo8xrq.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=25302@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).