From: npostavs@users.sourceforge.net
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 23486@debbugs.gnu.org
Subject: bug#23486: 25.0.93; Modules: features missing from make_function
Date: Sun, 26 Mar 2017 23:57:20 -0400 [thread overview]
Message-ID: <871stj4bj3.fsf@users.sourceforge.net> (raw)
In-Reply-To: <wvr4a8jzchll.fsf@a.muc.corp.google.com> (Philipp Stephani's message of "Mon, 09 May 2016 18:37:58 +0200")
Philipp Stephani <p.stephani2@gmail.com> writes:
> As an alternative, if people feel this would require too many
> parameters, I'd propose reverting the change that adds the documentation
> string. A docstring without arglist is not very useful. We could also
> remove the arity parameters and have the C function check the arity
> itself.
Looking at this a bit closer, I do think this adds too many parameters,
and in particular, requiring to pass in names for positional parameters
just makes no sense. The names are never used (except for displaying
documentation).
But removing the docstring is not great. IMO, the right solution here
is to use a subr-like object instead of a lambda, as suggested in a
FIXME in emacs-module.c:
/* FIXME: Use a bytecompiled object, or even better a subr. */
Then the arity could be checked with `subr-arity' or similar.
next prev parent reply other threads:[~2017-03-27 3:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 16:37 bug#23486: 25.0.93; Modules: features missing from make_function Philipp Stephani
2016-09-11 14:13 ` Philipp Stephani
2016-09-11 14:57 ` npostavs
2017-03-26 20:02 ` Philipp Stephani
2017-03-26 20:22 ` npostavs
2017-03-26 20:40 ` Philipp Stephani
2017-03-27 3:57 ` npostavs [this message]
2017-07-04 18:20 ` Philipp Stephani
2017-07-05 3:40 ` npostavs
2020-09-05 13:59 ` Lars Ingebrigtsen
2020-09-13 9:44 ` Philipp Stephani
2020-09-13 13:20 ` Lars Ingebrigtsen
2020-09-13 18:50 ` Philipp Stephani
2020-12-07 16:42 ` Lars Ingebrigtsen
2020-12-12 14:31 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871stj4bj3.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=23486@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).