From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28797: 26.0.90; Improve printing of error on catching file-error in dired Date: Fri, 13 Oct 2017 09:15:01 -0400 Message-ID: <871sm7b356.fsf@users.sourceforge.net> References: <87a80vbuur.fsf@users.sourceforge.net> <83y3ofjuer.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1507900577 12844 195.159.176.226 (13 Oct 2017 13:16:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 13 Oct 2017 13:16:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: 28797@debbugs.gnu.org, tino.calancha@gmail.com, kaushal.modi@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 13 15:16:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2zov-0002f9-3s for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 15:16:09 +0200 Original-Received: from localhost ([::1]:50276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2zp2-0006OB-CK for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Oct 2017 09:16:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47025) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e2zot-0006Ml-4F for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:16:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e2zoo-0006Px-QF for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:16:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56546) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e2zoo-0006Pt-MI for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e2zoo-0000HU-GF for bug-gnu-emacs@gnu.org; Fri, 13 Oct 2017 09:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 Oct 2017 13:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28797 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28797-submit@debbugs.gnu.org id=B28797.1507900511981 (code B ref 28797); Fri, 13 Oct 2017 13:16:02 +0000 Original-Received: (at 28797) by debbugs.gnu.org; 13 Oct 2017 13:15:11 +0000 Original-Received: from localhost ([127.0.0.1]:36994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2znz-0000Fl-7W for submit@debbugs.gnu.org; Fri, 13 Oct 2017 09:15:11 -0400 Original-Received: from mail-io0-f172.google.com ([209.85.223.172]:47177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e2znx-0000FV-QZ for 28797@debbugs.gnu.org; Fri, 13 Oct 2017 09:15:10 -0400 Original-Received: by mail-io0-f172.google.com with SMTP id h70so8932311ioi.4 for <28797@debbugs.gnu.org>; Fri, 13 Oct 2017 06:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Vz69gFYmAmU8oNKKZE2ifE0ARMevVmbYuuVdOlHBP8k=; b=sffdQQ4gU13VrNKpQEjgup7zJRJ7V2+3zonHs2+VQrRFwTHKpK/TDl1qX7mGqZXhCr y7JH1ykq5aqC2EJla2WkS6f0GIL0Dd0/r0wEgrCT1Td8X5AFS5WW63FjYGoDE3HipkAY NpDUJzMhSQ4Pd0va7WIRnilkxQAl+pgGtKV36bkWXZLOQ3W3CMjEzvCZy8+LqPpGhM27 waJQLrQl/FCSK2V1Zi5SkY2NpIOzrE00msin3YX+kIL6VK0GvgpI1/xVyoE5CdzEfciN bPE0JUV53McZFo6GecZlJ8xFo2XiyNVBAAhoSTnOvSik/nvTq9mWkYpJvTDbfZEdb9SH junw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=Vz69gFYmAmU8oNKKZE2ifE0ARMevVmbYuuVdOlHBP8k=; b=jD2LpuJaaHXP2XyaRJUMAHQA3LedaLbmnCI6pw78JwSJrSOdTUBjV5sjHwJHV3MuVD 8qRYHyaFTMgJv+OUE8DwmkNyyaJ09Rbl9v8anqyN1+dxfV7StsCZa8sSYFHrR5x290uY J0CtiAUyOhyM5x0Fv6rMf0tRsLe2mbmnpTobz8D5PU/BMm8L/WltTQ+JTP2TDjc6hGio KqHIpWS/KSOE1aGVp0J4+r2Gkx3dnWaW3KzukSZxBauXDjmNLt/7U3BwLw3LhwWKRVfc vL/MxdRf/dPpH34uJLNry/w8CtniYz590ifrn8NmCaEjg9gB7xgILecPPxfZMrx6RV3z QdwQ== X-Gm-Message-State: AMCzsaXGU1oDoeAlAaFah1pHSDbcuCMUx1UeYfVh9988VT60ou/Gsj0B TmFKoYJPz9jfuEtZcL+aXc0= X-Google-Smtp-Source: AOwi7QCW6bMoXsBN2eZJHio0qJuWRd8PqVcFJm5mkFZ5jHNrD2NMtk6HYYkSLNinKIwzC2h3h5Mivg== X-Received: by 10.107.46.199 with SMTP id u68mr1719293iou.174.1507900504010; Fri, 13 Oct 2017 06:15:04 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id r65sm683635ith.1.2017.10.13.06.15.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 13 Oct 2017 06:15:02 -0700 (PDT) In-Reply-To: <83y3ofjuer.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 Oct 2017 11:58:52 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138340 Archived-At: Eli Zaretskii writes: >> Here's a patch, uses error-message-string for #1, > > This doesn't handle all of the parts of the complaint, does it? The resulting error will look like file-error: Non-regular file: Is a directory, /home/kmodi/.emacs.d/foo It's not quite the perfect sentence envisioned on the OP, but it gets all the information across, with punctuation separating the parts. Shouldn't (file-error Non-regular file Is a directory /home/kmodi/.emacs.d/foo) look like: file-error: Non-regular file: /home/kmodi/.emacs.d/foo is a directory - Why those parentheses? - Why are "N" and "I" capitalized in-between that "sentence".. error messages are usually sentences without ending in period, right? - Above instead looks like a list printed with 3 elements. For this part: Also, the error is not-informative.. the user is trying to trash foo/ and knows that foo/ is a directory.. so how would the below help? I guess what would help is printing "there is a bug with Emacs renaming a directory across filesystems", but that seems a bit out of reach for a simple error formatting function... >> condition-case-unless-debug for #2. > > This is quite a radical change in very old behavior, so if it is > deemed a good idea, it should go to master. Hmm, it doesn't seem that radical to me, but I don't have a problem putting it only to master, or even not doing that at all and just saying the user should use debug-on-signal.