From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Pierre Neidhardt <ambrevar@gmail.com>
Cc: 29157@debbugs.gnu.org
Subject: bug#29157: 25.3; Eshell parsing fails sometimes, e.g. "date" and "sed"
Date: Sat, 25 Nov 2017 13:50:46 -0500 [thread overview]
Message-ID: <871skmyyyh.fsf@users.sourceforge.net> (raw)
In-Reply-To: <87lgiui6qc.fsf@gmail.com> (Pierre Neidhardt's message of "Sat, 25 Nov 2017 18:54:51 +0100")
Pierre Neidhardt <ambrevar@gmail.com> writes:
> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> We could fallback to the external command if given arguments. This is
>>> being done currently for other commands like eshell/rm (for unrecognized
>>> arguments, that is).
>> That doesn't sound right to me (for rm as well): it will fail in
>> strange ways for systems where the external command is absent or
>> deficient.
Currently eshell falls back to external command for unrecognized
arguments when passing :external to eshell-eval-using-options. A quick
grep for :external brings up: rm, mkdir, rmdir, mv, cp, ln, cat, du,
time, env, ls.
>> Observe:
>>
>> ~/git/emacs/branch $ date 42
>> Wed Dec 31 19:00:42 1969
>> But
>> ~/git/emacs/branch $ *date 42
>> /bin/date: invalid date ‘42’
>>
>> So I'm not sure such a naïve solution is TRT in this case, because we
>> are losing valuable features by doing that,
So we could also check for an integer argument.
>> and those features are not
>> just an accident, they were intentionally included in Eshell.
Hmm, my impression of eshell is more like "throw a bunch of features at
the wall and see what sticks" but without the "see what sticks" part.
> The issue here is mostly my lack of awareness about what is an Elisp
> command and what is a system program.
>
> Maybe having different syntax highlighting for the "verb" depending on
> whether it's a system program or an Elisp command would help avoiding
> the pitfall.
>
> Is there a trivial way to do this? If not I'll work on it.
There is no such feature, as far as I know.
next prev parent reply other threads:[~2017-11-25 18:50 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-05 11:37 bug#29157: 25.3; Eshell parsing fails sometimes, e.g. "date" and "sed" Pierre Neidhardt
2017-11-05 13:58 ` Noam Postavsky
2017-11-05 14:16 ` Pierre Neidhardt
2017-11-23 3:13 ` Noam Postavsky
2017-11-23 6:55 ` Pierre Neidhardt
2017-11-23 12:59 ` Noam Postavsky
2017-11-23 16:26 ` Eli Zaretskii
2017-11-25 17:54 ` Pierre Neidhardt
2017-11-25 18:32 ` Michael Albinus
2017-11-25 18:35 ` Pierre Neidhardt
2017-11-25 18:50 ` Noam Postavsky [this message]
2017-11-25 19:50 ` Eli Zaretskii
2017-11-25 20:06 ` Noam Postavsky
2017-11-25 20:25 ` Eli Zaretskii
2017-11-25 21:41 ` Noam Postavsky
2017-11-26 3:35 ` Eli Zaretskii
2017-11-26 3:21 ` John Wiegley
2017-11-26 15:35 ` Eli Zaretskii
2017-11-26 21:44 ` John Wiegley
2017-11-25 19:29 ` Eli Zaretskii
2017-11-25 19:36 ` Pierre Neidhardt
2017-11-25 19:57 ` Eli Zaretskii
2017-11-26 9:17 ` Pierre Neidhardt
2017-11-26 15:53 ` Eli Zaretskii
2017-11-26 3:21 ` John Wiegley
2017-11-26 15:33 ` Eli Zaretskii
2017-11-26 21:45 ` John Wiegley
2017-11-27 3:32 ` Eli Zaretskii
2017-12-21 8:17 ` John Wiegley
2017-12-03 20:43 ` Noam Postavsky
2017-12-04 8:43 ` John Wiegley
2017-12-04 12:51 ` Noam Postavsky
2017-11-05 15:16 ` Andreas Schwab
2017-11-10 2:04 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871skmyyyh.fsf@users.sourceforge.net \
--to=npostavs@users.sourceforge.net \
--cc=29157@debbugs.gnu.org \
--cc=ambrevar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).