From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#29478: 26.0.90; `C-h k' followed by mouse clicks no longer shows down event Date: Mon, 27 Nov 2017 20:50:11 -0500 Message-ID: <871skjnpd8.fsf@users.sourceforge.net> References: <1b3879d6-f14e-47b0-970f-baf09598fcfd@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1511833879 23043 195.159.176.226 (28 Nov 2017 01:51:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Nov 2017 01:51:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) Cc: Alan Mackenzie , 29478@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 28 02:51:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJV3F-0005GJ-Ps for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 02:51:09 +0100 Original-Received: from localhost ([::1]:35519 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJV3L-0002jt-At for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Nov 2017 20:51:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJV3B-0002hM-Nm for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 20:51:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJV38-0003ck-K7 for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 20:51:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52806) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJV38-0003cW-Fj for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 20:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJV38-0007cd-8l for bug-gnu-emacs@gnu.org; Mon, 27 Nov 2017 20:51:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Nov 2017 01:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29478 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 29478-submit@debbugs.gnu.org id=B29478.151183382129248 (code B ref 29478); Tue, 28 Nov 2017 01:51:02 +0000 Original-Received: (at 29478) by debbugs.gnu.org; 28 Nov 2017 01:50:21 +0000 Original-Received: from localhost ([127.0.0.1]:33254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJV2T-0007bb-9s for submit@debbugs.gnu.org; Mon, 27 Nov 2017 20:50:21 -0500 Original-Received: from mail-io0-f170.google.com ([209.85.223.170]:34915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJV2R-0007bI-Eq; Mon, 27 Nov 2017 20:50:19 -0500 Original-Received: by mail-io0-f170.google.com with SMTP id i38so38581580iod.2; Mon, 27 Nov 2017 17:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=bRdloU3VHU+EdqWboL6r8SU91oEHNAFCUUueyfVu3kY=; b=PvkZrGK34Z/nYhgXVOUz6Vkwtp8uSwZydaMycytkFtMv8Vp1Os59Km/Sn16nWvekrz +LaNdocxX7bqylbULSfhZMNae9VEBb2rtpIeFqK6+Jen4jdEPYJ5kxY/bFPXTVg2BQtN 6s3PYYxeUelUstM5kBZpE7rP51jlysfRZSb+5eGNq9y8YqIL1XElJEXjkCp1dPFFz1Iq CUNG4kwTSGY4esye4zmeNtYKHnkGayt/s9kvCSweyfWlM0ClTXxeMk5I0dZDLThphkSE Lc6WMtTgaNSt1VA2ACo8k58i2DPpmbA5U0xB2MlZIiIoxOxTbbJKKZQTKyIXqlmzXUfb kl/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=bRdloU3VHU+EdqWboL6r8SU91oEHNAFCUUueyfVu3kY=; b=ppgX9WAfgX3GcKMVomuDZaL4OXOSeuz4tmNZhmevrQVdtyB/gSLQpDS0oTdKoqCEfz wIYKSCPfXuKXG/3F5PKxkU6lrvKDJ+w5OZtJUDk0FZFO+alBdjewfIvc5OSN5eQhRKGi awuW/u0SyBBxdVQFz7WcTvYrvxw2X4FYfwaOljqAPuyx5Y2MjcYkUk+xu88mSlIom75E EGG1z2vucvTQZvX7D4RnTmrjYd/cL4/lfvRK5F3azW+0UV5OvwvivqivK1EEUZdimXmx Fr8xhBix8f7BN0LoLuF/YQ2QbQ6574SoK+zV/Viau0ocRSqNiq4orESNWTstDImm2gJN CiRg== X-Gm-Message-State: AJaThX7MzGn533JsxX0L/XykkxF48chgrPmNTVSde5+38H5cGLoE6t3E Pup/R/TXE7Yif4B3nQkHqEimUQ== X-Google-Smtp-Source: AGs4zMaBmKzIytGWy+drnAH/iwF3AwYr2MSyBZ+Xutu/5goqdw/Zrr9ZmU694XOvbRJN0gXBBc1HsQ== X-Received: by 10.107.184.212 with SMTP id i203mr9876023iof.17.1511833813592; Mon, 27 Nov 2017 17:50:13 -0800 (PST) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id w68sm11835010iow.18.2017.11.27.17.50.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Nov 2017 17:50:12 -0800 (PST) In-Reply-To: <1b3879d6-f14e-47b0-970f-baf09598fcfd@default> (Drew Adams's message of "Mon, 27 Nov 2017 15:21:43 -0800 (PST)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140478 Archived-At: tags 29272 + confirmed quit Drew Adams writes: > The down mouse-button event is no longer listed along with the up > event when you use `C-h k' with a click event. Dunno whether this was > by design or is an oversight. Looks like oversight. Possibly related to Bug#29272. The following seems to fix it for me, but I'm having trouble convincing myself that it's the right thing. --- c/lisp/help.el +++ i/lisp/help.el @@ -738,7 +738,7 @@ help-read-key-sequence ;; spuriously trigger the `sit-for'. (sleep-for 0.01) (while (read-event nil nil 0.01)) - (not (sit-for (/ double-click-time 1000.0) t)))))))) + (sit-for (/ double-click-time 1000.0) t))))))) (list key ;; If KEY is a down-event, read and include the Alan, I believe you've been working on this code recently, any thoughts?