From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#29489: Obsolete gnus-remove-if and gnus-remove-if-not Date: Tue, 28 Nov 2017 19:31:16 -0800 Message-ID: <871skhdam3.fsf@ericabrahamsen.net> References: <87o9nmgwue.fsf@ericabrahamsen.net> <87r2sim0je.fsf@users.sourceforge.net> <87a7z6c5i0.fsf@ericabrahamsen.net> <87mv35nchc.fsf@users.sourceforge.net> <87609tdfnz.fsf@ericabrahamsen.net> <871skhlsk0.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1511926333 19136 195.159.176.226 (29 Nov 2017 03:32:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 29 Nov 2017 03:32:13 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 29489@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 29 04:32:09 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJt6T-0004SK-Q8 for geb-bug-gnu-emacs@m.gmane.org; Wed, 29 Nov 2017 04:32:05 +0100 Original-Received: from localhost ([::1]:41125 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJt6a-0000tJ-Vj for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 Nov 2017 22:32:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJt6V-0000qx-2h for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 22:32:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJt6Q-0000CW-VA for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 22:32:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55067) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eJt6Q-0000CO-Py for bug-gnu-emacs@gnu.org; Tue, 28 Nov 2017 22:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eJt6Q-00071Q-0X; Tue, 28 Nov 2017 22:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Wed, 29 Nov 2017 03:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29489 X-GNU-PR-Package: emacs,gnus X-GNU-PR-Keywords: patch Original-Received: via spool by 29489-submit@debbugs.gnu.org id=B29489.151192628126936 (code B ref 29489); Wed, 29 Nov 2017 03:32:01 +0000 Original-Received: (at 29489) by debbugs.gnu.org; 29 Nov 2017 03:31:21 +0000 Original-Received: from localhost ([127.0.0.1]:35515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJt5j-00070N-JS for submit@debbugs.gnu.org; Tue, 28 Nov 2017 22:31:21 -0500 Original-Received: from mail.ericabrahamsen.net ([50.56.99.223]:39540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eJt5i-00070F-IJ for 29489@debbugs.gnu.org; Tue, 28 Nov 2017 22:31:18 -0500 Original-Received: from localhost (71-212-22-173.tukw.qwest.net [71.212.22.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id A3747BF303; Wed, 29 Nov 2017 03:31:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.ericabrahamsen.net; s=mail; t=1511926277; bh=r+Q01PG/22G0L5lJpnMKTU39YgRH62tqZtiR/S3WrH4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=JlxzzXF1wFOGbhsr1UxhQXqcMiyQ4/3qK15+l1gdJQGFai2bw+bTJhuXnZrxc7i7l c7l1i6IPdjSJUMySH9lc+xteFQJjWhctRNxn5njBZXvIpTo/m1XBXhjUXEameo5lLJ DdFhwsb3+BfokLBghJM0nu4ksMh7dySCoxCXZH8s= In-Reply-To: <871skhlsk0.fsf@users.sourceforge.net> (Noam Postavsky's message of "Tue, 28 Nov 2017 21:36:31 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:140532 Archived-At: Noam Postavsky writes: > Eric Abrahamsen writes: > >> For the interim, all that matters is consistency: >> >> (let ((list nil) >> (ob (make-vector 3 0))) >> (intern "foo" ob) >> (intern "bar" ob) >> (intern "xxx" ob) >> (gnus-remove-if-not (lambda (_) t) ob)) ;=> (xxx 0 0) > > But: > > (let ((list nil) > (ob (make-vector 3 0))) > (intern "foo" ob) > (intern "bar" ob) > (intern "xxx" ob) > (gnus-remove-if-not (lambda (_) t) > ob t)) ;=> (xxx bar foo) Good catch! Thanks for that. I was too hasty, and had already moved on to running the next patch. There are only two places in the code where that third argument is passed. I can rework those two locations so that they work properly, until the next step is taken.