bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[William G. Gardella]

On the Emacs 25 pretests, `erc-echo-timestamp' no longer displays a
timestamp in the echo area when placing point next to each line in a
buffer. Now the timestamps only appear for the first and last line of
the buffer. This might be related to the new `cursor-sensor-mode'
functionality replacing the old implementation, but I am not sure.



In GNU Emacs 25.0.91.1 (x86_64-slackware-linux-gnu)
 of 2016-02-16 built on eris
Windowing system distributor 'The X.Org Foundation', version 11.0.11403000
Configured using:
 'configure --prefix=/usr --sysconfdir=/etc --localstatedir=/var
 --program-prefix= --program-suffix= --mandir=/usr/man
 --infodir=/usr/info --without-gconf --without-gsettings --with-x
 --with-x-toolkit=no --build=x86_64-slackware-linux 'CFLAGS=-O2
 -fPIC''

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS NOTIFY ACL
GNUTLS LIBXML2 FREETYPE XFT ZLIB X11

Important settings:
  value of $LC_COLLATE: C
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=exim
  locale-coding-system: utf-8-unix

Major mode: Group

Minor modes in effect:
  semantic-minor-modes-format: ((:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode)  S)))
  gnus-agent-group-mode: t
  gnus-topic-mode: t
  gnus-undo-mode: t
  show-paren-mode: t
  erc-services-mode: t
  erc-autoaway-mode: t
  xterm-mouse-mode: t
  winner-mode: t
  type-break-mode: t
  magit-wip-before-change-mode: t
  magit-wip-after-apply-mode: t
  magit-wip-after-save-mode: t
  diff-auto-refine-mode: t
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  shell-dirtrack-mode: t
  async-bytecomp-package-mode: t
  electric-pair-mode: t
  erc-list-mode: t
  erc-menu-mode: t
  erc-autojoin-mode: t
  erc-ring-mode: t
  erc-networks-mode: t
  erc-pcomplete-mode: t
  erc-match-mode: t
  erc-netsplit-mode: t
  erc-hl-nicks-mode: t
  erc-button-mode: t
  erc-fill-mode: t
  erc-stamp-mode: t
  erc-irccontrols-mode: t
  erc-noncommands-mode: t
  erc-keep-place-mode: t
  erc-move-to-prompt-mode: t
  erc-readonly-mode: t
  pdf-occur-global-minor-mode: t
  display-time-mode: t
  savehist-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  transient-mark-mode: t

Recent messages:
Timestamped (2016-02-16 15:58)
Debug on Error disabled globally
Mark set
Timestamped (2016-02-16 16:03)
Mark set
Timestamped (2016-02-16 15:21) [3 times]
Auto-saving...done
Mark set
Timestamped (2016-02-16 16:03)
Timestamped (2016-02-16 15:59)

Load-path shadows:
~/git/org-mode/contrib/lisp/org-mime hides /home/wgg/.emacs.d/elpa/org-mime-20120112/org-mime
/usr/share/emacs/site-lisp/t-mouse hides /usr/share/emacs/25.0.91/lisp/t-mouse
~/git/org-mode/lisp/ob-screen hides /usr/share/emacs/25.0.91/lisp/org/ob-screen
~/git/org-mode/lisp/ob-C hides /usr/share/emacs/25.0.91/lisp/org/ob-C
~/git/org-mode/lisp/org-capture hides /usr/share/emacs/25.0.91/lisp/org/org-capture
~/git/org-mode/lisp/org-w3m hides /usr/share/emacs/25.0.91/lisp/org/org-w3m
~/git/org-mode/lisp/org-eshell hides /usr/share/emacs/25.0.91/lisp/org/org-eshell
~/git/org-mode/lisp/org-clock hides /usr/share/emacs/25.0.91/lisp/org/org-clock
~/git/org-mode/lisp/org-gnus hides /usr/share/emacs/25.0.91/lisp/org/org-gnus
~/git/org-mode/lisp/org-indent hides /usr/share/emacs/25.0.91/lisp/org/org-indent
~/git/org-mode/lisp/ox-texinfo hides /usr/share/emacs/25.0.91/lisp/org/ox-texinfo
~/git/org-mode/lisp/org-macs hides /usr/share/emacs/25.0.91/lisp/org/org-macs
~/git/org-mode/lisp/ob-java hides /usr/share/emacs/25.0.91/lisp/org/ob-java
~/git/org-mode/lisp/ox-ascii hides /usr/share/emacs/25.0.91/lisp/org/ox-ascii
~/git/org-mode/lisp/ob-octave hides /usr/share/emacs/25.0.91/lisp/org/ob-octave
~/git/org-mode/lisp/org-bbdb hides /usr/share/emacs/25.0.91/lisp/org/org-bbdb
~/git/org-mode/lisp/ob-latex hides /usr/share/emacs/25.0.91/lisp/org/ob-latex
~/git/org-mode/lisp/org-plot hides /usr/share/emacs/25.0.91/lisp/org/org-plot
~/git/org-mode/lisp/ox-man hides /usr/share/emacs/25.0.91/lisp/org/ox-man
~/git/org-mode/lisp/org-id hides /usr/share/emacs/25.0.91/lisp/org/org-id
~/git/org-mode/lisp/ob-sass hides /usr/share/emacs/25.0.91/lisp/org/ob-sass
~/git/org-mode/lisp/org-datetree hides /usr/share/emacs/25.0.91/lisp/org/org-datetree
~/git/org-mode/lisp/ox hides /usr/share/emacs/25.0.91/lisp/org/ox
~/git/org-mode/lisp/ob-org hides /usr/share/emacs/25.0.91/lisp/org/ob-org
~/git/org-mode/lisp/org-timer hides /usr/share/emacs/25.0.91/lisp/org/org-timer
~/git/org-mode/lisp/org-attach hides /usr/share/emacs/25.0.91/lisp/org/org-attach
~/git/org-mode/lisp/org-mouse hides /usr/share/emacs/25.0.91/lisp/org/org-mouse
~/git/org-mode/lisp/ob-R hides /usr/share/emacs/25.0.91/lisp/org/ob-R
~/git/org-mode/lisp/ob-awk hides /usr/share/emacs/25.0.91/lisp/org/ob-awk
~/git/org-mode/lisp/ob-perl hides /usr/share/emacs/25.0.91/lisp/org/ob-perl
~/git/org-mode/lisp/org-colview hides /usr/share/emacs/25.0.91/lisp/org/org-colview
~/git/org-mode/lisp/ob-comint hides /usr/share/emacs/25.0.91/lisp/org/ob-comint
~/git/org-mode/lisp/org-mobile hides /usr/share/emacs/25.0.91/lisp/org/org-mobile
~/git/org-mode/lisp/ob-mscgen hides /usr/share/emacs/25.0.91/lisp/org/ob-mscgen
~/git/org-mode/lisp/ob-haskell hides /usr/share/emacs/25.0.91/lisp/org/ob-haskell
~/git/org-mode/lisp/ob-table hides /usr/share/emacs/25.0.91/lisp/org/ob-table
~/git/org-mode/lisp/ob-ocaml hides /usr/share/emacs/25.0.91/lisp/org/ob-ocaml
~/git/org-mode/lisp/ox-icalendar hides /usr/share/emacs/25.0.91/lisp/org/ox-icalendar
~/git/org-mode/lisp/org-pcomplete hides /usr/share/emacs/25.0.91/lisp/org/org-pcomplete
~/git/org-mode/lisp/org-agenda hides /usr/share/emacs/25.0.91/lisp/org/org-agenda
~/git/org-mode/lisp/ob-ditaa hides /usr/share/emacs/25.0.91/lisp/org/ob-ditaa
~/git/org-mode/lisp/org-faces hides /usr/share/emacs/25.0.91/lisp/org/org-faces
~/git/org-mode/lisp/org-ctags hides /usr/share/emacs/25.0.91/lisp/org/org-ctags
~/git/org-mode/lisp/org hides /usr/share/emacs/25.0.91/lisp/org/org
~/git/org-mode/lisp/ob-picolisp hides /usr/share/emacs/25.0.91/lisp/org/ob-picolisp
~/git/org-mode/lisp/ob-exp hides /usr/share/emacs/25.0.91/lisp/org/ob-exp
~/git/org-mode/lisp/ob-core hides /usr/share/emacs/25.0.91/lisp/org/ob-core
~/git/org-mode/lisp/ox-publish hides /usr/share/emacs/25.0.91/lisp/org/ox-publish
~/git/org-mode/lisp/ob hides /usr/share/emacs/25.0.91/lisp/org/ob
~/git/org-mode/lisp/org-compat hides /usr/share/emacs/25.0.91/lisp/org/org-compat
~/git/org-mode/lisp/ob-io hides /usr/share/emacs/25.0.91/lisp/org/ob-io
~/git/org-mode/lisp/ob-scala hides /usr/share/emacs/25.0.91/lisp/org/ob-scala
~/git/org-mode/lisp/org-irc hides /usr/share/emacs/25.0.91/lisp/org/org-irc
~/git/org-mode/lisp/ob-plantuml hides /usr/share/emacs/25.0.91/lisp/org/ob-plantuml
~/git/org-mode/lisp/ob-maxima hides /usr/share/emacs/25.0.91/lisp/org/ob-maxima
~/git/org-mode/lisp/ob-clojure hides /usr/share/emacs/25.0.91/lisp/org/ob-clojure
~/git/org-mode/lisp/ob-emacs-lisp hides /usr/share/emacs/25.0.91/lisp/org/ob-emacs-lisp
~/git/org-mode/lisp/ob-tangle hides /usr/share/emacs/25.0.91/lisp/org/ob-tangle
~/git/org-mode/lisp/ob-asymptote hides /usr/share/emacs/25.0.91/lisp/org/ob-asymptote
~/git/org-mode/lisp/ob-sql hides /usr/share/emacs/25.0.91/lisp/org/ob-sql
~/git/org-mode/lisp/org-bibtex hides /usr/share/emacs/25.0.91/lisp/org/org-bibtex
~/git/org-mode/lisp/org-src hides /usr/share/emacs/25.0.91/lisp/org/org-src
~/git/org-mode/lisp/ob-sqlite hides /usr/share/emacs/25.0.91/lisp/org/ob-sqlite
~/git/org-mode/lisp/org-mhe hides /usr/share/emacs/25.0.91/lisp/org/org-mhe
~/git/org-mode/lisp/ob-lisp hides /usr/share/emacs/25.0.91/lisp/org/ob-lisp
~/git/org-mode/lisp/ob-makefile hides /usr/share/emacs/25.0.91/lisp/org/ob-makefile
~/git/org-mode/lisp/ob-python hides /usr/share/emacs/25.0.91/lisp/org/ob-python
~/git/org-mode/lisp/org-habit hides /usr/share/emacs/25.0.91/lisp/org/org-habit
~/git/org-mode/lisp/org-archive hides /usr/share/emacs/25.0.91/lisp/org/org-archive
~/git/org-mode/lisp/ob-ledger hides /usr/share/emacs/25.0.91/lisp/org/ob-ledger
~/git/org-mode/lisp/org-crypt hides /usr/share/emacs/25.0.91/lisp/org/org-crypt
~/git/org-mode/lisp/org-list hides /usr/share/emacs/25.0.91/lisp/org/org-list
~/git/org-mode/lisp/org-table hides /usr/share/emacs/25.0.91/lisp/org/org-table
~/git/org-mode/lisp/org-info hides /usr/share/emacs/25.0.91/lisp/org/org-info
~/git/org-mode/lisp/ob-js hides /usr/share/emacs/25.0.91/lisp/org/ob-js
~/git/org-mode/lisp/ox-html hides /usr/share/emacs/25.0.91/lisp/org/ox-html
~/git/org-mode/lisp/ob-ruby hides /usr/share/emacs/25.0.91/lisp/org/ob-ruby
~/git/org-mode/lisp/ox-md hides /usr/share/emacs/25.0.91/lisp/org/ox-md
~/git/org-mode/lisp/ox-latex hides /usr/share/emacs/25.0.91/lisp/org/ox-latex
~/git/org-mode/lisp/ob-fortran hides /usr/share/emacs/25.0.91/lisp/org/ob-fortran
~/git/org-mode/lisp/ox-org hides /usr/share/emacs/25.0.91/lisp/org/ox-org
~/git/org-mode/lisp/ob-css hides /usr/share/emacs/25.0.91/lisp/org/ob-css
~/git/org-mode/lisp/org-rmail hides /usr/share/emacs/25.0.91/lisp/org/org-rmail
~/git/org-mode/lisp/ob-ref hides /usr/share/emacs/25.0.91/lisp/org/ob-ref
~/git/org-mode/lisp/ob-calc hides /usr/share/emacs/25.0.91/lisp/org/ob-calc
~/git/org-mode/lisp/org-inlinetask hides /usr/share/emacs/25.0.91/lisp/org/org-inlinetask
~/git/org-mode/lisp/org-element hides /usr/share/emacs/25.0.91/lisp/org/org-element
~/git/org-mode/lisp/org-docview hides /usr/share/emacs/25.0.91/lisp/org/org-docview
~/git/org-mode/lisp/ox-beamer hides /usr/share/emacs/25.0.91/lisp/org/ox-beamer
~/git/org-mode/lisp/ob-lob hides /usr/share/emacs/25.0.91/lisp/org/ob-lob
~/git/org-mode/lisp/ob-eval hides /usr/share/emacs/25.0.91/lisp/org/ob-eval
~/git/org-mode/lisp/org-protocol hides /usr/share/emacs/25.0.91/lisp/org/org-protocol
~/git/org-mode/lisp/ob-shen hides /usr/share/emacs/25.0.91/lisp/org/ob-shen
~/git/org-mode/lisp/org-entities hides /usr/share/emacs/25.0.91/lisp/org/org-entities
~/git/org-mode/lisp/ox-odt hides /usr/share/emacs/25.0.91/lisp/org/ox-odt
~/git/org-mode/lisp/ob-scheme hides /usr/share/emacs/25.0.91/lisp/org/ob-scheme
~/git/org-mode/lisp/ob-keys hides /usr/share/emacs/25.0.91/lisp/org/ob-keys
~/git/org-mode/lisp/ob-gnuplot hides /usr/share/emacs/25.0.91/lisp/org/ob-gnuplot
~/git/org-mode/lisp/ob-dot hides /usr/share/emacs/25.0.91/lisp/org/ob-dot
~/git/org-mode/lisp/ob-matlab hides /usr/share/emacs/25.0.91/lisp/org/ob-matlab
~/git/org-mode/lisp/org-macro hides /usr/share/emacs/25.0.91/lisp/org/org-macro
~/git/org-mode/lisp/org-footnote hides /usr/share/emacs/25.0.91/lisp/org/org-footnote
~/git/org-mode/lisp/ob-lilypond hides /usr/share/emacs/25.0.91/lisp/org/ob-lilypond
~/git/org-mode/lisp/org-feed hides /usr/share/emacs/25.0.91/lisp/org/org-feed
~/git/org-mode/lisp/org-version hides /usr/share/emacs/25.0.91/lisp/org/org-version
~/git/org-mode/lisp/org-loaddefs hides /usr/share/emacs/25.0.91/lisp/org/org-loaddefs
~/git/org-mode/lisp/org-install hides /usr/share/emacs/25.0.91/lisp/org/org-install
/usr/share/emacs/site-lisp/emms/tq hides /usr/share/emacs/25.0.91/lisp/emacs-lisp/tq
/usr/share/emacs/25.0.91/lisp/emacs-lisp/cl-generic hides /home/wgg/.emacs.d/elpa/cl-generic-0.2/cl-generic

Features:
(shadow nnir emacsbug sendmail debug nnagent nnml hippie-exp
gnus-eform vc vc-dispatcher vc-git flow-fill windmove mpc
character-fold misearch multi-isearch qp gnus-cite shr seq dom subr-x
browse-url mm-archive mail-extr gnus-bcklg gnus-async gnus-ml
gnus-topic utf-7 nndraft nnmh nnfolder nnmaildir gnus-agent gnus-srvr
gnus-score score-mode nnvirtual gnus-msg gnus-art mm-uu mml2015
mm-view mml-smime smime dig nntp gnus-cache gnus-sum gnus-group
gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc
nnoo parse-time gnus-spec gnus-int gnus-range gnus-win gnus gnus-ems
nnheader org org-macro org-footnote org-pcomplete org-list org-faces
org-entities noutline outline org-version ob-emacs-lisp ob ob-tangle
ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint ob-core
ob-eval org-compat org-macs network-stream nsm starttls tls gnutls
epa-file epa cursor-sensor eieio-opt speedbar sb-image ezimage dframe
em-unix em-term term disp-table ehelp em-smart em-script em-prompt
em-ls em-hist em-pred em-glob em-dirs em-cmpl em-basic em-banner
em-alias esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg
esh-groups eshell esh-module esh-mode esh-util view elisp-slime-nav
etags xref project rainbow-delimiters paren whitespace erc-services
erc-autoaway xt-mouse winner type-break shackle magit-wip magit-log
magit-diff smerge-mode diff-mode git-commit log-edit message idna
rfc822 mml mml-sec epg mm-decode mm-bodies mm-encode mail-parse
rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils
mailheader pcvs-util add-log magit-core magit-autorevert autorevert
filenotify magit-process with-editor tramp-sh tramp tramp-compat
tramp-loaddefs trampver ucs-normalize shell magit-popup async-bytecomp
async magit-mode magit-git crm magit-section magit-utils dash
elec-pair org-loaddefs sauron-identica sauron-jabber sauron-twittering
sauron-notifications notifications sauron-org appt diary-lib
diary-loaddefs sauron-dbus dbus sauron-erc erc-list erc-menu erc-join
erc-ring erc-networks erc-pcomplete pcomplete erc-track erc-match
erc-netsplit erc-hl-nicks color erc-button erc-fill erc-stamp
erc-goodies erc erc-backend erc-compat thingatpt sauron pdf-occur
ibuf-ext ibuffer tablist tablist-filter semantic/wisent/comp
semantic/wisent semantic/wisent/wisent semantic/util-modes
semantic/util semantic semantic/tag semantic/lex semantic/fw
mode-local find-func cedet pdf-isearch let-alist pdf-misc imenu
pdf-tools compile comint ansi-color ring cus-edit cus-start cus-load
wid-edit pdf-view bookmark pp jka-compr pdf-cache pdf-info pdf-util
image-mode emms-librefm-stream xml emms-librefm-scrobbler
emms-playlist-limit emms-volume easy-mmode emms-volume-amixer
emms-i18n emms-history emms-score emms-stream-info
emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon
emms-browser sort emms-playlist-sort emms-last-played emms-player-xine
emms-player-mpd tq emms-playing-time emms-lyrics emms-url url
url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util url-parse auth-source gnus-util mm-util help-fns
mail-prsvr password-cache url-vars mailcap emms-streams
emms-tag-editor format-spec emms-mark emms-mode-line emms-cache
emms-info-ogginfo emms-info-mp3info emms-info later-do
emms-playlist-mode emms-player-vlc advice emms-player-mplayer
emms-player-simple emms-source-playlist emms-source-file locate dired
emms-setup emms emms-compat exim xcb-xim xcb-xlib exwm-config exwm
exwm-input xcb-keysyms exwm-manage exwm-floating xcb-cursor xcb-render
exwm-layout exwm-workspace exwm-core derived xcb-ewmh xcb-icccm xcb
xcb-xproto xcb-types cl-seq edmacro kmacro
sanityinc-tomorrow-day-theme color-theme-sanityinc-tomorrow
theme-changer solar cal-dst cal-menu calendar cal-loaddefs cl time
saveplace savehist server finder-inf eieio byte-opt bytecomp
byte-compile cl-extra help-mode cconv info eieio-core cl-macs gv
cl-loaddefs pcase cl-lib package easymenu epg-config time-date
mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel x-win term/common-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment elisp-mode
lisp-mode prog-mode register page menu-bar rfn-eshadow timer select
scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame
cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai
tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian
slovak czech european ethiopic indian cyrillic chinese charscript
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify
dynamic-setting font-render-setting x multi-tty make-network-process
emacs)

Memory information:
((conses 16 1156326 213436)
 (symbols 48 170796 29)
 (miscs 40 2588 4316)
 (strings 32 500490 71057)
 (string-bytes 1 24790744)
 (vectors 16 218420)
 (vector-slots 8 3362630 82340)
 (floats 8 2712 1243)
 (intervals 56 19930 7950)
 (buffers 976 157)
 (heap 1024 234035 29862))

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Lars Ingebrigtsen]

William G. Gardella <wgg2@member.fsf.org> writes:

> On the Emacs 25 pretests, `erc-echo-timestamp' no longer displays a
> timestamp in the echo area when placing point next to each line in a
> buffer. Now the timestamps only appear for the first and last line of
> the buffer. This might be related to the new `cursor-sensor-mode'
> functionality replacing the old implementation, but I am not sure.

Stefan, this seems to be a change you did, and it doesn't seem to work
well.  When you move from the final position in the buffer, erc will
flash a timestamp in the echo area.  But then it never triggers again,
so somethings' off in the cursor-sensor-mode area...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Stefan Monnier]

>> On the Emacs 25 pretests, `erc-echo-timestamp' no longer displays a
>> timestamp in the echo area when placing point next to each line in a
>> buffer. Now the timestamps only appear for the first and last line of
>> the buffer. This might be related to the new `cursor-sensor-mode'
>> functionality replacing the old implementation, but I am not sure.
> Stefan, this seems to be a change you did, and it doesn't seem to work
> well.  When you move from the final position in the buffer, erc will
> flash a timestamp in the echo area.  But then it never triggers again,
> so somethings' off in the cursor-sensor-mode area...

Can you give a step-by-step way to reproduce this problem (for someone
like me who doesn't use ERC)?


        Stefan

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Lars Ingebrigtsen]

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

> Can you give a step-by-step way to reproduce this problem (for someone
> like me who doesn't use ERC)?

First you need to connect to an open IRC server, and that depends on
where you are...  This might work?

(erc :server "us.ircnet.org" :nick "stefantest")

If you manage to connect, then create a channel:

/join #erctest

Then switch the timestamp thing on:

(setq erc-echo-timestamps t)

Then `M-x cursor-sensor-mode' (it's also a bug that you have to say
this, I think?).

And then send something on the channel (by typing whatever RET).  Now if
you put the cursor on the previous line, it'll say

Timestamped Sunday, 14:58:18

which is correct, but if you go further back, then it won't say
anything, and it should echo the timestamp on every line.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Alex Branham]

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

tags 22700 patch
quit

Hi all -

This bug has been open a while, so just a quick reminder:
erc-echo-timestamps does not work except for the first and last
messages.

This is because cursor-sensor--detect doesn't call
cursor-sensor-functions if the text property hasn't changed[1]. Since ERC
applies the property to _all_ of the message, the text property remains
`eq' and so it doesn't get called when it should.

We can fix this in ERC by not applying the text property to the whole
message. I suggest not applying it to the last character. Now whenever
you move point between messages, the timestamp gets echoed. Unless point
winds up at the very end of the line, which is possible if you're moving
from the end of a long message to a short message. Clearly not ideal,
but better than the current situation.

Patch attached.

Thanks,
Alex

Footnotes:
[1]  It's due to these lines in cursor-sensor--detect:

      (if (or (and (null new) (null (cdr old)))
              (and (eq new (cdr old))
                   (eq (next-single-char-property-change
                        start 'cursor-sensor-functions nil end)
                       end)))
          ;; Clearly nothing to do.
          nil



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-erc-echo-timestamps.patch --]
[-- Type: text/x-patch, Size: 1172 bytes --]

From a42814e8922f4bd69e0726a6f05e55e15337c536 Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Tue, 13 Aug 2019 15:30:26 -0500
Subject: [PATCH] Fix erc-echo-timestamps

* lisp/erc/erc-stamp.el (erc-add-timestamp): Use (1- (point-max))
since `cursor-sensor--detect' skips `cursor-sensor-functions' if the
property hasn't changed since the cursor moved.  By not applying the
property to the last character of a message, we're guaranteeing that
the text property changes when we move point to a different ERC
message.

Bug#22700
---
 lisp/erc/erc-stamp.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el
index b48803452a..cbe9fe3e6a 100644
--- a/lisp/erc/erc-stamp.el
+++ b/lisp/erc/erc-stamp.el
@@ -187,7 +187,7 @@ or `erc-send-modify-hook'."
 		 (erc-format-timestamp ct erc-away-timestamp-format)))
       (add-text-properties (point-min) (point-max)
 			   (list 'timestamp ct))
-      (add-text-properties (point-min) (point-max)
+      (add-text-properties (point-min) (1- (point-max))
 			   (list 'cursor-sensor-functions
 				 (list #'erc-echo-timestamp))))))
 
-- 
2.22.0

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Lars Ingebrigtsen]

Alex Branham <alex.branham@gmail.com> writes:

> We can fix this in ERC by not applying the text property to the whole
> message. I suggest not applying it to the last character. Now whenever
> you move point between messages, the timestamp gets echoed. Unless point
> winds up at the very end of the line, which is possible if you're moving
> from the end of a long message to a short message. Clearly not ideal,
> but better than the current situation.

This fix doesn't sound ideal -- if you do it this way, then it'll work
sometimes, and not other times, which sounds perhaps even more annoying.

There must be a different way to get it to work reliably.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Noam Postavsky]

> There must be a different way to get it to work reliably.

Maybe just check in a post-command hook whether the timestamp needs to
be updated?

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Alex Branham]

On Tue 13 Aug 2019 at 18:13, Noam Postavsky <npostavs@gmail.com> wrote:

>> There must be a different way to get it to work reliably.
>
> Maybe just check in a post-command hook whether the timestamp needs to
> be updated?

AFAIR there's no way to reliably check what message (if any) is
currently being displayed though, right?

Thanks,
Alex

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Eli Zaretskii]

> From: Alex Branham <alex.branham@gmail.com>
> Date: Tue, 13 Aug 2019 19:33:40 -0500
> Cc: Lars Ingebrigtsen <larsi@gnus.org>, 22700@debbugs.gnu.org,
>  Stefan Monnier <monnier@IRO.UMontreal.CA>
> 
> AFAIR there's no way to reliably check what message (if any) is
> currently being displayed though, right?

What's wrong with current-message?

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Alex Branham]

[-- Attachment #1: Type: text/plain, Size: 382 bytes --]

On Wed 14 Aug 2019 at 05:40, Eli Zaretskii <eliz@gnu.org> wrote:

>> AFAIR there's no way to reliably check what message (if any) is
>> currently being displayed though, right?
>
> What's wrong with current-message?

I didn't know it existed, that's what's wrong with it!

New patch attached that fixes the issue by hooking erc-echo-timestamp
onto post-command-hook.

Thanks,
Alex


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-erc-echo-timestamps.patch --]
[-- Type: text/x-patch, Size: 3893 bytes --]

From 33f3068fac5b6aad7a01e650f440afcdd965863e Mon Sep 17 00:00:00 2001
From: Alex Branham <alex.branham@gmail.com>
Date: Wed, 14 Aug 2019 08:39:23 -0500
Subject: [PATCH] Fix erc-echo-timestamps

* lisp/erc/erc-stamp.el: Move to lexical binding.
(erc-stamp-mode): Add erc-echo-timestamps to erc-mode-hook.
(erc-add-timestamp, erc-munge-invisibility-spec): Don't rely on
cursor-sensor-functions.
(erc-echo-timestamps): New function to add erc-echo-timestamp to
post-command-hook in ERC buffers.
(erc-echo-timestamp): Modify to not rely on cursor-sensor-functions.

Bug#22700
---
 lisp/erc/erc-stamp.el | 35 +++++++++++++++++++----------------
 1 file changed, 19 insertions(+), 16 deletions(-)

diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el
index b48803452a..18865cab9a 100644
--- a/lisp/erc/erc-stamp.el
+++ b/lisp/erc/erc-stamp.el
@@ -1,4 +1,4 @@
-;;; erc-stamp.el --- Timestamping for ERC messages
+;;; erc-stamp.el --- Timestamping for ERC messages  -*- lexical-binding: t; -*-
 
 ;; Copyright (C) 2002-2004, 2006-2019 Free Software Foundation, Inc.
 
@@ -37,6 +37,9 @@
 (require 'erc)
 (require 'erc-compat)
 
+(eval-when-compile
+  (require 'subr-x))
+
 (defgroup erc-stamp nil
   "For long conversation on IRC it is sometimes quite
 useful to have individual messages timestamp.  This
@@ -163,10 +166,12 @@ stamp
   "This mode timestamps messages in the channel buffers."
   ((add-hook 'erc-mode-hook #'erc-munge-invisibility-spec)
    (add-hook 'erc-insert-modify-hook #'erc-add-timestamp t)
-   (add-hook 'erc-send-modify-hook #'erc-add-timestamp t))
+   (add-hook 'erc-send-modify-hook #'erc-add-timestamp t)
+   (add-hook 'erc-mode-hook #'erc-echo-timestamps))
   ((remove-hook 'erc-mode-hook #'erc-munge-invisibility-spec)
    (remove-hook 'erc-insert-modify-hook #'erc-add-timestamp)
-   (remove-hook 'erc-send-modify-hook #'erc-add-timestamp)))
+   (remove-hook 'erc-send-modify-hook #'erc-add-timestamp)
+   (remove-hook 'erc-mode-hook #'erc-echo-timestamps)))
 
 (defun erc-add-timestamp ()
   "Add timestamp and text-properties to message.
@@ -186,10 +191,7 @@ erc-add-timestamp
 	(funcall erc-insert-away-timestamp-function
 		 (erc-format-timestamp ct erc-away-timestamp-format)))
       (add-text-properties (point-min) (point-max)
-			   (list 'timestamp ct))
-      (add-text-properties (point-min) (point-max)
-			   (list 'cursor-sensor-functions
-				 (list #'erc-echo-timestamp))))))
+			   (list 'timestamp ct)))))
 
 (defvar erc-timestamp-last-inserted nil
   "Last timestamp inserted into the buffer.")
@@ -364,8 +366,6 @@ erc-format-timestamp
 (defun erc-munge-invisibility-spec ()
   (and erc-timestamp-intangible (not (bound-and-true-p cursor-intangible-mode))
        (cursor-intangible-mode 1))
-  (and erc-echo-timestamps (not (bound-and-true-p cursor-sensor-mode))
-       (cursor-sensor-mode 1))
   (if erc-hide-timestamps
       (add-to-invisibility-spec 'timestamp)
     (remove-from-invisibility-spec 'timestamp)))
@@ -399,14 +399,17 @@ erc-toggle-timestamps
 	    (erc-munge-invisibility-spec)))
 	(erc-buffer-list)))
 
-(defun erc-echo-timestamp (window _before dir)
+(defun erc-echo-timestamps ()
+  "Add `erc-echo-timestamp' to `post-command-hook' buffer-locally."
+  (add-hook 'post-command-hook #'erc-echo-timestamp nil t))
+
+(defun erc-echo-timestamp ()
   "Print timestamp text-property of an IRC message."
-  (when (and erc-echo-timestamps (eq 'entered dir))
-    (let* ((now (window-point window))
-	   (stamp (get-text-property now 'timestamp)))
-      (when stamp
-	(message "%s" (format-time-string erc-echo-timestamp-format
-					  stamp))))))
+  (when erc-echo-timestamps
+    (when-let ((stamp (get-text-property (point) 'timestamp))
+	       (message (format-time-string erc-echo-timestamp-format stamp)))
+      (unless (string= message (current-message))
+	(message "%s" message)))))
 
 (provide 'erc-stamp)
 
-- 
2.22.0

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Eli Zaretskii]

> From: Alex Branham <alex.branham@gmail.com>
> Cc: npostavs@gmail.com,  larsi@gnus.org,  22700@debbugs.gnu.org,
>   monnier@IRO.UMontreal.CA
> Date: Wed, 14 Aug 2019 08:49:00 -0500
> 
> >> AFAIR there's no way to reliably check what message (if any) is
> >> currently being displayed though, right?
> >
> > What's wrong with current-message?
> 
> I didn't know it existed, that's what's wrong with it!

That's okay, I'm learning something new about Emacs almost every day ;-)

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Noam Postavsky]

> +  (when erc-echo-timestamps
> +    (when-let ((stamp (get-text-property (point) 'timestamp))
> +	       (message (format-time-string erc-echo-timestamp-format stamp)))
> +      (unless (string= message (current-message))
> +	(message "%s" message)))))

I'm not an erc user, so perhaps it's just expected to be this way, but
this sounds too aggressive to me.  E.g., if you run a command like
describe-key-briefly its message will immediately be replaced by the
timestamp.

I was thinking erc-echo-timestamp would just save the last timestamp it
sent in a buffer-local variable, and then only send a new message if the
current timestamp is different.

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Alex Branham]

On Wed 14 Aug 2019 at 10:56, Noam Postavsky <npostavs@gmail.com> wrote:

>> +  (when erc-echo-timestamps
>> +    (when-let ((stamp (get-text-property (point) 'timestamp))
>> +	       (message (format-time-string erc-echo-timestamp-format stamp)))
>> +      (unless (string= message (current-message))
>> +	(message "%s" message)))))
>
> I'm not an erc user, so perhaps it's just expected to be this way, but
> this sounds too aggressive to me.  E.g., if you run a command like
> describe-key-briefly its message will immediately be replaced by the
> timestamp.

Most of the time we won't be echoing a timestamp since point will be in
the same line as the prompt (i.e. the area where you compose a message).

> I was thinking erc-echo-timestamp would just save the last timestamp it
> sent in a buffer-local variable, and then only send a new message if the
> current timestamp is different.

That's certainly possible to do as well. If others prefer that, I can
write that version up.

Alex

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Stefan Monnier]

> This is because cursor-sensor--detect doesn't call
> cursor-sensor-functions if the text property hasn't changed[1]. Since ERC
> applies the property to _all_ of the message, the text property remains
> `eq' and so it doesn't get called when it should.

How 'bout the patch below which makes the function different on
each message?


        Stefan


diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el
index b48803452a..03ea69ed4f 100644
--- a/lisp/erc/erc-stamp.el
+++ b/lisp/erc/erc-stamp.el
@@ -1,4 +1,4 @@
-;;; erc-stamp.el --- Timestamping for ERC messages
+;;; erc-stamp.el --- Timestamping for ERC messages  -*- lexical-binding:t -*-
 
 ;; Copyright (C) 2002-2004, 2006-2019 Free Software Foundation, Inc.
 
@@ -185,11 +185,10 @@ erc-add-timestamp
 		 (not erc-timestamp-format))
 	(funcall erc-insert-away-timestamp-function
 		 (erc-format-timestamp ct erc-away-timestamp-format)))
-      (add-text-properties (point-min) (point-max)
-			   (list 'timestamp ct))
       (add-text-properties (point-min) (point-max)
 			   (list 'cursor-sensor-functions
-				 (list #'erc-echo-timestamp))))))
+				 (list (lambda (_window _before dir)
+					 (erc-echo-timestamp dir ct))))))))
 
 (defvar erc-timestamp-last-inserted nil
   "Last timestamp inserted into the buffer.")
@@ -399,14 +398,12 @@ erc-toggle-timestamps
 	    (erc-munge-invisibility-spec)))
 	(erc-buffer-list)))
 
-(defun erc-echo-timestamp (window _before dir)
+(defun erc-echo-timestamp (dir stamp)
   "Print timestamp text-property of an IRC message."
   (when (and erc-echo-timestamps (eq 'entered dir))
-    (let* ((now (window-point window))
-	   (stamp (get-text-property now 'timestamp)))
-      (when stamp
-	(message "%s" (format-time-string erc-echo-timestamp-format
-					  stamp))))))
+    (when stamp
+      (message "%s" (format-time-string erc-echo-timestamp-format
+					stamp)))))
 
 (provide 'erc-stamp)
 

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Alex Branham]

On Wed 14 Aug 2019 at 18:50, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

>> This is because cursor-sensor--detect doesn't call
>> cursor-sensor-functions if the text property hasn't changed[1]. Since ERC
>> applies the property to _all_ of the message, the text property remains
>> `eq' and so it doesn't get called when it should.
>
> How 'bout the patch below which makes the function different on
> each message?

Works well unless you C-n/p and point remains inside the same IRC
message. Probably a happy medium between what I suggested and the
problems Noam pointed out though. Should we go ahead and apply this to
master? It's clearly an improvement over what's there now, which doesn't
really work at all.

Thanks,
Alex

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Lars Ingebrigtsen]

Alex Branham <alex.branham@gmail.com> writes:

> Works well unless you C-n/p and point remains inside the same IRC
> message. Probably a happy medium between what I suggested and the
> problems Noam pointed out though. Should we go ahead and apply this to
> master? It's clearly an improvement over what's there now, which doesn't
> really work at all.

I think it makes sense to only display the timestamp if you're moving to
a different message, so Stefan's patch looks good to me.  (Although I
haven't tested it.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Alex Branham]

On Thu 15 Aug 2019 at 16:41, Lars Ingebrigtsen <larsi@gnus.org> wrote:

> Alex Branham <alex.branham@gmail.com> writes:
>
> I think it makes sense to only display the timestamp if you're moving to
> a different message, so Stefan's patch looks good to me.  (Although I
> haven't tested it.)

Sounds good to me. I tested it yesterday for a while and it seems to
work well.

Alex

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Stefan Monnier]

>> How 'bout the patch below which makes the function different on
>> each message?
> Works well

Thanks, pushed.

> unless you C-n/p and point remains inside the same IRC message.

That's "a feature".  Exactly when to echo is a design tradeoff.


        Stefan

bug#22700: 25.0.91; `erc-echo-timestamps' no longer echoes timestamp for each line

[Alex Branham]

tags 22700 fixed
close 22700 
quit

On Mon 19 Aug 2019 at 05:46, Stefan Monnier <monnier@iro.umontreal.ca> wrote:

> Thanks, pushed.

This seems to fix it for me so I'm closing this bug report. Thanks
again, Stefan.

Alex

50dc4ca8d0 2019-08-19T05:44:43-04:00 "* lisp/erc/erc-stamp.el: Fix erc-echo-timestamp (bug#22700)"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=50dc4ca8d02a466a7236765edf83ae7cfb02d74c