From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#31634: emacs 26.1 Compilation error and fix on Solaris 10 Date: Tue, 29 May 2018 11:46:45 +0200 Message-ID: <871sduhjzu.fsf@gmail.com> References: <000301d3f710$d7fc4d10$87f4e730$@orange.fr> <87k1rn3qi3.fsf@igel.home> <000b01d3f71c$2a2d4070$7e87c150$@orange.fr> <87fu2b3oya.fsf@igel.home> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1527587118 13491 195.159.176.226 (29 May 2018 09:45:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 29 May 2018 09:45:18 +0000 (UTC) Cc: 31634@debbugs.gnu.org, Christian Jullien To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 29 11:45:14 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNbBq-0003PV-0S for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 May 2018 11:45:14 +0200 Original-Received: from localhost ([::1]:59859 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNbDw-0002n8-MX for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 May 2018 05:47:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fNbDe-0002kA-00 for bug-gnu-emacs@gnu.org; Tue, 29 May 2018 05:47:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fNbDa-0004D0-IX for bug-gnu-emacs@gnu.org; Tue, 29 May 2018 05:47:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45246) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fNbDa-0004Bv-Ex for bug-gnu-emacs@gnu.org; Tue, 29 May 2018 05:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fNbDa-00028b-58 for bug-gnu-emacs@gnu.org; Tue, 29 May 2018 05:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 May 2018 09:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31634 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31634-submit@debbugs.gnu.org id=B31634.15275872168204 (code B ref 31634); Tue, 29 May 2018 09:47:02 +0000 Original-Received: (at 31634) by debbugs.gnu.org; 29 May 2018 09:46:56 +0000 Original-Received: from localhost ([127.0.0.1]:53143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNbDU-00028G-CI for submit@debbugs.gnu.org; Tue, 29 May 2018 05:46:56 -0400 Original-Received: from mail-wr0-f175.google.com ([209.85.128.175]:46962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fNbDR-000281-Lj for 31634@debbugs.gnu.org; Tue, 29 May 2018 05:46:54 -0400 Original-Received: by mail-wr0-f175.google.com with SMTP id v13-v6so12671681wrp.13 for <31634@debbugs.gnu.org>; Tue, 29 May 2018 02:46:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:mail-copies-to:gmane-reply-to-list :date:in-reply-to:message-id:mime-version; bh=G8clJNCuQ77kzi4LB7+pvEJNCR1Tnosv2gDEfBRGUAo=; b=SsHgmTSgau4VzI3fF9PZhasxDYM2YGFieghHkPBr54Xofk7KLWIPdY49tUEgHSnJq7 dyiWLLfPBHJwx3xT9P2zzUEi+YFG/lBsN4oRwiLv0kFhALLz/KLex7lE7nXpk4kbVImL iS8ZMFax06riRDhqEUOO/UHN36l74W1lrT9HeGlHsBx5X36PvKIozv3GiXazWuox+hhk pdywvldQNpEApfXeeixP7L8jTF/sB8psElOONhL02pt2azz6csa8zdLfngAr0q1TvXE4 2vKjneJV5h9uQ+ucf3jkof6ZE+CurJUHBKIrWmQUyGATuad+6G4fEfWFDAeFpK2junb4 hMkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:mime-version; bh=G8clJNCuQ77kzi4LB7+pvEJNCR1Tnosv2gDEfBRGUAo=; b=Q5e2BdCuqfvh+flf8Ypdqt06MDbV5G8WZUr7K0jANsTdPRSuCkFBg38SxM0V5Zvm9c 6y24O/pwLyh5izrD9vmM3hCRqVnNmCeE2/OTGgJtnGrMRzWV3+e2vVw07yphNW3gnr5g enfUZTG5SE73uZlIGNftr9YYNDyWhJ7dzapeL4WDXDFhR5sOIZg01sgYQNeC3pYXw4en YNRBBh0qT3xK/Ox3GPBKmfv670D8zQgo+sLs7jgCQAEScRetvhDjQQjauV7DmwG9I6wb lsroO1rCA+EX0qdzE1xZmZz0Y82CXC0m/7pQRFDRnJdcOUVJ7W6GyVDTeIUEQwuE/fxB 5WbA== X-Gm-Message-State: ALKqPwfO4CpTVJLJo2go9JsFQPLup4uAPq6vL6d7bLGyuwrLfY3y1MDj uIkq4+X41CsUA1ZgBaz3sYPl5ARdFQI= X-Google-Smtp-Source: ADUXVKIJ2Op6PHK1te+6tfyi06Ow3IumxlJbJp3Sbnb1PuIQmT5ioRex9Rsik3No/w/E0vuLrTsrtA== X-Received: by 2002:adf:ea44:: with SMTP id j4-v6mr3444024wrn.224.1527587207319; Tue, 29 May 2018 02:46:47 -0700 (PDT) Original-Received: from rpluim ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id m64-v6sm27722633wmb.12.2018.05.29.02.46.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 May 2018 02:46:46 -0700 (PDT) Mail-Copies-To: never Gmane-Reply-To-List: yes In-Reply-To: <87fu2b3oya.fsf@igel.home> (Andreas Schwab's message of "Tue, 29 May 2018 09:23:25 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146682 Archived-At: Andreas Schwab writes: > On Mai 29 2018, "Christian Jullien" wrote: > >> The result of configure gives config.h with XFT feature: >> >> /* Summary of some of the main features enabled by configure. */ >> #define EMACS_CONFIG_FEATURES "XPM JPEG TIFF PNG ACL FREETYPE XFT >> TOOLKIT_SCROLL_BARS LUCID X11 THREADS" >> >> But later in this file, it gives >> >> /* Define to 1 if you have the Xft library. */ >> /* #undef HAVE_XFT */ > > Looks like there is a logic error in configure, failing to reset > HAVE_XFT to no if Xrender is missing. Indeed. Christian, could you try the following patch? (you'll need to regenerate configure and re-run it). diff --git i/configure.ac w/configure.ac index c66c80adbb..c6101d6353 100644 --- i/configure.ac +++ w/configure.ac @@ -3210,8 +3210,8 @@ AC_DEFUN if test "x${with_xft}" != "xno"; then EMACS_CHECK_MODULES([XFT], [xft >= 0.13.0], [], [HAVE_XFT=no]) - ## Because xftfont.c uses XRenderQueryExtension, we also - ## need to link to -lXrender. + ## Because xterm.c uses XRenderQueryExtension when XFT is + ## enabled, we also need to link to -lXrender. HAVE_XRENDER=no AC_CHECK_LIB(Xrender, XRenderQueryExtension, HAVE_XRENDER=yes) if test "$HAVE_XFT" != no && test "$HAVE_XRENDER" != no; then @@ -3234,6 +3234,9 @@ AC_DEFUN CPPFLAGS=$OLD_CPPFLAGS CFLAGS=$OLD_CFLAGS LIBS=$OLD_LIBS + else + # Make sure XFT is disabled if we found XFT but not XRender + HAVE_XFT=no fi # "$HAVE_XFT" != no fi # "x${with_xft}" != "xno"