unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Raimon Grau <raimonster@gmail.com>
To: 32028@debbugs.gnu.org
Subject: bug#32028: Fix thingatpt url's beginning-op
Date: Sun, 01 Jul 2018 23:56:37 +0100	[thread overview]
Message-ID: <871scmsgyi.fsf@raikong.i-did-not-set--mail-host-address--so-tickle-me> (raw)

[-- Attachment #1: Type: text/plain, Size: 405 bytes --]

Hello,

I found a small bug in thingatpt.el. `beginning-op' for url's was using
an incorrect helper (end-of-thing) and changed it to the correct one.

This is my first time sending a patch to this list so I might be missing
something or doing something wrong wrt process.  If that's the case,
apologises in advance.  (My fsf papers are signed, so there's no problem
on that regard)

Cheers,

Raimon Grau


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-url-s-thing-at-point-beginning-op.patch --]
[-- Type: text/x-diff, Size: 1258 bytes --]

From e725d737ea4bc5bb8545a10866ac59986c450d12 Mon Sep 17 00:00:00 2001
From: Raimon Grau <raimonster@gmail.com>
Date: Sun, 1 Jul 2018 21:31:08 +0100
Subject: [PATCH] Fix url's thing-at-point beginning-op

* lisp/thingatpt.el (url): Fix beginning-op making.
---
 ChangeLog.3       | 6 ++++++
 lisp/thingatpt.el | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/ChangeLog.3 b/ChangeLog.3
index 6704d0d..8d0a5dd 100644
--- a/ChangeLog.3
+++ b/ChangeLog.3
@@ -1,3 +1,9 @@
+2018-07-01 Raimon Grau <raimonster@gmail.com>
+
+	Fix url's thing-at-point beginning-op
+
+	* lisp/thingatpt.el (url): Fix beginning-op making.
+
 2018-05-25  Noam Postavsky  <npostavs@gmail.com>
 
 	Note caveat for backward regexp searching in docstring (Bug#31584)
diff --git a/lisp/thingatpt.el b/lisp/thingatpt.el
index 4612e95..7fcb3bc 100644
--- a/lisp/thingatpt.el
+++ b/lisp/thingatpt.el
@@ -484,7 +484,7 @@ thing-at-point-newsgroup-p
 
 (put 'url 'end-op (lambda () (end-of-thing 'url)))
 
-(put 'url 'beginning-op (lambda () (end-of-thing 'url)))
+(put 'url 'beginning-op (lambda () (beginning-of-thing 'url)))
 
 ;; The normal thingatpt mechanism doesn't work for complex regexps.
 ;; This should work for almost any regexp wherever we are in the
-- 
2.7.4


             reply	other threads:[~2018-07-01 22:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-01 22:56 Raimon Grau [this message]
2018-07-29 18:34 ` bug#32028: Fix thingatpt url's beginning-op Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871scmsgyi.fsf@raikong.i-did-not-set--mail-host-address--so-tickle-me \
    --to=raimonster@gmail.com \
    --cc=32028@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).