unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 32093@debbugs.gnu.org, dak@gnu.org, michael.albinus@gmx.de
Subject: bug#32093: 27.0.50; M-x grep appends /dev/null to command line
Date: Tue, 10 Jul 2018 18:04:58 -0400	[thread overview]
Message-ID: <871scad9x1.fsf@gmail.com> (raw)
In-Reply-To: <834lh7gk5u.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 10 Jul 2018 18:55:25 +0300")

On 10 July 2018 at 11:55, Eli Zaretskii <eliz@gnu.org> wrote:

> But that was just a suggestion.  I see Paul decided to continue using
> etc/HELLO, just with a different search patterns.  If we are OK with
> that, we can put that issue to rest.

Yeah, I don't think it really matters whether we search etc/HELLO or README.

> We could even take one more step back and ask ourselves why do we need
> this particular test.  I believe it's because we want to support file
> names with embedded newlines, in which case perhaps such niche use
> cases could be supported by a special command or a special user
> option?

I don't think it's about newlines in filenames (in fact,
grep-regexp-alist doesn't support that regardless).  As far as I can
tell, the HELLO test is checking whether we can pass -H to get the
filename together with the matches, or if we need to pass multiple files
to do that.

To do without -H, we would need to handle matches in both formats which
would make the matching regexp more complicated, and we would need to be
able to extract the filename from the shell command that the user types
in.  That would be quite difficult to do correctly in general.





  reply	other threads:[~2018-07-10 22:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-08  9:33 bug#32093: 27.0.50; M-x grep appends /dev/null to command line David Kastrup
2018-07-08  9:51 ` Michael Albinus
2018-07-08  9:53   ` David Kastrup
2018-07-08 10:05     ` Michael Albinus
2018-07-08 11:17       ` David Kastrup
2018-07-08 12:19         ` Noam Postavsky
2018-07-08 12:30           ` David Kastrup
2018-07-08 19:04           ` Eli Zaretskii
2018-07-08 19:11             ` David Kastrup
2018-07-09 21:43             ` Noam Postavsky
2018-07-10  7:33               ` David Kastrup
2018-07-10 15:55               ` Eli Zaretskii
2018-07-10 22:04                 ` Noam Postavsky [this message]
2018-07-09 23:10             ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871scad9x1.fsf@gmail.com \
    --to=npostavs@gmail.com \
    --cc=32093@debbugs.gnu.org \
    --cc=dak@gnu.org \
    --cc=eliz@gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).