unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#34776: 27.0.50; Some questions about choose-completion-string-functions
@ 2019-03-06 23:05 Eric Abrahamsen
       [not found] ` <handler.34776.B.155191354931988.ack@debbugs.gnu.org>
  0 siblings, 1 reply; 17+ messages in thread
From: Eric Abrahamsen @ 2019-03-06 23:05 UTC (permalink / raw)
  To: 34776


I'm trying to use `choose-completion-string-functions' to do some
"stuff" after the user finishes a completion, and have two questions:

1. The docstring of this variable says it is called with three
   arguments, but in fact it's called with four: the fourth is passed as
   nil, and is only there for backward compatibility, apparently. But
   still, you can't use a function that only accepts three args. I can
   provide a patch for the docstring if this is correct.
2. The code in `choose-completion-string' behaves as though the above
   variable is buffer local, but it is never declared to be so. I'm not
   sure if this is a bug (ie, we should be using `defvar-local'), or
   whether I should be adding functions here using the (local 'SYMBOL)
   convention of `add-function'. If that's the case, that's probably
   also a docstring bug, as we should warn users that they'll want to
   specify a local variable.

WDYT?

Eric





^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2019-04-10  8:48 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-06 23:05 bug#34776: 27.0.50; Some questions about choose-completion-string-functions Eric Abrahamsen
     [not found] ` <handler.34776.B.155191354931988.ack@debbugs.gnu.org>
2019-03-09  0:05   ` bug#34776: Acknowledgement (27.0.50; Some questions about choose-completion-string-functions) Eric Abrahamsen
2019-03-09  2:07     ` Glenn Morris
2019-03-13 16:51       ` Eric Abrahamsen
2019-04-10  0:03         ` Noam Postavsky
2019-04-10  3:16           ` Eric Abrahamsen
2019-04-10  3:29           ` Glenn Morris
2019-04-10  4:33             ` Eli Zaretskii
2019-04-10  6:35               ` Eric Abrahamsen
2019-04-10  7:01                 ` Eli Zaretskii
2019-04-10  7:22                   ` Eric Abrahamsen
2019-04-10  7:29                     ` Eric Abrahamsen
2019-04-10  8:24                     ` Eli Zaretskii
2019-04-10  8:05               ` Andreas Schwab
2019-04-10  8:22                 ` Eli Zaretskii
2019-04-10  8:39                   ` Andreas Schwab
2019-04-10  8:48                     ` Eli Zaretskii

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).