From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Federico Tedin Newsgroups: gmane.emacs.bugs Subject: bug#34065: 26.1; Make edebug-eval-expression support code completion Date: Tue, 12 Mar 2019 20:14:46 -0300 Message-ID: <871s3b65y1.fsf@gmail.com> References: <8736poyt0g.fsf@gmail.com> <3031611550637473@sas1-19a94364928d.qloud-c.yandex.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="227062"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: "34065@debbugs.gnu.org" <34065@debbugs.gnu.org> To: mail@xuchunyang.me Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Mar 13 00:23:46 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h3qkL-000wub-6T for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Mar 2019 00:23:45 +0100 Original-Received: from localhost ([127.0.0.1]:34942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3qkK-0003G5-3s for geb-bug-gnu-emacs@m.gmane.org; Tue, 12 Mar 2019 19:23:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51880) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h3qhv-0001UQ-Rr for bug-gnu-emacs@gnu.org; Tue, 12 Mar 2019 19:21:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h3qbw-0000U6-MY for bug-gnu-emacs@gnu.org; Tue, 12 Mar 2019 19:15:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55511) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h3qbu-0000TB-P4 for bug-gnu-emacs@gnu.org; Tue, 12 Mar 2019 19:15:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h3qbu-0007wU-Fu for bug-gnu-emacs@gnu.org; Tue, 12 Mar 2019 19:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Federico Tedin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 12 Mar 2019 23:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34065 X-GNU-PR-Package: emacs Original-Received: via spool by 34065-submit@debbugs.gnu.org id=B34065.155243249830507 (code B ref 34065); Tue, 12 Mar 2019 23:15:02 +0000 Original-Received: (at 34065) by debbugs.gnu.org; 12 Mar 2019 23:14:58 +0000 Original-Received: from localhost ([127.0.0.1]:40822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3qbq-0007vz-6c for submit@debbugs.gnu.org; Tue, 12 Mar 2019 19:14:58 -0400 Original-Received: from mail-qt1-f169.google.com ([209.85.160.169]:37702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1h3qbo-0007vj-HH for 34065@debbugs.gnu.org; Tue, 12 Mar 2019 19:14:56 -0400 Original-Received: by mail-qt1-f169.google.com with SMTP id z17so4678546qtn.4 for <34065@debbugs.gnu.org>; Tue, 12 Mar 2019 16:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=iD4QJM0YTWAoRRnujix+NKieQLfS+joe0snFKePEk5k=; b=Qyp5c2vs63zjjZP/nG4MAB2TJmKw4i+a6B/BxKP2KAjXoANH/BG+B6HFLjxVelppC0 rsNEI859a/UTwQ/fZNghn+08UKxlcXFf8KPJbrIVltlWzDTB52ATfTE8+H7/BXAuKw1a +0o9+YKg/vYe7VFDQEYtj7nuEMxQ+ETF+JAfibOAP6+UXi2nWn850kenJTFjDKYzkCD5 wJ8zHSgV/fc8s3ZqDG6E5ITsgyd7mRbd0fXWc5MzuUtPWf1D6j4XUSNYRcs3j8Fj0vvZ neCcVn2MdXdtg2ckhuYS3iyR54Kajs2UCrA74gsIvUN4aGEN+P4ip/q6TKuTX91BFOTt 6WkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=iD4QJM0YTWAoRRnujix+NKieQLfS+joe0snFKePEk5k=; b=rCiFCpA7FI3s7oU0OIaHhMB7U4FYgIl+Tl4sS+8wqPydTKXScS8ob1BmjDANuDT8zd VQZtBFnbLDUeeGDYEj2c3A/gDrNgGABfxPHE+rIWSXOyvkt8ws1TLeLZOruR2qEiNlhX efgbuV6tXhvp+O5bPkDHe+clCY/wMvj4THmBxOlx6tnh3ueKZELhy4MPLL3I8+PTA4jZ /nLLN8IrV9EVq3hiNc5VSuw4pv6eF8orcnwPMwXN8PZZ9j/c3NiHs0gFwikbsVdXvUOB +kq2d5Mbwa83Xj1Ut5ISneGrstaKMUyiD3FdlLQP79031CksZWX7kGnET9DGQrJ589hq o++A== X-Gm-Message-State: APjAAAXrzJGbYHj5kXZ0IegmFGEUvPG7EWQgWdFHqM8KtQHksxfidiMA iuvyNpKnG1K8Hpkz82Vzpy8K0URq9kA= X-Google-Smtp-Source: APXvYqxg29xhdzY3BtLEqyfVonJR4W4sMaz7bEj8wp2VtaACnED5jofiOa9LdPPcRk6kYJfug+rM1w== X-Received: by 2002:ac8:465a:: with SMTP id f26mr14250104qto.260.1552432490472; Tue, 12 Mar 2019 16:14:50 -0700 (PDT) Original-Received: from hideo ([181.170.211.157]) by smtp.gmail.com with ESMTPSA id i65sm10292763qki.32.2019.03.12.16.14.48 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 12 Mar 2019 16:14:49 -0700 (PDT) In-Reply-To: <3031611550637473@sas1-19a94364928d.qloud-c.yandex.net> (mail's message of "Wed, 20 Feb 2019 12:37:53 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:156282 Archived-At: --=-=-= Content-Type: text/plain > I'm not a maintainer. Your patch looks good to me. Today I notice it's > possible to change the interactive form via Advising Functions, so I > plan to put the following to my init file until the patch is applied. > > (define-advice edebug-eval-expression (:before (_expr) better-interactive-form) > "Fix the original interactive form." > (interactive (list (read--expression "Edebug Eval: ")))) Great! I'm attaching a more complete patch with a ChangeLog-style message. If a maintainer doesn't pick it up after some days, I'll try messaging emacs-devel. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=edebug.patch Content-Description: patch >From cd03509c544455b746a61550c57476ddddae6a3f Mon Sep 17 00:00:00 2001 From: Federico Tedin Date: Tue, 12 Mar 2019 20:06:49 -0300 Subject: [PATCH 1/1] Make edebug-eval-expression support code completion * lisp/emacs-lisp/edebug.el (edebug-eval-expression): Use read--expression instead of read-from-minibuffer. (Bug#34065) --- lisp/emacs-lisp/edebug.el | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index 2cd8e48d6e..8b4cb1adc7 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -3602,9 +3602,7 @@ edebug-eval-expression "Evaluate an expression in the outside environment. If interactive, prompt for the expression. Print result in minibuffer." - (interactive (list (read-from-minibuffer - "Eval: " nil read-expression-map t - 'read-expression-history))) + (interactive (list (read--expression "Eval: "))) (princ (edebug-outside-excursion (setq values (cons (edebug-eval expr) values)) -- 2.17.1 --=-=-=--