bug#34065: 26.1; Make edebug-eval-expression support code completion

[Federico Tedin <federicotedin@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

> I'm not a maintainer. Your patch looks good to me. Today I notice it's
> possible to change the interactive form via Advising Functions, so I
> plan to put the following to my init file until the patch is applied.
>
> (define-advice edebug-eval-expression (:before (_expr) better-interactive-form)
>   "Fix the original interactive form."
>   (interactive (list (read--expression "Edebug Eval: "))))

Great! I'm attaching a more complete patch with a ChangeLog-style
message. If a maintainer doesn't pick it up after some days, I'll try
messaging emacs-devel.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1063 bytes --]

From cd03509c544455b746a61550c57476ddddae6a3f Mon Sep 17 00:00:00 2001
From: Federico Tedin <federicotedin@gmail.com>
Date: Tue, 12 Mar 2019 20:06:49 -0300
Subject: [PATCH 1/1] Make edebug-eval-expression support code completion

* lisp/emacs-lisp/edebug.el (edebug-eval-expression): Use
  read--expression instead of read-from-minibuffer. (Bug#34065)
---
 lisp/emacs-lisp/edebug.el | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el
index 2cd8e48d6e..8b4cb1adc7 100644
--- a/lisp/emacs-lisp/edebug.el
+++ b/lisp/emacs-lisp/edebug.el
@@ -3602,9 +3602,7 @@ edebug-eval-expression
   "Evaluate an expression in the outside environment.
 If interactive, prompt for the expression.
 Print result in minibuffer."
-  (interactive (list (read-from-minibuffer
-		      "Eval: " nil read-expression-map t
-		      'read-expression-history)))
+  (interactive (list (read--expression "Eval: ")))
   (princ
    (edebug-outside-excursion
     (setq values (cons (edebug-eval expr) values))
-- 
2.17.1