From: Michael Albinus <michael.albinus@gmx.de>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 33225@debbugs.gnu.org, "garreau, alexandre" <galex-713@galex-713.eu>
Subject: bug#33225: [debbugs.el] Don't send control message immediately
Date: Mon, 01 Apr 2019 16:52:17 +0200 [thread overview]
Message-ID: <871s2ln5ge.fsf@gmx.de> (raw)
In-Reply-To: <87imvxj1d2.fsf@gmail.com> (Noam Postavsky's message of "Mon, 01 Apr 2019 09:34:17 -0400")
Noam Postavsky <npostavs@gmail.com> writes:
Hi Noam,
>> I'd prefer if you would commit your changes so far, that we have a
>> common base, and further patches you'll show are shorter (to review).
>
> Yes, I would open a new bug thread for the feature I mention above,
> after this is one is closed and pushed.
OK.
>>> +@item found
>>> +@itemx notfound
>>> +@itemx fixed
>>> +"found|notfound|fixed 12345 25.1"
>>
>> Please add notfixed.
>
> Done. Hmm, I just noticed that we have "@itemx fixed" in two places.
> So there is a conflict between "fixed" as a tag, and "fixed" as its own
> command. I think the command should precedence (that was already the
> case in the code for previous patches, now I've updated the doc as
> well).
OK.
> One last thing I noticed when byte-compiling from emacs -Q, is that I
> needed to add a couple of autoloads for the message functions. And then
> I realized that the message-narrow-to-head call should actually be
> message-narrow-to-headers, since the latter looks for
> mail-header-separator, while the former just looks for a blank line (in
> practice, it doesn't make much difference unless the message body
> happens to have text that looks like a mail header).
That was also on my todo list. I'm glad if you fix it (but, as finical
German, I prefer to insert them in alphabetical order).
There's nothing left I could nitpick, so pls commit :-)
Thanks, and best regards, Michael.
next prev parent reply other threads:[~2019-04-01 14:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 12:29 bug#33225: [debbugs.el] Don't send control message immediately Noam Postavsky
2018-11-01 14:28 ` Garreau, Alexandre
2018-11-02 10:30 ` Michael Albinus
2018-11-02 10:23 ` Michael Albinus
2019-01-04 14:38 ` Michael Albinus
2019-02-27 8:45 ` Michael Albinus
2019-02-28 1:10 ` Noam Postavsky
2019-02-28 7:10 ` Michael Albinus
2019-03-30 2:43 ` Noam Postavsky
2019-03-31 10:21 ` Michael Albinus
2019-03-31 21:27 ` Noam Postavsky
2019-04-01 7:35 ` Michael Albinus
2019-04-01 13:34 ` Noam Postavsky
2019-04-01 14:52 ` Michael Albinus [this message]
2019-04-01 22:47 ` Noam Postavsky
2019-04-01 22:59 ` Noam Postavsky
2019-04-02 5:52 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s2ln5ge.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=33225@debbugs.gnu.org \
--cc=galex-713@galex-713.eu \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).