From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#34341: 26.1; url-retrieve-synchronously returns blank buffer Date: Sat, 04 May 2019 11:18:30 -0400 Message-ID: <871s1ent89.fsf@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="235745"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 34341@debbugs.gnu.org To: Laurent Charignon Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 04 17:19:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hMwRW-000z67-Ke for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 17:19:14 +0200 Original-Received: from localhost ([127.0.0.1]:57819 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMwRV-0007Dp-Jg for geb-bug-gnu-emacs@m.gmane.org; Sat, 04 May 2019 11:19:13 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:33760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMwRP-0007Dh-I9 for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 11:19:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMwRL-0002wn-1i for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 11:19:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38442) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMwRK-0002wc-RG for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 11:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hMwRK-0008UN-JY for bug-gnu-emacs@gnu.org; Sat, 04 May 2019 11:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 May 2019 15:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34341 X-GNU-PR-Package: emacs Original-Received: via spool by 34341-submit@debbugs.gnu.org id=B34341.155698312032601 (code B ref 34341); Sat, 04 May 2019 15:19:02 +0000 Original-Received: (at 34341) by debbugs.gnu.org; 4 May 2019 15:18:40 +0000 Original-Received: from localhost ([127.0.0.1]:51986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMwQy-0008Tl-1r for submit@debbugs.gnu.org; Sat, 04 May 2019 11:18:40 -0400 Original-Received: from mail-qt1-f193.google.com ([209.85.160.193]:34367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hMwQw-0008TW-PK for 34341@debbugs.gnu.org; Sat, 04 May 2019 11:18:39 -0400 Original-Received: by mail-qt1-f193.google.com with SMTP id j6so10140399qtq.1 for <34341@debbugs.gnu.org>; Sat, 04 May 2019 08:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FodtgcxRQBSqHjV4nJIF3jXMK9xJguwLo6nTVU5cofk=; b=W/shH0iWOlbLVodpZNtKGOUKlmKiD264EIrpai0Ttjhr7TOKmdUCUAvAL+MDfyBdOJ rU14cgPCaZWGje7gV0DM1rGOaSxYPzLkEkrjDObZ6g3FbPe7un9NyTu7avucfoj8w/jA S+7WARbOs3n4JjXoWNpcfX43UbuE/6Tn6GLimqqC6WrN4zBfNOvFHuFvEzSubXHab5eW Jd39tWWEE+cjKafGq8yIsRmvHQ/ILsWiQu5gL+cCpiHbpxp7kroPDAVzZ3NQueHxVbiL Q7NXr1+yQdWh0T2NERyJUsFAFdIOVF2/7SKajg7GK/hVuCK5nWCfUD0fghmtmgbNsKE3 KfAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FodtgcxRQBSqHjV4nJIF3jXMK9xJguwLo6nTVU5cofk=; b=mXaobVuver87lo7eFreXmNkFx2IXCsyX8ti39ITKek8S+GH0F2XpbKGnWj3OVAIH57 TthXdoRRKOy0hgLms1Do1sIX2x8WgGcuY37seB3RVcdy/QrV4abxBs3HpgEg02YtW/uG r6hnPjQUiQ6PD2TxcbJ6pK/3XbDsKwZhTdelAg3R9aSAAnApAJ3z+E2fRcNc4a/76/H1 72PuqWfY2FtJVt/nWVH9MlrQVLoDZu5u9UdZq7QK7dZD7N0V4nAhczh4fc43VY2nxf0Q 9Ctnly9PjVhbRqzpAYITTSoVY/nHUv3pPs3Zxx3sztzphtOZFLxu767GIMpJAsA5vE5m a7ug== X-Gm-Message-State: APjAAAWZTfr/Gy+7MG/GLZiRUOOWT8trIBNO/PXZmMukrRJO1AlYaH0Z RNNzwovAkDy6YR9R6iLbukYWnmV7 X-Google-Smtp-Source: APXvYqwMOdztgxIq0/hnz+241Gl0YGzok0OUuggakCavnoDFPWG68pJnJE2wtfvzb+fscuvzPYC1Wg== X-Received: by 2002:aed:25f7:: with SMTP id y52mr14196641qtc.247.1556983113057; Sat, 04 May 2019 08:18:33 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c9sm3026439qkb.86.2019.05.04.08.18.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 04 May 2019 08:18:31 -0700 (PDT) In-Reply-To: (Laurent Charignon's message of "Tue, 5 Feb 2019 20:55:11 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158743 Archived-At: Laurent Charignon writes: > #### Context > > The symptom of this issue first came up in the context of `ghub`, a package > that offers interfacing with Github from emacs (issue: > https://github.com/magit/ghub/issues/81). > > Multiple users of the `ghub` package started observing that > synchronously retrieving content from the github API through ghub > returned blank responses. > (switch-to-buffer (url-retrieve-synchronously " > https://api.github.com/users/charignon/repos") > (buffer-string)) > From bisecting, I know that the fix is in between 191a5568db (working) and > 2a3bd6798e96708 (not working). It is hard to pinpoint further due to > segfaults that were introduced then fixed in this range. My best guess is > that "Fix unlikely races with GnuTLS, datagrams" (e87e6a24c4) resolved this. I can confirm that cherrypicking this commit fixes the problem on my Arch box which has gnutls 3.6.7 (doesn't occur at all on my Debian box with gnutls 3.5.8). Since the only recourse for users hitting is rebuilding --without-gnutls or (advice-add 'gnutls-available-p :override #'ignore) which falls back to the obsolete tls.el, I'd say this is important enough to backport to emacs-26. I'll do that in a couple of days if there are no objections.