From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#33992: 27.0.50; xref-find-definitions wastes too much space Date: Tue, 28 May 2019 23:35:16 +0300 Organization: LINKOV.NET Message-ID: <871s0ifj1k.fsf@mail.linkov.net> References: <87muoe7jrs.fsf@mail.linkov.net> <87a7hp43a5.fsf@mail.linkov.net> <205acda7-07a3-d85c-378c-c178f9f76b55@yandex.ru> <87o95l4ht4.fsf@mail.linkov.net> <64f42172-460f-a633-1c80-23d34b5c0d07@yandex.ru> <87lg0m96bm.fsf@mail.linkov.net> <87ftpfqvvg.fsf@mail.linkov.net> <437558cf-3bd5-a6c7-e9d7-d22a87064d78@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="12383"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 33992-done@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 28 22:48:32 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hVj1I-0002yE-8W for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 May 2019 22:48:28 +0200 Original-Received: from localhost ([127.0.0.1]:42540 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVj1H-00012y-8a for geb-bug-gnu-emacs@m.gmane.org; Tue, 28 May 2019 16:48:27 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVj14-00011n-8C for bug-gnu-emacs@gnu.org; Tue, 28 May 2019 16:48:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVj0y-0007Zw-KB for bug-gnu-emacs@gnu.org; Tue, 28 May 2019 16:48:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVj0t-0007W5-Pd for bug-gnu-emacs@gnu.org; Tue, 28 May 2019 16:48:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVj0t-0006Ik-Ni for bug-gnu-emacs@gnu.org; Tue, 28 May 2019 16:48:03 -0400 Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 May 2019 20:48:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 33992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 33992@debbugs.gnu.org, juri@linkov.net, juri@linkov.net Original-Received: via spool by 33992-done@debbugs.gnu.org id=D33992.155907644524140 (code D ref 33992); Tue, 28 May 2019 20:48:03 +0000 Original-Received: (at 33992-done) by debbugs.gnu.org; 28 May 2019 20:47:25 +0000 Original-Received: from localhost ([127.0.0.1]:57320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVj0H-0006HE-7b for submit@debbugs.gnu.org; Tue, 28 May 2019 16:47:25 -0400 Original-Received: from common.maple.relay.mailchannels.net ([23.83.214.38]:2820) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hVj0D-0006Gv-5H for 33992-done@debbugs.gnu.org; Tue, 28 May 2019 16:47:21 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 0E2CC1438A3; Tue, 28 May 2019 20:47:20 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (100-96-87-96.trex.outbound.svc.cluster.local [100.96.87.96]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 66A321437D1; Tue, 28 May 2019 20:47:19 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.2); Tue, 28 May 2019 20:47:20 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Celery-Spicy: 31484798411821f4_1559076439887_426017321 X-MC-Loop-Signature: 1559076439887:3310718220 X-MC-Ingress-Time: 1559076439886 Original-Received: from pdx1-sub0-mail-a6.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTP id 0C7B7801A1; Tue, 28 May 2019 13:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=wVDPGe4RfknWI3be/oTrUWJJbO0=; b= ckqdpojEnJb0MnNrbIYD8C0oUWOFNuFNlwPRtcnj+b5DUvC2UOnfPQdIk4tbudz0 IuUig4N3GqXXaYdsLXOsBIVhoOoUjrU2u6/wP+fqMeXkdWTctJXJsWzaokJrFiLr thNiBhZocBekHuUCpRP01nb9+C1ocpOATuUo2ZIBt2M= Original-Received: from mail.jurta.org (m91-129-96-73.cust.tele2.ee [91.129.96.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a6.g.dreamhost.com (Postfix) with ESMTPSA id B84E08019B; Tue, 28 May 2019 13:47:09 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a6 In-Reply-To: <437558cf-3bd5-a6c7-e9d7-d22a87064d78@yandex.ru> (Dmitry Gutov's message of "Thu, 16 May 2019 01:37:53 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduuddruddvhedgudehfecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdfftffgtefojffquffvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffuohhfffgjkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqnecukfhppeeluddruddvledrleeirdejfeenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrdeliedrjeefpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehlihhnkhhovhdrnhgvtheqpdhmrghilhhfrhhomhepjhhurhhisehlihhnkhhovhdrnhgvthdpnhhrtghpthhtohepughguhhtohhvseihrghnuggvgidrrhhunecuvehluhhsthgvrhfuihiivgepvd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:159862 Archived-At: >> A patch is proposed in a separate bug#35737. I'm closing this request because now xref is customizable enough. And we have no more opinions for changing the default behavior. FWIW, this is what I currently use to customize xref-find-definitions to act more like Completions: (custom-set-variables '(display-buffer-alist '((display-buffer-to-xref-p display-buffer-in-direction (direction . below) (window-height . fit-window-to-buffer))))) (defun display-buffer-to-xref-p (buffer-name _action) (and (string-match-p "\\`\\*\\(xref\\)\\*\\(\\|<[0-9]+>\\)\\'" buffer-name) (memq this-command '(xref-find-definitions)))) (with-eval-after-load 'xref (defvar xref--original-command nil) (advice-add 'xref-find-definitions :after (lambda (&rest _args) (with-current-buffer (window-buffer) (setq-local xref--original-command 'xref-find-definitions)))) (define-key xref--button-map [(control ?m)] (lambda () (interactive) (if (memq xref--original-command '(xref-find-definitions)) (call-interactively 'xref-quit-and-goto-xref) (setq xref--original-window nil) (call-interactively 'xref-goto-xref)))))