From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#25125: 25.1; copyright-fix-years pollutes undo history Date: Sat, 27 Jul 2019 13:41:46 +0200 Message-ID: <871rybk8lh.fsf@mouse.gnus.org> References: <878trsdgr9.fsf@fimbulvetr.bsc.es> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="109717"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 25125@debbugs.gnu.org To: =?UTF-8?Q?Llu=C3=ADs?= Vilanova Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 27 13:42:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrL5a-000SP1-Nm for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 13:42:14 +0200 Original-Received: from localhost ([::1]:45098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrL5Z-0003y2-IQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 27 Jul 2019 07:42:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39267) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hrL5V-0003oo-HP for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 07:42:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hrL5S-00069S-OY for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 07:42:08 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34934) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hrL5N-0005zy-QT for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 07:42:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hrL5N-0006Ax-LQ for bug-gnu-emacs@gnu.org; Sat, 27 Jul 2019 07:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Jul 2019 11:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25125 X-GNU-PR-Package: emacs Original-Received: via spool by 25125-submit@debbugs.gnu.org id=B25125.156422771423707 (code B ref 25125); Sat, 27 Jul 2019 11:42:01 +0000 Original-Received: (at 25125) by debbugs.gnu.org; 27 Jul 2019 11:41:54 +0000 Original-Received: from localhost ([127.0.0.1]:43750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrL5G-0006AH-5R for submit@debbugs.gnu.org; Sat, 27 Jul 2019 07:41:54 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:36822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hrL5D-0006A5-OR for 25125@debbugs.gnu.org; Sat, 27 Jul 2019 07:41:52 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hrL59-00074U-4v; Sat, 27 Jul 2019 13:41:49 +0200 In-Reply-To: <878trsdgr9.fsf@fimbulvetr.bsc.es> ("=?UTF-8?Q?Llu=C3=ADs?= Vilanova"'s message of "Tue, 06 Dec 2016 20:00:58 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163849 Archived-At: Llu=C3=ADs Vilanova writes: > I have setup `copyright-update' to run every time I save a file in prog-m= ode: > > (add-hook 'prog-mode-hook > (lambda () > (add-hook 'before-save-hook > (lambda () > (save-excursion (copyright-fix-years)))))) > > Every time it runs in a file that has a copyright, a change is recorded i= nto the > undo history, even if the function performed no changes at all (i.e., the > copyright years were already correct). > > This makes it quite annoying to go back my modifications history, > since it keeps jumping up and down between the header and the actual > code. (I'm going through older Emacs bug reports that have received no response.) I tried testing this by just saying `M-x copyright-fix-years' in a file where it doesn't do any changes (like lisp/emacs-lisp/edebug.el). It didn't record anything in the undo history, so I'm unable to reproduce this bug in Emacs 27. Are you still seeing this? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no