From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#36861: 27.0.50; display-fill-column-indicator-mode in log-edit-mode Date: Wed, 31 Jul 2019 23:49:53 +0300 Organization: LINKOV.NET Message-ID: <871ry6rksu.fsf@mail.linkov.net> References: <875znjntfe.fsf@mail.linkov.net> <83mugvhr66.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="112831"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 36861@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jul 31 23:25:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hsw5u-000TCX-Ux for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jul 2019 23:25:11 +0200 Original-Received: from localhost ([::1]:44678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsw5u-0000QN-0X for geb-bug-gnu-emacs@m.gmane.org; Wed, 31 Jul 2019 17:25:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47038) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hsw5o-0000Nv-Kr for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2019 17:25:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hsw5n-0002MQ-Fm for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2019 17:25:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44373) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hsw5n-0002Ls-CD for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2019 17:25:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hsw5n-0004jV-7l for bug-gnu-emacs@gnu.org; Wed, 31 Jul 2019 17:25:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 31 Jul 2019 21:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36861 X-GNU-PR-Package: emacs Original-Received: via spool by 36861-submit@debbugs.gnu.org id=B36861.156460830018172 (code B ref 36861); Wed, 31 Jul 2019 21:25:03 +0000 Original-Received: (at 36861) by debbugs.gnu.org; 31 Jul 2019 21:25:00 +0000 Original-Received: from localhost ([127.0.0.1]:53193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsw5j-0004iw-Kh for submit@debbugs.gnu.org; Wed, 31 Jul 2019 17:24:59 -0400 Original-Received: from bonobo.elm.relay.mailchannels.net ([23.83.212.22]:60891) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hsw5h-0004ib-T1 for 36861@debbugs.gnu.org; Wed, 31 Jul 2019 17:24:58 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id CC4248C247A; Wed, 31 Jul 2019 21:24:56 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a99.g.dreamhost.com (100-96-86-80.trex.outbound.svc.cluster.local [100.96.86.80]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 040C78C235D; Wed, 31 Jul 2019 21:24:52 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a99.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Wed, 31 Jul 2019 21:24:56 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Befitting-Tangy: 7453062c26d3d2dc_1564608293295_2150495787 X-MC-Loop-Signature: 1564608293295:3435206708 X-MC-Ingress-Time: 1564608293294 Original-Received: from pdx1-sub0-mail-a99.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a99.g.dreamhost.com (Postfix) with ESMTP id 430E88109E; Wed, 31 Jul 2019 14:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=KvDiwKgUUwnetFjJ17P+pFd8Bxk=; b= ZJw74YRBXITgpgallfzwu/A2LTiTAcwVzffYth8lFco9ONQbDpEtDtv6FohSGPG8 k0r/R6U23MqELTRs279A9Xn7FfEo+2IriAIymXYrFRVjyDsuAso/O3VapvGYit4+ IYq1cHQngoZ6JEn/olTcYVa3qw4FbWP7tY4TLobsXeA= Original-Received: from mail.jurta.org (m91-129-103-76.cust.tele2.ee [91.129.103.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a99.g.dreamhost.com (Postfix) with ESMTPSA id 984DE8109C; Wed, 31 Jul 2019 14:24:48 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a99 In-Reply-To: <83mugvhr66.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 31 Jul 2019 05:30:09 +0300") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgeduvddrleehgdduheelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesmhdtreertdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdefrdejieenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdefrdejiedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegvlhhiiiesghhnuhdrohhrghenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:164192 Archived-At: --=-=-= Content-Type: text/plain >> (log-edit-mode . ((log-edit-font-lock-gnu-style . t) >> - (log-edit-setup-add-author . t))) >> + (log-edit-setup-add-author . t) >> + (display-fill-column-indicator-column . 78) >> + (eval . (display-fill-column-indicator-mode)))) > > This will cause an annoying message and prompt when editing Emacs > sources with an Emacs which doesn't yet have > display-fill-column-indicator-mode, right? Can we avoid that? I > routinely need to work on the latest sources with an older Emacs. Shouldn't local-variables functions ignore undefined variables and commands? Probably not, since such change won't help for older versions. Then one way is to put such lines to the init file to avoid typing `y' to confirm local variables while using emacs-26 to commit emacs-27 changes: (put 'display-fill-column-indicator 'safe-local-variable 'booleanp) (put 'display-fill-column-indicator-character 'safe-local-variable 'characterp) (put 'display-fill-column-indicator-column 'safe-local-variable (lambda (value) (or (booleanp value) (integerp value)))) (defun display-fill-column-indicator-mode ()) And for emacs-27 and future versions this patch is required as well: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=display-fill-column-indicator-cus-start.patch diff --git a/lisp/cus-start.el b/lisp/cus-start.el index e1d0bce2ad..036674ef14 100644 --- a/lisp/cus-start.el +++ b/lisp/cus-start.el @@ -650,7 +650,7 @@ minibuffer-prompt-properties--setter "26.1") (display-fill-column-indicator display-fill-column-indicator - boolean "27.1") + boolean "27.1" :safe booleanp) (display-fill-column-indicator-column display-fill-column-indicator (choice (const :tag "Use fill-column variable" @@ -659,9 +659,9 @@ minibuffer-prompt-properties--setter :value 70 :format "%v") integer) - "27.1") + "27.1" :safe (lambda (value) (or (booleanp value) (integerp value)))) (display-fill-column-indicator-character display-fill-column-indicator - character "27.1") + character "27.1" :safe characterp) ;; xfaces.c (scalable-fonts-allowed display boolean "22.1") ;; xfns.c --=-=-=--