From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#36843: 26.2; ERC lurker feature broken Date: Sat, 24 Aug 2019 12:45:19 -0400 Message-ID: <871rxao6lc.fsf@gmail.com> References: <877e80o5tb.fsf@thb.lt> <87v9uvmyib.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="253645"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2.90 (gnu/linux) Cc: Thibault Polge , 36843@debbugs.gnu.org To: Amin Bandali Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 24 18:46:25 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i1ZBG-0013hC-Ho for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Aug 2019 18:46:22 +0200 Original-Received: from localhost ([::1]:38642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1ZB4-0006Fz-N2 for geb-bug-gnu-emacs@m.gmane.org; Sat, 24 Aug 2019 12:46:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38446) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i1ZAw-0006EX-S4 for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 12:46:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i1ZAv-0004Zp-T9 for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 12:46:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34423) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1i1ZAv-0004ZT-QT for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 12:46:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1i1ZAv-00085L-KW for bug-gnu-emacs@gnu.org; Sat, 24 Aug 2019 12:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Aug 2019 16:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36843 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36843-submit@debbugs.gnu.org id=B36843.156666512831019 (code B ref 36843); Sat, 24 Aug 2019 16:46:01 +0000 Original-Received: (at 36843) by debbugs.gnu.org; 24 Aug 2019 16:45:28 +0000 Original-Received: from localhost ([127.0.0.1]:43244 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1ZAO-00084F-BG for submit@debbugs.gnu.org; Sat, 24 Aug 2019 12:45:28 -0400 Original-Received: from mail-io1-f41.google.com ([209.85.166.41]:40646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i1ZAM-00083t-3k for 36843@debbugs.gnu.org; Sat, 24 Aug 2019 12:45:26 -0400 Original-Received: by mail-io1-f41.google.com with SMTP id t6so27444410ios.7 for <36843@debbugs.gnu.org>; Sat, 24 Aug 2019 09:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=2JmCrnr5rbMcUq+X46K/L1wqEtmUkAA15wjuZzqznm4=; b=hYsQL6i3vvO4jO7JzFDCUVu7Knrbq1/mSSzIis5hXae8iT6aSus3gSpm9C9/0DEY4k za+oI2jCNMzA+saE7B89DJt24oGAWTB97NdJqAUmB1OnvqUWhwHmPYmtXpZe/n7eiYzL 2Q2W0+AWRD9rPiKU/5jHxYkDnytQFLf63vQ+11AaGgqBOe76CRSogp7vi+8zUDG9cybX W0vL4zDb2XaCZRm+rOBOMiSZ3EkOkneLhzx+cuS4WqmNHJdS/2N4xB/p86rt8jJ3joLY RdScqtVOSOu3SsVxYJQJ5IsyHI5cXzb1F/b+15rhfLjEq9w8FLmLrX6shSUWJd+P6itF 9OFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=2JmCrnr5rbMcUq+X46K/L1wqEtmUkAA15wjuZzqznm4=; b=V9SIBH6K/r0Kt5pAcjk1Qs3XyY+2ziNhLsKBTih6pqybdG54+TE6venNbBOstESwAd Vu2goeFdm903xXUavAimx+ETu+VUyreduFVgK7PmE0rHU5Rk4UtFu4Ex+2ONbd3De9pC 472+ccsaH45GxN3v0TX3AJHH5tYTiJRgGPztR1kmwiIuQFnuNkpoX27Qld3SiMTE8FvY 5/dintTnARaE8YcEMKwfAu9aOl5JVO78Whex8hs8MLQrAPDXHrXITGqMAveBF2SUfooD hS5mzUvTRd80MmVTunu+zx8FjkSOPKX2/IHVJJdZpKWJrdXycP8es0dcw2os3w/sh8AP ms8g== X-Gm-Message-State: APjAAAUCMvJm3tnDNZxl1DchgClN4lENb85iSNrR8Ix2DPcEPMQ8KumG cZO4/W3Zpe02eNb2pey0xV7Z/1cL X-Google-Smtp-Source: APXvYqzn/kgb9XSBRAE7LbW4U0yhieKWU9tCygf+CGLDgpOkH/PgInIk4MaOWzxVepxU42fHeQVtxQ== X-Received: by 2002:a02:810:: with SMTP id 16mr10492526jac.121.1566665120139; Sat, 24 Aug 2019 09:45:20 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id c3sm10684997iot.42.2019.08.24.09.45.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 24 Aug 2019 09:45:19 -0700 (PDT) In-Reply-To: <87v9uvmyib.fsf@gnu.org> (Amin Bandali's message of "Sat, 17 Aug 2019 14:34:52 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:165783 Archived-At: Amin Bandali writes: > From: Amin Bandali This address seems to be different than what's in the copyright list. Could you use that one, since otherwise it's a bit confusing as to whether I'm actually looking at the entry of the right person. > Date: Sat, 17 Aug 2019 14:09:11 -0400 > Subject: [PATCH] Fix erc-lurker-update-status > > Fix erc-lurker-update-status (bug#36843), broken since > d0fcaff514d2be16ccf73817f658318cf85221e3. > > * lisp/erc/erc.el: define `erc-message-parsed', lexically bind it in Instead of "lexically" I believe you actually mean "dynamically" (binding lexically is the cause of the bug). And I would reformat like this: Fix erc-lurker-update-status (bug#36843) Broken since 2013-08-22 "* lisp/erc/erc.el: Use lexical-binding". * lisp/erc/erc.el (erc-message-parsed): New variable. (erc-display-message): Dynamically bind it. (erc-lurker-update-status): Check it instead of using `parsed' directly. This results in `erc-lurker-state' being properly updated to keep track of non-lurkers, and thus `erc-lurker-p' returning correct results rather than return t for everyone.