From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#37202: shadowfile-tests: two failures on macOS Date: Fri, 20 Sep 2019 14:35:52 +0200 Message-ID: <871rwbqh5j.fsf@gmx.de> References: <871rx5wvmo.fsf@gmx.de> <87blw8oz9d.fsf@gmx.de> <87muflpoiz.fsf@gmx.de> <87ftlcxnm0.fsf@gmx.de> <8736h8mm48.fsf@gmx.de> <87y2yzkxle.fsf@gmx.de> <87a7b8idm1.fsf@gmx.de> <87woe9halp.fsf@gmx.de> <871rwck0e1.fsf@gmx.de> <62ea6270-30a8-fe82-e9ed-e12a733b6983@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="176161"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Stefan Kangas , 37202@debbugs.gnu.org To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Sep 20 14:38:01 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iBIAi-000jet-Sl for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 14:38:01 +0200 Original-Received: from localhost ([::1]:58936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBIAf-00011m-TP for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Sep 2019 08:37:58 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47050) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iBI9o-00008Z-0y for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 08:37:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iBI9m-0007Ev-VC for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 08:37:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iBI9m-0007E1-EL for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 08:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iBI9m-0003Xp-6p for bug-gnu-emacs@gnu.org; Fri, 20 Sep 2019 08:37:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Sep 2019 12:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37202 X-GNU-PR-Package: emacs Original-Received: via spool by 37202-submit@debbugs.gnu.org id=B37202.156898298013570 (code B ref 37202); Fri, 20 Sep 2019 12:37:02 +0000 Original-Received: (at 37202) by debbugs.gnu.org; 20 Sep 2019 12:36:20 +0000 Original-Received: from localhost ([127.0.0.1]:56922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBI95-0003Wn-Vv for submit@debbugs.gnu.org; Fri, 20 Sep 2019 08:36:20 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:45063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iBI94-0003WY-3q for 37202@debbugs.gnu.org; Fri, 20 Sep 2019 08:36:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1568982956; bh=gD8FtiRk6HJYTXB6oBLhsy7l3DNsDSPALnHIHLQAJms=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date; b=RBmuaLYmASbmNaHcRfU3Y/hRWxWwhsAwVxEircTLA/BzAq5Hlk1XeNEAnMtmDc6QD gaExmHEErg0xwG89CBXOsnXfFb9BGSgTDrmxUdmIJmfs5p1Ag2Zwwq+LDggflWt1hh MZOmL/cDQSgIGAHCTceaBJg0YG/mQJDnOuio75xM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from detlef.gmx.de ([212.86.38.214]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNbp3-1iaGkJ1dW7-00P9q9; Fri, 20 Sep 2019 14:35:56 +0200 X-Provags-ID: V03:K1:626eQ1ZhpwNhsk5qnCNT5YvWGjQw9fy2b1Z2fgvyIdAaJaW5GJ/ 1fE+ZJwzXgeqPU8WrHlITQElWOnHT/4jElC99n0rq0mdEMqHST1pQsuqXQXb8JCK5tY9zgn ChPrqVKu+mwLznweyDzfo7KX6dzTLvJjZnDqNITuPvuGrQYPrmIoLho0l7i/algETvdTj55 tGC4rYcNtGIFhbWysBi6g== X-UI-Out-Filterresults: notjunk:1;V03:K0:GZ7mXCPMW2o=:yY+LSWPWJkUqntDfIWB1Dc D3/X0XgR/c1Bze+cKkppzHlzqW7IB3nun4OpvMC3ittjuwAYfszg27BDjKcbi/8nNPXYNgwfg 5oJC5xc/foiRDEs/Xn5RppwKg9BNylaAq86uXemumQPtAKKGC4JTxW6jhzH66UwChg95RzYvF TbZL41xDooqCYn0HQ7IBOMYrxKfSB9+E/07PI2ebOGLI0skpytktm57N3ZLjQG0U+GJsWktpK HFjR2fl+CpTShq64QfJx+W9RH4prr3SczoF/5gE+NZSR6coQ0CiwTmRVYcj64u0udUG4kuSIO R1vs+H6e1PnjSL2XxF1I9CGWYZnGzVqEOKfBewpuaqGgCAlIfifoGELeUIQCnWR4sPylfao8Z cwLfuv98RVSp43kn86yiOlNEwKP/w04AuqZupn9hQG4E2EQYgN5EtBm+t+3QmKn+M9+C2xwAZ Fm4TMUDVGh8xdor+izqK18D7VcahjnFXRFbMrLGkQh1P3bkXDphTR2QunJ70KOSPog+yyWfil YWa+0xNADO525/6bejb32pM1zHE0hs0gT0xR3N2QDuiVJGC4RV6sDXFLw8zz2vXwpzur8+bat MeTkzzzKX0Rri6eATKCgGIbugS5inEKomPsxd4hPsCVJyT9Lm/V7pBn2KAzr3QZgRyYG/t43P dIarke6ed+lz2vGBExcOxpwOVRvSgtMQ2y36+aM5jkAZ5puD1ztbC+BLjA1iO293eNr+njZ7D rS/ArmRE4WTqq4v2aEsylZjXLTH5sJhRIW60P8LVwLGNleGyOYPemyROw4/EFlnfiQM82b8V X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:166759 Archived-At: Paul Eggert writes: Hi Paul, > Could you explain how the backtrace implicates file-attributes? I see > the following in the backtrace, but I don't see file-attributes listed > there, and when I look at the tramp-handle-file-modes source it > appears that file-attributes returned nil which is what I think you > expected. > > Test shadow-test08-shadow-todo backtrace: > signal(args-out-of-range ("([] 1)")) > tramp-signal-hook-function(args-out-of-range ([] 1)) > tramp-mode-string-to-int(nil) > > tramp-handle-file-modes(#("/mock:localhost:/build/shadowfile-tests75GTBI" > 6 15 (tramp-default t))) Right, `file-attributes' does not seem to have raised an error. But it still seems to behave differently. The code is --8<---------------cut here---------------start------------->8--- (defun tramp-handle-file-modes (filename) "Like `file-modes' for Tramp files." (let ((truename (or (file-truename filename) filename))) (when (file-exists-p truename) (tramp-mode-string-to-int (tramp-compat-file-attribute-modes (file-attributes truename)))))) --8<---------------cut here---------------end--------------->8--- That means, (file-attributes truename) returns nil although (file-exists-p truename) returns non-nil. That seems to be a changed behaviour to me, I don't remember having seen this before. Arguably, the test shall better use `access-file' but `file-exists-p'. But anyway, such subtle differences could break Tramp. I still use conditional wording, because I cannot debug on hydra. And I cannot say for sure that your changes have caused the problem. For the time being, I'll adapt `tramp-handle-file-modes' in order to unbreak the errors on hydra. Best regards, Michael.