From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#9516: imagemagick-register-types and image-file-name-extensions Date: Wed, 25 Sep 2019 22:57:07 +0300 Organization: LINKOV.NET Message-ID: <871rw4qhd8.fsf@mail.linkov.net> References: <87wrda6k5p.fsf@mail.jurta.org> <874o0cd1ea.fsf@mail.jurta.org> <87k48zeyeo.fsf@stupidchicken.com> <87fwjney3e.fsf@stupidchicken.com> <874o00d8de.fsf@mail.jurta.org> <87ef04woak.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="236538"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 9516@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Sep 25 22:33:06 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iDDyD-000zGX-Un for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Sep 2019 22:33:06 +0200 Original-Received: from localhost ([::1]:57092 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDDyA-0004Ty-U0 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Sep 2019 16:33:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42784) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iDDxO-0004P4-3O for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 16:32:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iDDxI-0007wh-Iq for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 16:32:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33622) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iDDxC-0007tv-NF for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 16:32:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iDDxC-00027v-IH for bug-gnu-emacs@gnu.org; Wed, 25 Sep 2019 16:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Sep 2019 20:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9516 X-GNU-PR-Package: emacs Original-Received: via spool by 9516-submit@debbugs.gnu.org id=B9516.15694434918118 (code B ref 9516); Wed, 25 Sep 2019 20:32:02 +0000 Original-Received: (at 9516) by debbugs.gnu.org; 25 Sep 2019 20:31:31 +0000 Original-Received: from localhost ([127.0.0.1]:42440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDDwh-00026m-Aa for submit@debbugs.gnu.org; Wed, 25 Sep 2019 16:31:31 -0400 Original-Received: from anteater.elm.relay.mailchannels.net ([23.83.212.3]:35684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iDDwc-00026Q-T5 for 9516@debbugs.gnu.org; Wed, 25 Sep 2019 16:31:29 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 07F3A8C1000; Wed, 25 Sep 2019 20:31:19 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a19.g.dreamhost.com (100-96-35-93.trex.outbound.svc.cluster.local [100.96.35.93]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 96EF48C1CD5; Wed, 25 Sep 2019 20:31:18 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a19.g.dreamhost.com ([TEMPUNAVAIL]. [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.17.5); Wed, 25 Sep 2019 20:31:18 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Chief-Absorbed: 530b7e27038a3a3c_1569443478838_1052595944 X-MC-Loop-Signature: 1569443478838:692002737 X-MC-Ingress-Time: 1569443478838 Original-Received: from pdx1-sub0-mail-a19.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTP id 90412818D2; Wed, 25 Sep 2019 13:31:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jurta.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=jurta.org; bh=rdyepMinb0DZy9btVskAg/Pkrvk=; b=Y WEv/sKE8mjlRdM5n2TuTnt4Ed1fQioxdY3NjYgBa1oJL9eHQ1dxxNnNwiWnk2YAg V2iPXvxVgYkwHqUjD89qZqz2CS/sGceYM+qB3Cy6XxbDCK3u63f4B7XNDK48qRib pDtxuHko93rwAHx4P7elQJqV2+g3yxOjCeHQNHJgKk= Original-Received: from mail.jurta.org (m91-129-105-145.cust.tele2.ee [91.129.105.145]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a19.g.dreamhost.com (Postfix) with ESMTPSA id 4F153818BA; Wed, 25 Sep 2019 13:31:14 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a19 In-Reply-To: <87ef04woak.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 25 Sep 2019 14:30:59 +0200") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedrfedvgdduheduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhrihesjhhurhhtrgdrohhrgheqnecukfhppeeluddruddvledruddthedrudegheenucfrrghrrghmpehmohguvgepshhmthhppdhhvghlohepmhgrihhlrdhjuhhrthgrrdhorhhgpdhinhgvthepledurdduvdelrddutdehrddugeehpdhrvghtuhhrnhdqphgrthhhpefluhhrihcunfhinhhkohhvuceojhhurhhisehjuhhrthgrrdhorhhgqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopehlrghrshhisehgnhhushdrohhrghenucevlhhushhtvghrufhiiigvpedt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167188 Archived-At: >> Then we could change the function `image-file-name-regexp' >> that dynamically constructs a composite regexp from >> `image-file-name-extensions' and `image-file-name-regexps'. >> What we could do is to add to its return value a regexp added >> in `imagemagick-register-types' to `image-type-file-name-regexps' >> with the assoc value `imagemagick': > > [...] > >> + (mapconcat >> + 'identity >> + (delq nil (list exts-regexp >> + image-file-name-regexps >> + (car (rassq 'imagemagick image-type-file-name-regexps)))) >> + "\\|"))) >> >> This is a temporary solution for the next release of 24.1 that >> will allow image-dired.el to display Imagemagick supported images. >> >> I think in 24.2, defcustoms in image-file.el should be deprecated >> and packages should use `image-type-file-name-regexps' instead. > > This was seven years ago, but the patch wasn't applied. I know that > ImageMagick is slightly semi-deprecated now, but I think this patch > possibly makes sense anyway. There was no hurry in installing this because all widely used formats are already presented in image-type-file-name-regexps. > I don't use the Dired thumbnail stuff, though. Did anybody have an > objection to this that didn't land in the bug tracker? Sorry, I can't confirm if the patch still works since I don't remember how I tested it long ago, so not sure if this change might break something.