From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#25190: Initialization of `dired-mode-map' in by the `dired-x' feature is not safe Date: Wed, 09 Oct 2019 09:41:02 +0200 Message-ID: <871rvmqsc1.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="262784"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 25190@debbugs.gnu.org To: Alexander Shukaev Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 19:11:53 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIFVB-0016He-Eb for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 19:11:53 +0200 Original-Received: from localhost ([::1]:52857 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIFVA-0007d6-62 for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 13:11:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41042) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI6bj-0002Cz-3e for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI6bh-00054a-UX for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43199) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iI6bh-00054V-R1 for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iI6bh-0001QJ-Mk for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 03:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 07:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25190 X-GNU-PR-Package: emacs Original-Received: via spool by 25190-submit@debbugs.gnu.org id=B25190.15706068675387 (code B ref 25190); Wed, 09 Oct 2019 07:42:01 +0000 Original-Received: (at 25190) by debbugs.gnu.org; 9 Oct 2019 07:41:07 +0000 Original-Received: from localhost ([127.0.0.1]:52017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6ap-0001Op-IU for submit@debbugs.gnu.org; Wed, 09 Oct 2019 03:41:07 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:56418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iI6ao-0001Og-7R for 25190@debbugs.gnu.org; Wed, 09 Oct 2019 03:41:06 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iI6ak-0004Xh-NY; Wed, 09 Oct 2019 09:41:05 +0200 In-Reply-To: (Alexander Shukaev's message of "Tue, 13 Dec 2016 01:52:31 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168724 Archived-At: Alexander Shukaev writes: > consider the two > > ;;; KEY BINDINGS. > > (define-key dired-mode-map "\C-x\M-o" 'dired-omit-mode) > (define-key dired-mode-map "*O" 'dired-mark-omitted) [...] > sections. Both can easily fail. For instance, > > (define-key dired-mode-map "%Y" 'dired-do-relsymlink-regexp) > > assumes that the "%" prefix command has been defined in > `dired-mode-map' which is not at all true for any customization. The > `easy-menu-add-item' calls suffers from similar issue. It should be > possible to conditionally disable these code sections or even remove > them altogether as they are maldesigned. I've now added some checks to Emacs 27 to ensure that dired-x doesn't try to define keys in sub-keymaps that doesn't exist. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no