From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20153: 24.4.91; destructive add-face-text-property and string deep copying Date: Wed, 09 Oct 2019 19:45:54 +0200 Message-ID: <871rvl95il.fsf@gnus.org> References: <87bnjnyhtb.fsf@gmail.com> <874l0iwrfg.fsf@gnus.org> <83blupvo93.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="97023"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 20153@debbugs.gnu.org, ohwoeowho@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 09 21:38:33 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIHn6-000P8V-Vb for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 21:38:33 +0200 Original-Received: from localhost ([::1]:55726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIHn5-0007OL-4P for geb-bug-gnu-emacs@m.gmane.org; Wed, 09 Oct 2019 15:38:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37311) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIG3D-0005NW-Qe for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 13:47:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIG3C-0006ie-Jq for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 13:47:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45210) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iIG3C-0006iX-Gy for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 13:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iIG3C-0003ZJ-Bw for bug-gnu-emacs@gnu.org; Wed, 09 Oct 2019 13:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Oct 2019 17:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20153 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 20153-submit@debbugs.gnu.org id=B20153.157064316313645 (code B ref 20153); Wed, 09 Oct 2019 17:47:02 +0000 Original-Received: (at 20153) by debbugs.gnu.org; 9 Oct 2019 17:46:03 +0000 Original-Received: from localhost ([127.0.0.1]:54031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIG2E-0003Xy-UE for submit@debbugs.gnu.org; Wed, 09 Oct 2019 13:46:03 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:40042) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iIG2D-0003XU-CT for 20153@debbugs.gnu.org; Wed, 09 Oct 2019 13:46:01 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iIG27-0002bd-6f; Wed, 09 Oct 2019 19:46:00 +0200 In-Reply-To: <83blupvo93.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 09 Oct 2019 20:10:16 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:168753 Archived-At: Eli Zaretskii writes: >> Instead I've now changed add_properties (and add_text_properties_1) to >> take a bool parameter to say whether they're allowed to be destructive >> or not, and make the add-face-text-property call that with false as the >> parameter if the object is a string. This fixes the test case for me >> and should hopefully have no measurable performance impact. > > Isn't that a backward-incompatible change? It is, but the previous behaviour was a bug. If you have a copy of a string and modify the copy, the original string shouldn't change. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no