From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures Date: Sun, 17 Nov 2019 21:19:48 +0100 Message-ID: <871ru6uufv.fsf@gnus.org> References: <62949967.3QoF1lfsEv@gabor> <87imniux7l.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="200576"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 38206@debbugs.gnu.org, Braun =?UTF-8?Q?G=C3=A1bor?= To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 17 21:21:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iWR2l-000q3Q-DE for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 21:21:11 +0100 Original-Received: from localhost ([::1]:56184 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWR2j-0001Vp-OU for geb-bug-gnu-emacs@m.gmane.org; Sun, 17 Nov 2019 15:21:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59715) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iWR2d-0001Vg-KW for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 15:21:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iWR2c-0000JI-KQ for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 15:21:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33899) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iWR2c-0000JE-HA for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 15:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iWR2c-0007A0-B4 for bug-gnu-emacs@gnu.org; Sun, 17 Nov 2019 15:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 17 Nov 2019 20:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38206 X-GNU-PR-Package: emacs Original-Received: via spool by 38206-submit@debbugs.gnu.org id=B38206.157402200427434 (code B ref 38206); Sun, 17 Nov 2019 20:21:02 +0000 Original-Received: (at 38206) by debbugs.gnu.org; 17 Nov 2019 20:20:04 +0000 Original-Received: from localhost ([127.0.0.1]:42720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWR1d-00078A-SV for submit@debbugs.gnu.org; Sun, 17 Nov 2019 15:20:04 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:53290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iWR1a-00077o-3L for 38206@debbugs.gnu.org; Sun, 17 Nov 2019 15:20:00 -0500 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iWR1R-0001bC-3p; Sun, 17 Nov 2019 21:19:51 +0100 In-Reply-To: (Stefan Monnier's message of "Sun, 17 Nov 2019 15:13:56 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171854 Archived-At: Stefan Monnier writes: > Not sure why you see it that way. `C-x v h` tells me: [...] > - (setq form (cl-macroexpand-all form > - (and (not full) '((cl-block) (cl-eval-when))))) I just assumed that the parameter was meaningful for cl-macroexpand-all... that is, that the ENV parameter for that function was something other thatn ENVIRONMENT for macroexpand-all. But I see I was wrong now; sorry. I have besmirched your patch. >> I think the right change here is to just deprecate the FULL parameter >> and remove the >> >> (and (not full) '((cl-block) >> (cl-eval-when))))) >> >> bit. Stefan? > > 100% agreement. OK, I'll go ahead and fix that up. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no