From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 38206@debbugs.gnu.org, "Braun Gábor" <braungb88@gmail.com>
Subject: bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures
Date: Sun, 17 Nov 2019 21:19:48 +0100 [thread overview]
Message-ID: <871ru6uufv.fsf@gnus.org> (raw)
In-Reply-To: <jwvpnhq9sa0.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sun, 17 Nov 2019 15:13:56 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
> Not sure why you see it that way. `C-x v h` tells me:
[...]
> - (setq form (cl-macroexpand-all form
> - (and (not full) '((cl-block) (cl-eval-when)))))
I just assumed that the parameter was meaningful for
cl-macroexpand-all... that is, that the ENV parameter for that function
was something other thatn ENVIRONMENT for macroexpand-all. But I see I
was wrong now; sorry. I have besmirched your patch.
>> I think the right change here is to just deprecate the FULL parameter
>> and remove the
>>
>> (and (not full) '((cl-block)
>> (cl-eval-when)))))
>>
>> bit. Stefan?
>
> 100% agreement.
OK, I'll go ahead and fix that up.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2019-11-17 20:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 8:20 bug#38206: 26.1; cl-prettyexpand incorrectly expands pushing to structures Braun Gábor
2019-11-17 19:19 ` Lars Ingebrigtsen
2019-11-17 20:13 ` Stefan Monnier
2019-11-17 20:19 ` Lars Ingebrigtsen [this message]
2019-11-17 22:02 ` Stefan Monnier
2019-11-18 10:00 ` Lars Ingebrigtsen
2019-11-20 16:26 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871ru6uufv.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=38206@debbugs.gnu.org \
--cc=braungb88@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).