From: Juri Linkov <juri@linkov.net>
To: Noam Postavsky <npostavs@gmail.com>
Cc: 40401@debbugs.gnu.org
Subject: bug#40401: 28.0.50; M-x landmark not exists, while described in manual
Date: Sun, 05 Apr 2020 02:56:17 +0300 [thread overview]
Message-ID: <871rp27qla.fsf@mail.linkov.net> (raw)
In-Reply-To: <85wo6wn06l.fsf@gmail.com> (Noam Postavsky's message of "Fri, 03 Apr 2020 09:55:30 -0400")
> Ah, you removed it in Emacs 26 actually (I didn't find the commit before
> because I did a git message search for 'landmark' but you put 'Landmark'
> in the commit message. I should add --regexp-ignore-case to log search
> commands).
Currently I'm working on making hi-lock case-insensitive in bug#40337,
and would be interested in ensuring git search case-insensitive as well.
When I tried to run
M-x vc-log-search RET landmark
it found that commit with upper-case 'Landmark' using the command:
git --no-pager log --no-color -i --grep=landmark .
I wonder if this -i (--regexp-ignore-case) here should use the same
logic as in many other search commands:
(if (and case-fold-search search-upper-case)
(isearch-no-upper-case-p regexp t)
case-fold-search)
so if there are no upper-case letters, then vc-log-search is case-insensitive,
otherwise with upper-case letters case-sensitive?
BTW, I use the following nice customization that highlights all found
occurrences in the log:
;; Highlight found occurrences in *vc-search-log* output buffer of vc-log-search.
;; Warning: uses Emacs regexps to highlight Git regexp - their syntax might differ!
(advice-add 'vc-git-log-search :after
(lambda (buffer pattern)
(with-current-buffer buffer
(vc-run-delayed
(highlight-regexp pattern 'hi-yellow)))))
and with fixes from bug#40337 it highlighted even 'Landmark'.
What I don't know is how to make this feature generally useful.
Maybe by adding a new customizable option for vc-git-log-search
that when non-nil will highlight the results?
prev parent reply other threads:[~2020-04-04 23:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 13:06 bug#40401: 28.0.50; M-x landmark not exists, while described in manual Jean Louis
2020-04-03 11:11 ` Noam Postavsky
2020-04-03 12:46 ` Eli Zaretskii
2020-04-03 13:35 ` Jean Louis
2020-04-03 14:08 ` Eli Zaretskii
2020-04-03 13:55 ` Noam Postavsky
2020-04-04 23:56 ` Juri Linkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rp27qla.fsf@mail.linkov.net \
--to=juri@linkov.net \
--cc=40401@debbugs.gnu.org \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).