unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stefan Kangas <stefan@marxist.se>
To: Michael Mauger <mmauger@protonmail.com>
Cc: "numbchild@gmail.com" <numbchild@gmail.com>,
	Michael Mauger <michael@mauger.com>,
	"40564@debbugs.gnu.org" <40564@debbugs.gnu.org>
Subject: bug#40564: 28.0.50; sql.el should add support PostgreSQL alias "postgresql" of "postgres"
Date: Sun, 26 Apr 2020 15:04:05 +0200	[thread overview]
Message-ID: <871roabdq2.fsf@stefankangas.se> (raw)
In-Reply-To: <iSz3U6Tb6m5wrZk9jvJKwEEWahkwF4BjwTwNJ9pA4nz3HdvUdk37gSZFUrWJ6HcHIOByaxqKOvLck1APchDVC9QRj45EPwhloPEOcLtHbBc=@protonmail.com> (Michael Mauger's message of "Sun, 26 Apr 2020 02:15:34 +0000")

Michael Mauger <mmauger@protonmail.com> writes:

> * Based on my understanding of this issue, I believe that this not a feature appropriate
>   for sql-mode, but rather it represents a weakness in the EJC->SQL mapping. Sql.el has
>   used `postgres' as the identifier of the PostgreSQL since the first commit in '99. It
>   was exposed as a user visible variable in `sql-product-alist' in 2003. EJC is using a
>   heuristic that may work for other products, but it definitely won't work for all (It is
>   broken for EJC's `sqlserver', which is `ms' in sql.el).

Thanks.  If I understand correctly, the recommendation is to report
this to the ejc developers.

Does that mean that this bug should be closed as "wontfix"?  Or is
there anything more to do here?

Best regards,
Stefan Kangas





  parent reply	other threads:[~2020-04-26 13:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-12  1:11 bug#40564: 28.0.50; sql.el should add support PostgreSQL alias "postgresql" of "postgres" stardiviner
2020-04-25 14:01 ` Stefan Kangas
2020-04-26  2:15   ` Michael Mauger via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-26  2:36     ` Michael Mauger via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-26 13:04     ` Stefan Kangas [this message]
2020-04-26 20:55       ` Michael Mauger via Bug reports for GNU Emacs, the Swiss army knife of text editors
2020-04-27  6:11         ` Stefan Kangas
2020-04-27  5:08       ` stardiviner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871roabdq2.fsf@stefankangas.se \
    --to=stefan@marxist.se \
    --cc=40564@debbugs.gnu.org \
    --cc=michael@mauger.com \
    --cc=mmauger@protonmail.com \
    --cc=numbchild@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).