unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Benjamin Riefenstahl <b.riefenstahl@turtle-trading.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Narayanan Nellayi <n.a.narayanan@gmail.com>, 41348@debbugs.gnu.org
Subject: bug#41348: emacs compilation with clang10 fails in the file lib-src/etags.c
Date: Sun, 17 May 2020 17:36:57 +0200	[thread overview]
Message-ID: <871rnih8ti.fsf@turtle-trading.net> (raw)
In-Reply-To: <83tv0ebn50.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 17 May 2020 18:24:11 +0300")

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

Eli Zaretskii writes:
> Does this mean Clang doesn't support __attribute__ ((__fallthrough__))?

It looks to like it does support it.  But it complains, that there is a
non-switch label "resetfvdef:" (for goto) between the annotation and the
next "case".  The correct fix is probably to move "resetfvdef:" after
the "case" labels.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-patch, Size: 453 bytes --]

diff --git a/lib-src/etags.c b/lib-src/etags.c
index 174c33a7a5..5eb7504e67 100644
--- a/lib-src/etags.c
+++ b/lib-src/etags.c
@@ -4196,9 +4196,9 @@ C_entries (int c_ext, FILE *inf)
 	      break;
 	    }
 	  FALLTHROUGH;
-	resetfvdef:
 	case '#': case '~': case '&': case '%': case '/':
 	case '|': case '^': case '!': case '.': case '?':
+	resetfvdef:
 	  if (definedef != dnone)
 	    break;
 	  /* These surely cannot follow a function tag in C. */

[-- Attachment #3: Type: text/plain, Size: 7 bytes --]


benny

  reply	other threads:[~2020-05-17 15:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-17  7:02 bug#41348: emacs compilation with clang10 fails in the file lib-src/etags.c Narayanan Nellayi
2020-05-17 15:24 ` Eli Zaretskii
2020-05-17 15:36   ` Benjamin Riefenstahl [this message]
2020-05-17 16:01     ` Narayanan Nellayi
2020-05-17 15:53 ` Narayanan Nellayi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rnih8ti.fsf@turtle-trading.net \
    --to=b.riefenstahl@turtle-trading.net \
    --cc=41348@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=n.a.narayanan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).