unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Michael Albinus <michael.albinus@gmx.de>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 42538@debbugs.gnu.org
Subject: bug#42538: 28.0.50; tramp-test35-remote-path test timing out on macOS
Date: Thu, 30 Jul 2020 13:53:32 +0200	[thread overview]
Message-ID: <871rktdxs3.fsf@gmx.de> (raw)
In-Reply-To: <CAArVCkSX9CL3WPSxaT=cNbkNh=_+OKHtGenag9ivNiMeqKERYw@mail.gmail.com> (Philipp Stephani's message of "Wed, 29 Jul 2020 21:34:47 +0200")

[-- Attachment #1: Type: text/plain, Size: 911 bytes --]

Philipp Stephani <p.stephani2@gmail.com> writes:

Hi Philipp,

>> > As you see, Tramp is stalled for 19 seconds, and then the timeout kills
>> > it. I will see whether I could rearrange the command sequence. Maybe
>> > writing the temp file just in shorter chunks, or so.
>>
>> Could you pls check, whether the appended patch works for you?
>
> Thanks, that appears to work, at least the test now finishes
> successfully within 13 seconds.

OK, so I've pushed the patch to the master branch. It will also be
merged into the emacs-27 branch after the release of 27.1.

> However, now it looks like tramp-test29-start-file-process is timing out...

Strange. The patch doesn't touch anything which is relevant for
tramp-test29-start-file-process, AFAICT. OK, same procedure as very
year: apply the appended patch to tramp-tests.el, and rerun the
test. The debug buffer shall tell us more.

Best regards, Michael.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1066 bytes --]

*** /tmp/ediffLaq99j	2020-07-30 13:51:19.872434363 +0200
--- /usr/local/src/emacs/test/lisp/net/tramp-tests.el	2020-07-30 13:47:25.070745596 +0200
***************
*** 4307,4312 ****
--- 4307,4314 ----
    (skip-unless (or (tramp--test-adb-p) (tramp--test-sh-p)))
    (skip-unless (not (tramp--test-crypt-p)))

+   (tramp--test-instrument-test-case 6
+   (with-timeout (30 (tramp--test-timeout-handler))
    (dolist (quoted (if (tramp--test-expensive-test) '(nil t) '(nil)))
      (let ((default-directory tramp-test-temporary-file-directory)
  	  (tmp-name (tramp--test-make-temp-name nil quoted))
***************
*** 4372,4378 ****
  	    (should (string-match "\\`foo" (buffer-string))))

  	;; Cleanup.
! 	(ignore-errors (delete-process proc))))))

  (ert-deftest tramp-test30-make-process ()
    "Check `make-process'."
--- 4374,4380 ----
  	    (should (string-match "\\`foo" (buffer-string))))

  	;; Cleanup.
! 	(ignore-errors (delete-process proc))))))))

  (ert-deftest tramp-test30-make-process ()
    "Check `make-process'."

  reply	other threads:[~2020-07-30 11:53 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25 19:04 bug#42538: 28.0.50; tramp-test35-remote-path test timing out on macOS Philipp
2020-07-26  9:19 ` Michael Albinus
2020-07-26 14:13   ` Philipp Stephani
2020-07-26 15:52     ` Michael Albinus
2020-07-26 21:39       ` Philipp Stephani
2020-07-27 15:28         ` Michael Albinus
2020-07-29 14:26           ` Michael Albinus
2020-07-29 19:34             ` Philipp Stephani
2020-07-30 11:53               ` Michael Albinus [this message]
2020-07-31 15:02                 ` Philipp Stephani
2020-07-31 15:22                   ` Philipp Stephani
2020-07-31 16:55                     ` Michael Albinus
2020-07-31 17:30                       ` Philipp Stephani
2020-07-31 18:04                         ` Michael Albinus
2020-07-31 18:59                           ` Andreas Schwab
2020-07-31 19:53                           ` Philipp Stephani
2020-08-01 18:15                             ` Michael Albinus
2020-08-01 19:24                               ` Philipp Stephani
2020-08-01 19:27                                 ` Philipp Stephani
2020-08-02 11:37                                   ` Michael Albinus
2020-08-02 14:29                                     ` Philipp Stephani
2020-08-02 15:29                                       ` Michael Albinus
2020-08-02 11:32                                 ` Michael Albinus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rktdxs3.fsf@gmx.de \
    --to=michael.albinus@gmx.de \
    --cc=42538@debbugs.gnu.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).