From: Lars Ingebrigtsen <larsi@gnus.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: Michael Heerdegen <michael_heerdegen@web.de>,
33301@debbugs.gnu.org, Noam Postavsky <npostavs@gmail.com>
Subject: bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.."
Date: Sat, 22 Aug 2020 16:58:19 +0200 [thread overview]
Message-ID: <871rjyloc4.fsf@gnus.org> (raw)
In-Reply-To: <871s7uqbvf.fsf@gmail.com> ("João Távora"'s message of "Fri, 09 Nov 2018 19:39:16 +0000")
João Távora <joaotavora@gmail.com> writes:
> - (string-match "\\`def" function)))
> + (string-match "\\`def" function)
> + (or (not (derived-mode-p 'emacs-lisp-mode))
> + (macrop (intern function)))))
As others noted, this means that indentation changes when you've
loaded/not loaded the file that defines the macro, which may be
awkward. But also, as your grep showed, there's oodles of functions in
Emacs the define stuff, and you'd have to add indentation specs to all
of them. And that doesn't take out-of-tree definitions into account.
So I don't really see how this can be fixed in any sensible way --
changing this heuristic will just annoy more than it fixes things, I
think.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2020-08-22 14:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 13:21 bug#33301: 27.0.50; broken elisp indentation for non-definition symbols starting with "def.." João Távora
2018-11-08 0:05 ` Noam Postavsky
2018-11-08 0:35 ` Michael Heerdegen
2018-11-08 9:52 ` João Távora
2018-11-09 0:13 ` Michael Heerdegen
2018-11-09 0:41 ` João Távora
2018-11-09 1:45 ` Michael Heerdegen
2018-11-09 9:04 ` João Távora
2018-11-09 9:51 ` Michael Heerdegen
2018-11-09 12:28 ` Noam Postavsky
2018-11-09 19:39 ` João Távora
2018-11-10 4:48 ` Michael Heerdegen
2018-11-10 10:28 ` João Távora
2018-11-10 10:54 ` Andreas Schwab
2018-11-10 12:46 ` João Távora
2018-11-10 12:53 ` Andreas Schwab
2018-11-10 16:05 ` João Távora
2018-11-10 16:18 ` João Távora
2020-08-22 14:58 ` Lars Ingebrigtsen [this message]
2020-08-22 16:19 ` João Távora
2020-08-23 12:26 ` Lars Ingebrigtsen
2020-08-23 13:39 ` João Távora
2020-08-24 13:12 ` Lars Ingebrigtsen
2020-08-25 19:59 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871rjyloc4.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=33301@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=michael_heerdegen@web.de \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).