From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jorge P. de Morais Neto Newsgroups: gmane.emacs.bugs Subject: bug#42248: 27.0.91; With enchant-2.2.8 from Guix, Flyspell errors out or gives lots of false positives Date: Mon, 24 Aug 2020 11:30:18 -0300 Message-ID: <871rjwi0at.fsf@disroot.org> References: <878sfvwbr0.fsf@disroot.org> <87mu2qyu94.fsf@disroot.org> <83k0xtcv7a.fsf@gnu.org> <87eeo1z5we.fsf@disroot.org> <83a6ypcnl4.fsf@gnu.org> <87sgchfbsi.fsf@disroot.org> <837dttcgxl.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2377"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42248@debbugs.gnu.org, stefan@marxist.se To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 24 16:45:43 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kADjB-0000UN-5n for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 16:45:41 +0200 Original-Received: from localhost ([::1]:54410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kADjA-0004Uv-4F for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Aug 2020 10:45:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kADV0-000265-Hk for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 10:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47236) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kADV0-0003Bu-4b for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 10:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kADV0-0001dm-2Q for bug-gnu-emacs@gnu.org; Mon, 24 Aug 2020 10:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jorge P. de Morais Neto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Aug 2020 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42248 X-GNU-PR-Package: emacs Original-Received: via spool by 42248-submit@debbugs.gnu.org id=B42248.15982794376276 (code B ref 42248); Mon, 24 Aug 2020 14:31:02 +0000 Original-Received: (at 42248) by debbugs.gnu.org; 24 Aug 2020 14:30:37 +0000 Original-Received: from localhost ([127.0.0.1]:58782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kADUa-0001d9-PU for submit@debbugs.gnu.org; Mon, 24 Aug 2020 10:30:37 -0400 Original-Received: from knopi.disroot.org ([178.21.23.139]:39638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kADUW-0001cw-N2 for 42248@debbugs.gnu.org; Mon, 24 Aug 2020 10:30:35 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 2321A52995; Mon, 24 Aug 2020 16:30:30 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Original-Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NwyOxFkacQNY; Mon, 24 Aug 2020 16:30:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1598279423; bh=newP/zNBCW9w4tsvnfqlqbS+b/AK+DqdeskTMVxEFTY=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=U5eMAZ/l9DCl4svUVc8GygSa/dW+NxVpKfGBd4dHBjxkiFjE5pTS/ZrGJdiB2qn9I 5HlJJg01KMUsKLtocjerExgSXPgG/EJQogjQJbAUr26wFqxFl5PMTo2JVYTnLgG1Uu ApQG1GGB2O3vzj1gkoDHJwawF43/FEyYAnoHzXfZBKDLZXAiJGhzhT5O4r0hT28WTz vwS69qf81OcBaix/kJW6laK6pk9WyW52bdR0vjDvDLgFJXU/Fyv691rsNXzy/iUx0R dzF3mpq93ej9TQR/H3+XEbov6mECGc8Hvc+6Vei4VBKjYbvxM9QoUcwIzFBQ6nXsR7 PJ0Zq42xD3n9A== In-Reply-To: <837dttcgxl.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186157 Archived-At: Em [2020-08-20 qui 21:26:14+0300], Eli Zaretskii escreveu: > I have two comments about this: > > (a) isn't this because Enchant invocation fails as you've > established, due to the -B switch? > > (b) are you sure the above at all matters? e.g., with Hunspell > (which is what I have here) it doesn't > > Bottom line: someone who has Enchant installed will have to step > through the code which invokes it and sets up spell-checking, and see > what goes wrong with that version of Enchant that uses Aspell. OK, so in the weekend I started stepping trough the Enchant setup code in ispell.el. I have already made two small but important corrections. The provisional patch is at the end of this message, but it is not enough to fix the problem, so you may want to wait until I finish the job---maybe next weekend? In order to step though the Enchant setup code, I: 1. Open a new Emacs instance 2. Invoke M-x edebug-all-defs 3. Open ispell.el 4. Invoke M-x eval-buffer twice Is this the best way to step though the setup code? And I have found weird behavior of enchant-lsmod-2 on the command line. See: $ enchant-lsmod-2 -word-chars en_us 0123456789 Shouldn't the output above include the apostrophe? And this happens both on Guix's enchant 2.2.8 and on a locally compiled enchant 2.2.9. I have asked the #abiword channel on irc.gnome.org and also subscribed to the abiword-dev mailing list---I'll ask there if there is no answer in IRC. Best regards --8<---------------cut here---------------start------------->8--- --- 27.1/ispell.el 2020-08-24 11:09:38.429199892 -0300 +++ lisp/ispell.el 2020-08-23 16:49:07.134580642 -0300 @@ -1237,11 +1237,12 @@ "Find Enchant's dictionaries, and record in `ispell-enchant-dictionary-alist'." (let* ((dictionaries (split-string - (ispell--call-enchant-lsmod "-list-dicts" (buffer-string)) " ([^)]+)\n")) + (ispell--call-enchant-lsmod "-list-dicts") + " ([^)]+)\n")) (found (mapcar #'(lambda (lang) `(,lang "[[:alpha:]]" "[^[:alpha:]]" - ,(ispell--get-extra-word-characters) t nil nil utf-8)) + ,(ispell--get-extra-word-characters lang) t nil nil utf-8)) dictionaries))) ;; Merge into FOUND any elements from the standard ispell-dictionary-base-alist ;; which have no element in FOUND at all. --8<---------------cut here---------------end--------------->8--- -- - - If an email of mine arrives at your spam box, please notify me. - Please adopt free/libre formats like PDF, ODF, Org, LaTeX, Opus, WebM and 7z. - Free/libre software for Replicant, LineageOS and Android: https://f-droid.org - [[https://www.gnu.org/philosophy/free-sw.html][What is free software?]]