From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch. Date: Tue, 13 Oct 2020 23:14:01 +0300 Organization: LINKOV.NET Message-ID: <871ri1g9yu.fsf@mail.linkov.net> References: <20200929121317.GA27007@ACM> <83wo0ck5ig.fsf@gnu.org> <20200929153355.GB27007@ACM> <87y2ks819k.fsf@gnus.org> <87y2krdqsk.fsf@mail.linkov.net> <87y2kp93dn.fsf@mail.linkov.net> <87mu0z3zxf.fsf@mail.linkov.net> <871riav4os.fsf@mail.linkov.net> <21c5738b-e9f2-465f-9ca3-8947a5b9191d@default> <874kmzz03q.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31510"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Alan Mackenzie , Lars Ingebrigtsen , 43702@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 13 22:20:54 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSQmz-00084Y-O5 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 22:20:53 +0200 Original-Received: from localhost ([::1]:34974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSQmy-0000QO-O3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 16:20:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51916) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSQmB-0007zF-Sn for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 16:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37457) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSQmB-0006xg-Aw for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 16:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSQmA-0002An-Qw for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 16:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Oct 2020 20:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43702 X-GNU-PR-Package: emacs Original-Received: via spool by 43702-submit@debbugs.gnu.org id=B43702.16026203848318 (code B ref 43702); Tue, 13 Oct 2020 20:20:02 +0000 Original-Received: (at 43702) by debbugs.gnu.org; 13 Oct 2020 20:19:44 +0000 Original-Received: from localhost ([127.0.0.1]:49002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSQls-0002A5-2M for submit@debbugs.gnu.org; Tue, 13 Oct 2020 16:19:44 -0400 Original-Received: from relay3-d.mail.gandi.net ([217.70.183.195]:50217) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSQlp-00029d-F9 for 43702@debbugs.gnu.org; Tue, 13 Oct 2020 16:19:42 -0400 X-Originating-IP: 91.129.102.160 Original-Received: from mail.gandi.net (m91-129-102-160.cust.tele2.ee [91.129.102.160]) (Authenticated sender: juri@linkov.net) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 9F42960004; Tue, 13 Oct 2020 20:19:33 +0000 (UTC) In-Reply-To: (Drew Adams's message of "Mon, 12 Oct 2020 16:07:38 -0700 (PDT)") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190450 Archived-At: >> > It's helpful in pretty much any context where regexps >> > are matched against text, IMO. >> >> I think you are right. So here is a patch that implements this: > > It's probably not my place to criticize your patch. > But in case it helps: > > I don't understand why you change the signature of > `replace-highlight' by adding parameter MATCH-DATA. > > I just use (match-beginning GROUP) and (match-end GROUP), > instead of explicitly passing the match data and then > copying it all with `butlast' etc. just to find the > group's match beginning and end. But as you can see in the patch, it doesn't use (match-data). It uses the variable 'real-match-data'.